update dynamic core submodule with hord=-5 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2020
junwang-noaa
approved these changes
Oct 19, 2020
climbfuji
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
I don't understand enough about the science behind the change of the advection options in the dycore, but based on the information I have experiments were conducted to show that there is no negative impact on the results. The ccpp-framework changes are definitely good, thanks for including them.
DusanJovic-NOAA
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
atmos_cubed_sphere submodule will be updated.
Dependencies
ufs-community/ufs-weather-model#215
NOAA-EMC/GFDL_atmos_cubed_sphere#36