Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] ConMon histogram plot problem #133

Closed
EdwardSafford-NOAA opened this issue Apr 22, 2024 · 0 comments · Fixed by #134
Closed

[bug] ConMon histogram plot problem #133

EdwardSafford-NOAA opened this issue Apr 22, 2024 · 0 comments · Fixed by #134
Assignees

Comments

@EdwardSafford-NOAA
Copy link
Collaborator

EdwardSafford-NOAA commented Apr 22, 2024

At some point the ConMon's histogram plots stopped working. The cause of this problem is in image_gen/ush/mk_horz_hist.sh where the expected number of reals in the extracted data file is set for each obs type.

Downstream fromimage_gen/ush/mk_horz_hist.sh in each of the conmon_read_[obs type].x executables there is a check for the number of expected reals versus the number of reals actually found in the file. If these are different then the executable exits. And of course they are different, but that's a new thing. When it changed I can't say for certain but I think it must be a fairly recent event.

It's a valid question to ask why there is a check for any variance in the expected number of reals in the file. I'm not the original author of the script so I can't speak to the reasoning, but it must have been a necessary sanity check at some point. Given that the GSI-Monitor is to be deprecated in the not-to-distant future I'm inclined to change the expected reals and get this working with a minimal effort rather than explore this question in depth and significantly rewrite the mk_horz_hist.sh script.

@EdwardSafford-NOAA EdwardSafford-NOAA self-assigned this Apr 22, 2024
EdwardSafford-NOAA added a commit to EdwardSafford-NOAA/GSI-Monitor that referenced this issue Apr 22, 2024
Fix nreal values for image gen executables.
EdwardSafford-NOAA added a commit to EdwardSafford-NOAA/GSI-Monitor that referenced this issue Apr 23, 2024
Merge branch 'develop' into fix/conmon-133
EdwardSafford-NOAA added a commit that referenced this issue May 3, 2024
Fix nreal values for image gen executables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant