Ref #133 #134
Merged
Ref #133 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix nreal values for image gen executables.
Merge branch 'develop' into fix/conmon-133
EdwardSafford-NOAA
force-pushed
the
fix/conmon-133
branch
from
3358da3 to
7e28a60
Compare
xyzemc
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify expected nreal values for ConMon data files. Testing over the last 4 production cycles on wcoss2 indicates this fixes the problem with empty histogram plots.
At some point recently the ConMon's histogram plots stopped working. The cause of this problem is in
image_gen/ush/mk_horz_hist.shwhere the expected number of reals in the extracted data file is set for each obs type. These values are then used to compare with the actual observation contents in the extracted data files and execution halts if there is a difference. See #133 for more info.Resolves #133