Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MOM6 cap for 2-way ocean-wave coupling for HAFS #143

Open
wants to merge 5 commits into
base: dev/emc
Choose a base branch
from

Conversation

binli2337
Copy link

The mom_cap_methods.F90 file located in the MOM6/config_src/drivers/nuopc_cap directory is revised to convert imported Stokes drift components from a missing value (9.99e20) to zero. This update doesn't have any impacts on global applications.

@DeniseWorthen
Copy link
Collaborator

I think doing this via a hard-coded FillValue is problematic. It may work in UFS, but what about other users of the cap? Have you tried implementing this via a logical control flag (eg case_name) which for the hafs application is ufs.hafs.

You're also only checking one component of the stokes drift.

@jiandewang
Copy link
Collaborator

agree with @DeniseWorthen , NCAR is also using nuopc driver for their system

@binli2337
Copy link
Author

@DeniseWorthen ,@jiandewang Thank you for the suggestions. I will try to use the case_name option.

@jiandewang
Copy link
Collaborator

@binli2337 I am trying to understand your logic here.
in mom-cap you read in "case_name", then you added case_name in mom_inport subroutine agument list.
what value it will be for "case_name" in cap code when you call mom_import for non-hafs case ? It has to be assigned a value as it isn't optional in subroutine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants