Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two-way ocean-wave coupling feature to the HAFS applications #2584

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

binli2337
Copy link
Contributor

@binli2337 binli2337 commented Jan 30, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

The ufs-weather-model will be updated to include two-way ocean-wave coupling capability for HAFS applications.

Commit Message:

  * CMEPS - CMEPS is updated to transfer ocean-current fields from MOM6 to WW3 and to transfer the Stokes drift components from WW3 to MOM6 for the HAFS applications.
  * MOM6 - MOM6 cap is updated to convert a missing value to zero for the imported Stokes drift components for the ufs.hafs applications.
  * WW3 - WW3 cap is updated to convert a missing value to zero for the imported ocean-current fields for the ufs.hafs applications.
 

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • Updated input data is located at /scratch1/NCEPDEV/hwrf/save/Bin.Li/UFS-WM_RT/NEMSfv3gfs/input-data-20240501/WW3_input_data_20250114/mod_def.natl_6m.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen
Copy link
Collaborator

@binli2337 Don't you know the value which will be sent from non-overlapped regions (ie, the fillvalue). Why is it necessary to check for the difference between the field and the fillvalue ... for example in MOM6 : abs(stkx(i,j,ib)-fillValue) <= 0.01 ?

@binli2337
Copy link
Contributor Author

@DeniseWorthen When comparing floating point numbers, it is generally recommended to check if the absolute difference between the two numbers is less than a tiny value. In this specific case, since stkx and fillvalue are constant, it is probably not necessary to check the absolute difference. Thanks for reviewing the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HAFS applications to include 2-way ocean-wave coupling capability
2 participants