Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/changefldnames #29

Merged
merged 25 commits into from
Feb 27, 2020
Merged

Feature/changefldnames #29

merged 25 commits into from
Feb 27, 2020

Conversation

DeniseWorthen
Copy link
Contributor

@DeniseWorthen DeniseWorthen commented Feb 20, 2020 •
edited
Loading

Updates for
issue #28
issue #27
issue #26
Issue #30

The Atm/Ocn flux fields on atm grid have also been commented out in the prep_atm mediator phase since they are not used.

For the coupled model, this PR requires matching CICE and FV3 commits and the baselines will change due to the removal of the mediator fluxes in prep_ocn. Otherwise no baseline changes are expected.

The ability to build the CMEPS mediator is added to the module_EARTH_GRID_COMP.F90. Required build-related files are added.

DeniseWorthen and others added 24 commits October 4, 2019 10:57
@DeniseWorthen
Merge pull request #1 from NOAA-EMC/develop
95f9ac3 
Remove Theia (#10)
@DeniseWorthen
Merge pull request #2 from NOAA-EMC/develop
39b5e91 
merge noaa-emc/nems develop
@DeniseWorthen
Merge pull request #5 from NOAA-EMC/develop
eb563f4 
Change acc# on WCOSS to GFS-DEV (#17)
@DeniseWorthen
remove ice-ocean merge in prep_atm
fbfb3df
@DeniseWorthen
Merge pull request #8 from NOAA-EMC/develop
584c900 
debug mode for NEMS, additional minor changes in component mk files (…
@DeniseWorthen
Merge branch 'develop' into feature/nomerge2atm
a50e0d9
@DeniseWorthen
remove atm-ocn in prep_atm;remove associated FBs
7110838
@DeniseWorthen
comment vs ifdef
8e4187e
@DeniseWorthen
remove unnecessary prep_atm merges
c3fe0c1
@DeniseWorthen
remove custom merges in prep_atm which are not needed when
ca2677c 
field name changes are made of fv3 side for import directly
from cice
@DeniseWorthen
Merge remote-tracking branch 'origin/feature/remove_unused' into feat…
8327230 
…ure/aofluxes
@DeniseWorthen
move sum(weights) into datm part of loop; add wgtp01 for netLW
42075ce 
merge
@DeniseWorthen
remove unused code in prep_atm
a7daedf
@DeniseWorthen
Merge remote-tracking branch 'origin/feature/aofluxes' into feature/c…
42aae56 
…hangefldnames
@DeniseWorthen
use RWFields_tile for mediator dumps
793b2e4
@DeniseWorthen
clean up commented out code used for testing
c030896
@DeniseWorthen
add print statement of slow and fast counters for field dumping
c8a3c1b
@DeniseWorthen
more PET log info printout
6acefa8
@DeniseWorthen
add ability to write mediator a-o fluxes to file with statewrite_flag
d3ad0c5
@DeniseWorthen
return statewrite flags to their default setting
5923739
@DeniseWorthen
mediator aborts if a required mediator restart
fd0cd69 
file does not exist
@DeniseWorthen
add condition of 'not coldstart' to mediator abort
16cc11a 
when mediator restart files are missing
@DeniseWorthen
change sw field names from cice
101d109
@DeniseWorthen
Merge pull request #15 from DeniseWorthen/feature/changefldnamescice
8defb2f 
change sw field names from cice
@DeniseWorthen DeniseWorthen marked this pull request as ready for review February 25, 2020 13:08
@MinsukJi-NOAA
Copy link
Collaborator

Denise,
Do these changes affect s2s-model only? Do we need regression test results?

@DeniseWorthen
Copy link
Contributor Author

Minsuk,

These should not affect the standalone. Jun or Ratko could advise whether you need to test ufs-weather.

@RatkoVasic-NOAA
Copy link
Collaborator

Minsuk,

These should not affect the standalone. Jun or Ratko could advise whether you need to test ufs-weather.

Minsuk, I suggest you run the ufs-weather test on Hera, just to make sure that nothing is broken.

@MinsukJi-NOAA
Copy link
Collaborator

Ufs-weather-model regression tests passed on hera:
RegressionTests_hera.intel.log

Minsuk,
These should not affect the standalone. Jun or Ratko could advise whether you need to test ufs-weather.

Minsuk, I suggest you run the ufs-weather test on Hera, just to make sure that nothing is broken.

@DeniseWorthen
Add capablilty to build the CMEPS mediator in place of the
48debb8 
NEMS mediator using 'ifdef CMEPS' conditionals in
module_EARTH_GRID_COMP.F90 If CMEPS is built, the NUOPC field
contained in parm/fd.yaml will be used.
@MinsukJi-NOAA
Copy link
Collaborator

Ufs-s2s-model regression tests passed on hera:

rtreport.txt

@MinsukJi-NOAA
Copy link
Collaborator

Re-ran ufs-weather-model RT on hera due to additional changes (CMEPS mediator build capability). All tests passed.
RegressionTests_hera.intel.log

@MinsukJi-NOAA MinsukJi-NOAA merged commit c19bb03 into NOAA-EMC:develop Feb 27, 2020
MinsukJi-NOAA pushed a commit to MinsukJi-NOAA/NEMS that referenced this pull request May 8, 2020
@DeniseWorthen
Merge pull request NOAA-EMC#29 from NOAA-EMC/develop
25cc1d5 
cmeps integration changes (NOAA-EMC#55)
@DeniseWorthen DeniseWorthen deleted the feature/changefldnames branch May 27, 2020 11:30
hyunchul386 pushed a commit to hyunchul386/NEMS that referenced this pull request Jul 24, 2020
@binli2337
Changed module files. (NOAA-EMC#29)
12ce2fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@MinsukJi-NOAA MinsukJi-NOAA MinsukJi-NOAA approved these changes

@RatkoVasic-NOAA RatkoVasic-NOAA Awaiting requested review from RatkoVasic-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeniseWorthen @MinsukJi-NOAA @RatkoVasic-NOAA @junwang-noaa