cmeps integration changes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Theia (#10)
merge noaa-emc/nems develop
Change acc# on WCOSS to GFS-DEV (#17)
debug mode for NEMS, additional minor changes in component mk files (…
Code changes to support DEBUG compilation based on appBuilder specifi…
remove ice-ocean merge in prep_atm (#24)
merge develop
…h mvertens/nems_integration2_update3 that currently has a PR to cmeps master
add s4 rules (NOAA-EMC#49)
Update submodule pointer for NCEPLIBS-pyprodutil (NOAA-EMC#51)
Poring to Orion. (NOAA-EMC#53)
Remove CCPP dynamic build from NEMS (NOAA-EMC#54)
| @@ -334,6 +356,17 @@ SUBROUTINE EARTH_REGISTER(EARTH_GRID_COMP,RC_REG) | |||
| file=__FILE__)) & | |||
| return ! bail out | |||
| endif | |||
| if (.not.NUOPC_FieldDictionaryHasEntry( & | |||
| "mean_sensi_heat_flx_atm")) then | |||
There was a problem hiding this comment.
Denise, we do not have this change on "mean_sensi_heat_flx_atm" and "mean_laten_heat_flx_atm" in fv3atm, do we need to change them in fv3 too?
|
We do not need them in FV3. The name used by FV3 (mean_sensi_heat_flx) is still defined in the Dictionary and is used to define the fldsFrAtm in the mediator. Only the momentum fluxes need to be changed in the mediator and FV3 to be consistent w/ the CMEPS exchange fields. |
This was referenced Apr 24, 2020
Chsp physics update, global latlon grid, post changes and CCN-IN followup bugfix
NOAA-EMC/fv3atm#104
Merged
Denise, |
support for ufs-s2s-model debug compilaiton (NOAA-EMC#40)
junwang-noaa
approved these changes
Apr 28, 2020
|
Final RT passed, code is ready for commit after review. Thanks |
DeniseWorthen
added a commit
to DeniseWorthen/NEMS
that referenced
this pull request
Apr 28, 2020
cmeps integration changes (NOAA-EMC#55)
DeniseWorthen
added a commit
to DeniseWorthen/NEMS
that referenced
this pull request
May 23, 2020
* support for ufs-s2s-model debug compilaiton (NOAA-EMC#40) * automatically enable NEMS_BUILDOPT=DEBUG=Y based on coupledFV3_MOM6_CICE_debug.appBuilder * automatically use esmf/8.0.0g module based on coupledFV3_MOM6_CICE_debug.appBuilder * Change debug flag check from ifeq to findstring * Loading machine-dependent esmf debug module *Use S2S_DEBUB_MODULE env var to load machine-dependent esmf debug module *Require ufs-s2s-model/modules/${BUILD_TARGET}/fv3_coupled_debug file * cmeps integration changes (NOAA-EMC#55) * Bugfix i2a & Add Orion to module-setup (NOAA-EMC#61) * Add Orion to module-setup.*.inc * src/incmake/component_CCPP.mk: SUITES argument no longer mandatory for calling ccpp_prebuild.py (NOAA-EMC#62) Co-authored-by: Minsuk Ji <57227195+MinsukJi-NOAA@users.noreply.github.com> Co-authored-by: Mariana Vertenstein <mvertens@ucar.edu> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates some CMEPS configuration consistent with current master of CMEPS.
Related PRs:
fv3atm PR #104
CCPP physics PR #440
ufs-weather-model PR #108