Chsp physics update, global latlon grid, post changes and CCN-IN followup bugfix #104

junwang-noaa · 2020-04-21T14:25:33Z

In the commit:

CHSP from GFSv16 package is added to gfsphysics and ccpp/physics
add capability to output global_latlon to netcdf file
land surface model information is added to the history file, post lib is updated to 8.0.6
Add CCN-IN followup bugfix in GFS_typedefs.F90
Bugfix for Intel 18 on wcoss_cray, remove Intel 16 options for gaea
CMEPS integration changes

Related PRs:
ccpp/physics #440
#104
NEMS #55
ufs-weather-model #108

> > Co-authored-by: Jongil Han <jingil.han@noaa.gov>

…frey Whitaker Co-authored-by: Jeffrey Whitaker <Jeffrey.S.Whitaker@noaa.gov>

Co-authored-by: Jongil Han <jongil.han@noaa.gov>

Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>

Co-authored-by: Grant Firl <grantf@ucar.edu>

…physics/physics/sfc_diff.f; updates for CCPP

CHSP latlon post: bugfixes and missing updates for CCPP

climbfuji · 2020-04-24T13:20:45Z

gfsphysics/GFS_layer/GFS_physics_driver.F90

@@ -4275,7 +4309,7 @@ subroutine GFS_physics_driver                                 &
                          Statein%pgr, Statein%phil, clw, Stateout%gq0,     &
                          Stateout%gt0, Stateout%gu0, Stateout%gv0, rain1,  &
                          kbot, ktop, kcnv, islmsk, Statein%vvl, ncld,      &
-                          Diag%hpbl, hflx, evap, ud_mf, dt_mf, cnvw, cnvc,  &
+                          Diag%hpbl, hflxq, evapq, ud_mf, dt_mf, cnvw, cnvc,&


I am sure you have a reason for it, but I don't understand why this change is only for shalcnv, but not for samfshalcnv (or any other convection scheme)?

It is because only shalcnv among convection schemes needs kinematic sensible heat flux (hflx) and latent heat flux (evap) for the cloud base mass flux. The other convection schemes do not use hflx & evap.

Thanks, got it! We need to make sure - I'll create an issue to check - that none of the additional convection schemes in CCPP that are not in IPD use hflx & evap.

See NCAR/ccpp-physics#443

Co-authored-by: Denise Worthen <Denise.Worthen@noaa.gov>

climbfuji · 2020-04-25T13:52:25Z

gfsphysics/physics/ugwp_driver_v0.f

@@ -8,6 +8,7 @@ module sso_coorde
       use machine,      only: kind_phys
       real(kind=kind_phys),parameter :: pgwd  = 1._kind_phys
       real(kind=kind_phys),parameter :: pgwd4 = 1._kind_phys
+       logical debugprint = .false.


See comment here: NCAR/ccpp-physics#440 (comment)

junwang-noaa · 2020-04-28T01:44:33Z

Final RT passed, code is ready for commit after review. Thanks

JongilHan66

Changes for the canopy heat storage parameterization (CHSP), thermal roughness length, and increased background diffusivity and mixing length in the inversion layers look fine.

climbfuji

I did raise one question that remains unanswered (https://github.com/NOAA-EMC/fv3atm/pull/104/files?file-filters%5B%5D=.F90&file-filters%5B%5D=.f&file-filters%5B%5D=.f90&file-filters%5B%5D=.meta&file-filters%5B%5D=dotfile#r414570311), but this shouldn't delay the commit. Otherwise this is a bunch of important changes!

junwang-noaa · 2020-04-28T14:23:06Z

Jongil's answer: It is because only shalcnv among convection schemes need kinematic sensible heat flux (hflx) and latent heat flux (evap) for the cloud base mass flux. The other convection schemes do not use hflx & evap.

…

On Tue, Apr 28, 2020 at 9:52 AM Dom Heinzeller ***@***.***> wrote: ***@***.**** approved this pull request. I did raise one question that remains unanswered ( https://github.com/NOAA-EMC/fv3atm/pull/104/files?file-filters%5B%5D=.F90&file-filters%5B%5D=.f&file-filters%5B%5D=.f90&file-filters%5B%5D=.meta&file-filters%5B%5D=dotfile#r414570311), but this shouldn't delay the commit. Otherwise this is a bunch of important changes! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#104 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TKTNYSURXHGTX27W2TRO3NSHANCNFSM4MNLI66Q> .

DeniseWorthen

Looks great. All my changes are present as expected.

…ertAerosols Gf radiation update revert aerosols

GF_Tune_Oct2021

junwang-noaa and others added 11 commits April 17, 2020 14:42

point to ccpp branch chsp_latlon_post

6416bca

add chsp code changes from Jongil

77e08fc

> > Co-authored-by: Jongil Han <jingil.han@noaa.gov>

add landsfcmdl variable to model sfc history file meta data

8e1a061

add global latlon grid on write grid component, code changes from Jef…

c39ce10

…frey Whitaker Co-authored-by: Jeffrey Whitaker <Jeffrey.S.Whitaker@noaa.gov>

add chsp code changes in ccpp-physics

8da1f47

Co-authored-by: Jongil Han <jongil.han@noaa.gov>

remove support for legacy Intel compilers in CCPP gmake build

146171c

Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>

fix syntax error

642a96a

fix syntax error

85691b2

update ccpp physics, fix syntax error

2eca23f

update sflx.f in ccpp physics

556c882

CCN-IN followup bugfix

1d2ff50

Co-authored-by: Grant Firl <grantf@ucar.edu>

This was referenced Apr 21, 2020

Chsp latlon post ufs-community/ufs-weather-model#108

Merged

Add CHSP to ccpp/physics NCAR/ccpp-physics#440

Merged

climbfuji and others added 4 commits April 21, 2020 16:43

Bugfix for GNU compiler in io/module_wrt_grid_comp.F90; bugfix in gfs…

af3836f

…physics/physics/sfc_diff.f; updates for CCPP

Merge pull request #2 from climbfuji/chsp_latlon_post_dom_ccpp_mods

df9ea91

CHSP latlon post: bugfixes and missing updates for CCPP

merge fv3 dycore ccpp framework and physics to the latest repoes

42fd5f9

Merge remote-tracking branch 'upstream/develop' into chsp_latlon_post

389db45

climbfuji reviewed Apr 24, 2020

View reviewed changes

junwang-noaa and others added 2 commits April 24, 2020 20:20

cmeps integration changes

8ea431d

Co-authored-by: Denise Worthen <Denise.Worthen@noaa.gov>

update CCPP with tsfcl change

e32c3bf

DeniseWorthen mentioned this pull request Apr 24, 2020

cmeps integration changes NOAA-EMC/NEMS#55

Merged

fix timestr in module_cap_cpl.F90

173b86f

climbfuji requested changes Apr 25, 2020

View reviewed changes

fix syntax error in ugwp_driver_v0.F

1a9f0ad

junwang-noaa requested review from DusanJovic-NOAA, jswhit2 and JongilHan66 April 28, 2020 01:39

junwang-noaa requested a review from DeniseWorthen April 28, 2020 01:46

DusanJovic-NOAA approved these changes Apr 28, 2020

View reviewed changes

JongilHan66 approved these changes Apr 28, 2020

View reviewed changes

climbfuji approved these changes Apr 28, 2020

View reviewed changes

climbfuji mentioned this pull request Apr 28, 2020

Canopy Heat Storage Parameterization changes for PBL schemes NCAR/ccpp-physics#443

Closed

jswhit2 approved these changes Apr 28, 2020

View reviewed changes

point ccpp/physics back to NCAR master

827a276

DeniseWorthen approved these changes Apr 28, 2020

View reviewed changes

junwang-noaa merged commit bc9aa3b into NOAA-EMC:develop Apr 28, 2020

This was referenced Apr 28, 2020

cmeps integration changes #106

Closed

Bugfix for Intel 18 on wcoss_cray, remove support for legacy Intel compilers in CCPP gmake build #101

Closed

CCN-IN followup bugfix #99

Closed

create 'global_latlon' output_grid option #92

Closed

This was referenced Jun 4, 2020

add capability to write out global regular (non-gaussian) lat/lon grid history files #91

Closed

update post lib to 8.0.6 #83

Closed

add land_surface_model attribute in model sfc history file #74

Closed

junwang-noaa deleted the chsp_latlon_post branch February 12, 2021 20:27

climbfuji pushed a commit to climbfuji/fv3atm that referenced this pull request Aug 24, 2021

Merge pull request NOAA-EMC#104 from climbfuji/GF_RadiationUpdate_Rev…

9beb0f9

…ertAerosols Gf radiation update revert aerosols

SamuelTrahanNOAA referenced this pull request in SamuelTrahanNOAA/fv3atm Jun 13, 2022

Merge pull request NCAR#104 from hannahcbarnes/GF_Tune_Oct2021

3805e69

GF_Tune_Oct2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chsp physics update, global latlon grid, post changes and CCN-IN followup bugfix #104

Chsp physics update, global latlon grid, post changes and CCN-IN followup bugfix #104

junwang-noaa commented Apr 21, 2020 •

edited

Loading

climbfuji Apr 24, 2020

JongilHan66 Apr 28, 2020

climbfuji Apr 28, 2020

climbfuji Apr 28, 2020

climbfuji Apr 25, 2020

junwang-noaa commented Apr 28, 2020

JongilHan66 left a comment

climbfuji left a comment

junwang-noaa commented Apr 28, 2020 via email

DeniseWorthen left a comment

Chsp physics update, global latlon grid, post changes and CCN-IN followup bugfix #104

Chsp physics update, global latlon grid, post changes and CCN-IN followup bugfix #104

Conversation

junwang-noaa commented Apr 21, 2020 • edited Loading

climbfuji Apr 24, 2020

Choose a reason for hiding this comment

JongilHan66 Apr 28, 2020

Choose a reason for hiding this comment

climbfuji Apr 28, 2020

Choose a reason for hiding this comment

climbfuji Apr 28, 2020

Choose a reason for hiding this comment

climbfuji Apr 25, 2020

Choose a reason for hiding this comment

junwang-noaa commented Apr 28, 2020

JongilHan66 left a comment

Choose a reason for hiding this comment

climbfuji left a comment

Choose a reason for hiding this comment

junwang-noaa commented Apr 28, 2020 via email

DeniseWorthen left a comment

Choose a reason for hiding this comment

junwang-noaa commented Apr 21, 2020 •

edited

Loading