NOAA GSL updates to output new simulated satellite brightness temps #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EricJames-NOAA Can you open a UPP issue to link this PR? Thanks! |
Closed
WenMeng-NOAA
added
No Baseline Change
|
@EricJames-NOAA I ran the UPP standalone test with model data files you provided before and UPP control file from your PR. It appears to me simulated satellite products were generated. My test results are at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2021100815 |
|
@WenMeng-NOAA the results look good to me! Thank you for your test. |
WenMeng-NOAA
approved these changes
Oct 19, 2022
|
The UPP RT tests were completed on WCOSS2, Hera and Orion. No baseline update is needed from this PR. |
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Oct 18, 2023
Co-authored-by: benjamin blake <benjamin.blake@dlogin05.dogwood.wcoss2.ncep.noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates to UPP to output new simulated satellite brightness temperatures from the RRFS. The code was developed by Will Lewis from Wisconsin / SSEC, and merged into GSL RRFS_dev branch during 2022. It is now used in realtime RRFS_NA_3km system at GSL. Tests on Jet show identical output for RRFS except for the new fields.
Ka Yee Wong ran UPP regression tests on Hera, and the only non bitwise identical results are in the naming of the soil moisture content variable:
[Eric.James@hfe09 ejames]$ diff sfluxgrbf006_pe.txt sfluxgrbf006_pe_hera.txt
161c161
< 21:47496981:vt=2021021606:0-2 m below ground:6 hour fcst:SOILM Soil Moisture Content [kg/m^2]:
21:47496981:vt=2021021606:0-2 m below ground:6 hour fcst:SOIL_M Soil Moisture [kg/m^3]:
This discrepancy shows up for slightly more than half of the regression tests.