Pickup changes from GFSv16.3, and update 1D-decomposed GTG compatible with UPP #645
Conversation
…ion of GTG compatible with 2D decomposition of UPP. 2. Make hard code numx=2 optional and can be overwritten
|
@YaliMao-NOAA Please sync your branch with the top of the UPP develop. |
|
@YaliMao-NOAA It seems to me a lot of changes in this PR are synced from WAFS related updates from GFS V16.3 implementation? |
|
@YaliMao-NOAA Can you open a new UPP issue for syncing changes of WAFS from GFS V16.3 implementation? |
YaliMao-NOAA
changed the title
|
@YaliMao-NOAA Can you sync your branch one more time? Thanks! |
|
@WenMeng-NOAA |
| @@ -505,7 +447,7 @@ SUBROUTINE MDL2STD_P() | |||
|
|
|||
| ! Relabel the pressure level to reference levels | |||
| ! IDS = 0 | |||
| IDS = (/ 450,480,464,465,466,518,519,520,521,522,523,524,525,(0,I=14,50) /) | |||
There was a problem hiding this comment.
@YaliMao-NOAA It appears to me output ID 522 is still kept in this routine. Do you intend to remove it?
There was a problem hiding this comment.
This is a good point. I am going to consult UK and AWC whether to keep it for GFSv17, incluidng U/V/T too.
There was a problem hiding this comment.
@YaliMao-NOAA You might keep ID 522 in this PR and change later if it is needed. In that case, can you change "521,(0,I=10,50)" into "521,522,(0,I=11,50)"?
There was a problem hiding this comment.
@WenMeng-NOAA I removed 522 (for RH_ON_ICAO_STD_SFC) from UPP, and the code was modified accordingly.
sorc/ncep_post.fd/MDLFLD.f
Outdated
| (IGET(774)>0).OR.(IGET(747)>0).OR. & | ||
| (IGET(464)>0).OR.(IGET(467)>0).OR. & | ||
| (IGET(470)>0).OR.(IGET(476)>0).OR. & | ||
| (IGET(629)>0).OR.(IGET(630)>0).OR. & | ||
| (IGET(470)>0).OR. & |
There was a problem hiding this comment.
@YaliMao-NOAA You may remove this line since "IGET(470)>0" is available in line 934.
There was a problem hiding this comment.
Thank you! Good catch.
|
@YaliMao-NOAA Please verify wafs data file gfs.t00z.wafs.grb2f006 at my test /u/wen.meng/ptmp/gfs.2019083000 on Cactus and let me know if there are any discrepancies with your test. |
I compared your wafs output and mine at /lfs/h2/emc/ptmp/yali.mao/upp/com/gfs.20190830/00. They are not bit-wise consistent but with good value of rpn_corr and rpn_rms. Update: sorry I forgot to mention that the master files are bit-wise consistent. |
|
Hello, UPP RT tests have completed on Hera and Orion with no changes to results. |
|
To generate gtg product, should I still overwrite UPP/parm/gtg.cong.gfs with UPP/sorc/ncep_post.fd/post_gtg.fd/gtg.config.gfs? @YaliMao-NOAA |
Good point. Yes, sorc/ncep_post.fd/post_gtg.fd/gtg.config.gfs is the right one to generate GTG |
Can you pick up my driver script submit_run_post_gfs_gtg_wcoss2.sh at /u/wen.meng/noscrub/ncep_post/yali/UPP on Cactus to check any difference from yours? @YaliMao-NOAA |
|
I had another test run with a different number of CPUs, my two results are bit-wise consistent. |
Can you point me to your run directory? I don't see any reasons which made wafs files not bitwise identical between your test and my test. @YaliMao-NOAA |
Source code: /lfs/h2/emc/vpppg/noscrub/yali.mao/git/UPP.v17 on Cactus |
|
My new gtg test can duplicate Yali's test with some changes in test configuration. |
|
The UPP RT tests were completed on WCOSS2 with no changed results. This PR is ready for merging. |
WenMeng-NOAA
added
the
No Baseline Change
|
No baseline update is needed with this PR. |
Manually merge UPP changes made to GFS V16.3 branch as described in issue Sync wafs related changes from GFS V16.3 Implementation #654
As described in issue Make 1D decomposition of GTG compatible with UPP #644
It's a temporary and straightforward solution.