Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MISCLN.f updated to resolve issues in generating SPC fields using RRF… #682

Merged
merged 6 commits into from
Apr 7, 2023
Merged

MISCLN.f updated to resolve issues in generating SPC fields using RRF… #682

merged 6 commits into from
Apr 7, 2023

Conversation

EdwardColon-NOAA
Copy link
Contributor

MISCLN.f updated to resolve issues in generating SPC fields using RRFS-derived analysis output files.

@WenMeng-NOAA
Copy link
Collaborator

@EdwardColon-NOAA Can you open an UPP issue for this PR?

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. 3DRTMA labels Apr 3, 2023
@EdwardColon-NOAA
Copy link
Contributor Author

EdwardColon-NOAA commented Apr 3, 2023 via email

@WenMeng-NOAA WenMeng-NOAA linked an issue Apr 3, 2023 that may be closed by this pull request
Modified MISCLN.f to address issues in the production of SPC fields using RRFS input #683
Closed
@WenMeng-NOAA
Copy link
Collaborator

@EdwardColon-NOAA Can you sync your branch with the latest commit from the UPP develop branch? The instructions can be found at https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-authoritative-repository

@WenMeng-NOAA
Copy link
Collaborator

@EdwardColon-NOAA It would be better to change your folk from EMC_post to UPP. The instructions can be found at
#372

@EdwardColon-NOAA
Copy link
Contributor Author

EdwardColon-NOAA commented Apr 3, 2023 via email

@WenMeng-NOAA
Copy link
Collaborator

@EdwardColon-NOAA From my UPP RT tests for rtma there are following fields having changed results:

[Wen.Meng@hfe06 rtma_2020113000]$ cat WRFTWO.GrbF00.diff
159:126896615:UESH:level of free convection:rpn_corr=0.175501:rpn_rms=4.49026
160:127231266:VESH:level of free convection:rpn_corr=0.896837:rpn_rms=1.48491
161:127570519:ESHR:level of free convection:rpn_corr=0.790243:rpn_rms=3.51646
165:129310193:STPC:level of free convection:rpn_corr=0.413654:rpn_rms=0.0627944

You may look into my run directory /scratch1/NCEPDEV/stmp2/Wen.Meng/rtma_2020113000 on Hera. Please let me know if you any unexpected/missing changes.

@EdwardColon-NOAA
Copy link
Contributor Author

EdwardColon-NOAA commented Apr 3, 2023 via email

@EdwardColon-NOAA
Copy link
Contributor Author

EdwardColon-NOAA commented Apr 3, 2023 via email

@WenMeng-NOAA
Copy link
Collaborator

Hi, Just one more suggestion. Since the RRFS-based RTMA will be the version that will eventually be implemented in FY2025, it may make sense to shift over from using the HRRR-based RTMA regression tests to a RRFS-based test. Thanks, Edward On Mon, Apr 3, 2023 at 2:36 PM Edward Colon - NOAA Affiliate < @.> wrote:
…
Hi Wen, Those fields were expected to change due to the update in the effective layer mid-level calculation. The update allows for the intercomparison of HRRR and RRFS based results which possess a different number of vertical levels (50 vs 65) which yielded quite different U,V, and bulk wind shear results. We encountered this disparity during the last HWT but it was too late to address them at that point. I worked with Nathan at GSL to devise the effective layer level minimization approach to yield apples to apples comparisons between both parallels. Going forward, this change yields more realistic representations of wind shear in the RRFS-based result. Is it possible to adopt a new baseline for the RTMA regression test that incorporates these changes? Thanks, Edward -Edward On Mon, Apr 3, 2023 at 1:33 PM WenMeng-NOAA @.> wrote: > @EdwardColon-NOAA https://github.com/EdwardColon-NOAA From my UPP RT > tests for rtma there are following fields having changed results: > > @.*** rtma_2020113000]$ cat WRFTWO.GrbF00.diff > 159:126896615:UESH:level of free convection:rpn_corr=0.175501:rpn_rms=4.49026 > 160:127231266:VESH:level of free convection:rpn_corr=0.896837:rpn_rms=1.48491 > 161:127570519:ESHR:level of free convection:rpn_corr=0.790243:rpn_rms=3.51646 > 165:129310193:STPC:level of free convection:rpn_corr=0.413654:rpn_rms=0.0627944 > > You may look into my run directory > /scratch1/NCEPDEV/stmp2/Wen.Meng/rtma_2020113000 on Hera. Please let me > know if you any unexpected/missing changes. > > — > Reply to this email directly, view it on GitHub > <#682 (comment)>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/ACFXXQDC7GIK3HBCB3LARITW7MCVHANCNFSM6AAAAAAWP3PYPQ > . > You are receiving this because you were mentioned.Message ID: > @.***> > -- ------------------------------------------------- Edward Colón Lynker at NOAA/NWS/NCEP/EMC 5830 University Research Ct. Rm #2025 Riverdale, MD 20737 Office: (301) 683-3815 Cell: (301) 213-3566
-- ------------------------------------------------- Edward Colón Lynker at NOAA/NWS/NCEP/EMC 5830 University Research Ct. Rm #2025 Riverdale, MD 20737 Office: (301) 683-3815 Cell: (301) 213-3566

@EdwardColon-NOAA Good suggestion! I am willing to change the baseline of the RT test for RTMA with RRFS-based RTMA data file. Please provide me the sample files.

EricJames-NOAA
EricJames-NOAA approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@EricJames-NOAA EricJames-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as these changes only affect the intended fields, I'm OK with this! Thanks Edward!

@EdwardColon-NOAA
Copy link
Contributor Author

EdwardColon-NOAA commented Apr 3, 2023 via email

@EdwardColon-NOAA
Copy link
Contributor Author

EdwardColon-NOAA commented Apr 4, 2023 via email

@EdwardColon-NOAA
Copy link
Contributor Author

Hi Wen,

The update including the deallocation of arrays seems to have passed the compilation checks but I still received email suggesting that it didn't pass. I checked out the code locally and it compiled on cactus without a problem.

@WenMeng-NOAA
Copy link
Collaborator

Hi Wen,

The update including the deallocation of arrays seems to have passed the compilation checks but I still received email suggesting that it didn't pass. I checked out the code locally and it compiled on cactus without a problem.

@EdwardColon-NOAA That's CI failure on UPP github. I don't see any fortran code errors and would look for help from EIB for CI configuration. Meanwhile you might go to your folk on github, click red error symbol and rerun CI.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RT tests on Hera and Orion. Since the baseline of RTMA will be recreated with this PR, you can skip that test.

@WenMeng-NOAA WenMeng-NOAA added the Baseline Change The baselines of the UPP regression tests are changed. label Apr 6, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

@WenMeng-NOAA UPP RT tests have completed on Hera and Orion without changes to results except RTMA

@WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA UPP RT tests have completed on Hera and Orion without changes to results except RTMA

@FernandoAndrade-NOAA Please approve this PR.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2. A new baseline for 3drtma is needed to be created with this PR. The 3drtma model files will be in RRFS-based format.

@WenMeng-NOAA WenMeng-NOAA merged commit d530f79 into NOAA-EMC:develop Apr 7, 2023
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJames-NOAA EricJames-NOAA EricJames-NOAA approved these changes

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@FernandoAndrade-NOAA FernandoAndrade-NOAA Awaiting requested review from FernandoAndrade-NOAA

Assignees
No one assigned
Labels
3DRTMA Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modified MISCLN.f to address issues in the production of SPC fields using RRFS input
4 participants
@EdwardColon-NOAA @WenMeng-NOAA @FernandoAndrade-NOAA @EricJames-NOAA