Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to output variables at 160 m and 320 m above ground #693

Merged
merged 6 commits into from
Apr 19, 2023

Conversation

EricJames-NOAA
Copy link
Contributor

This PR enables output of TMP, UGRD, VGRD, PRES, and SPFH at 160 m and 320 m above ground level for renewable energy applications (for wind turbines of increasing height). It also includes small changes related to the aerosol extinction due to smoke, dust, and climatological aerosol in RRFS.

The new aerosol extinction variable to be read in, ext550, will be output when the realtime RRFS are upgraded to the authoritative ufs-weather-model.

The code was tested on Jet for the RRFS_CONUS_3km system, with no change in output except the addition of the new levels, and small changes in AOTK and VIS (due to the new extinction variable).

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Can you sync your branch with the UPP develop branch?

@WenMeng-NOAA WenMeng-NOAA linked an issue Apr 17, 2023 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Can you add change logs in the fortran code you modified?

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA Can you add change logs in the fortran code you modified?

@WenMeng-NOAA Sorry about that! I just added them.

@WenMeng-NOAA WenMeng-NOAA added RRFS Ready for Review This PR is ready for code review. labels Apr 17, 2023
@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Do you have sample RRFS model history files including ext550 for my standalone testing?

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA Do you have sample RRFS model history files including ext550 for my standalone testing?

@WenMeng-NOAA I put some sample files here on Hera:

/scratch1/BMC/wrfruc/ejames/wen_ext550

These are 13km CONUS domain...I'm still working on getting a test case for the 3km CONUS domain.

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Do you have sample RRFS model history files including ext550 for my standalone testing?

@WenMeng-NOAA I put some sample files here on Hera:

/scratch1/BMC/wrfruc/ejames/wen_ext550

These are 13km CONUS domain...I'm still working on getting a test case for the 3km CONUS domain.

@EricJames-NOAA Could you copy them into Hera? My working computer has an issue to access Jet today. Thanks!

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA Do you have sample RRFS model history files including ext550 for my standalone testing?

@WenMeng-NOAA I put some sample files here on Hera:
/scratch1/BMC/wrfruc/ejames/wen_ext550
These are 13km CONUS domain...I'm still working on getting a test case for the 3km CONUS domain.

@EricJames-NOAA Could you copy them into Hera? My working computer has an issue to access Jet today. Thanks!

Do you mean you need them on Jet? I have some sample files here:

lfs4/BMC/wrfruc/ejames/RRFS/stmp/tmpnwprd/RRFS_conus_3km/2021051216/fcst_fv3lam

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Sorry, I thought the data location you provided from jet. Now I got it. Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA I conducted UPP testing with model data from /scratch1/BMC/wrfruc/ejames/wen_ext550.
My test results are at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2021051216-after on Hera.
I saw the following expected changes:

1) additional 10 fields(T,U/V,P,SPFH) added in dataset PRSLEV.
2) VIS change as: 1237:59345473:VIS:surface:rpn_corr=0.993778:rpn_rms=2658.85

Please let me know if you any issues from my test. Thanks!

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA I conducted UPP testing with model data from /scratch1/BMC/wrfruc/ejames/wen_ext550. My test results are at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2021051216-after on Hera. I saw the following expected changes:

1) additional 10 fields(T,U/V,P,SPFH) added in dataset PRSLEV.
2) VIS change as: 1237:59345473:VIS:surface:rpn_corr=0.993778:rpn_rms=2658.85

Please let me know if you any issues from my test. Thanks!

@WenMeng-NOAA your results look good to me! Thank you!

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You might start the UPP RT tests on Hera and Orion. Thanks!

@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2. The file size of dataset PRSLEV in 3drtma test has a change but field by field value comparison is fine. The baseline of 3drtma is needed to be recreated with this PR.

@FernandoAndrade-NOAA
Copy link
Collaborator

UPP RT tests have finished on Hera and Orion. All tests passed with the exception of the following changes in PRSLEV for 3drtma :

39:38622976:REFZR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
40:38861307:REFZI:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
49:49740509:PBLREG:surface:rpn_corr=-nan:rpn_rms=undefined
703:635158661:REFZR:4000 m above ground:rpn_corr=-nan:rpn_rms=undefined
704:635396992:REFZI:4000 m above ground:rpn_corr=-nan:rpn_rms=undefined
706:636307658:REFZR:1000 m above ground:rpn_corr=-nan:rpn_rms=undefined
707:636545989:REFZI:1000 m above ground:rpn_corr=-nan:rpn_rms=undefined
763:706867267:POT:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
764:707105598:SPFH:10 m above ground:rpn_corr=-nan:rpn_rms=undefined

@WenMeng-NOAA
Copy link
Collaborator

UPP RT tests have finished on Hera and Orion. All tests passed with the exception of the following changes in PRSLEV for 3drtma :

39:38622976:REFZR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
40:38861307:REFZI:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
49:49740509:PBLREG:surface:rpn_corr=-nan:rpn_rms=undefined
703:635158661:REFZR:4000 m above ground:rpn_corr=-nan:rpn_rms=undefined
704:635396992:REFZI:4000 m above ground:rpn_corr=-nan:rpn_rms=undefined
706:636307658:REFZR:1000 m above ground:rpn_corr=-nan:rpn_rms=undefined
707:636545989:REFZI:1000 m above ground:rpn_corr=-nan:rpn_rms=undefined
763:706867267:POT:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
764:707105598:SPFH:10 m above ground:rpn_corr=-nan:rpn_rms=undefined

@FernandoAndrade-NOAA Your tests on Hera and Orion are consistent with my test on WCOSS2. These discrepancies from rtma are from grib2 meta data changes. It would be fine for no change from field by field comparison.

@WenMeng-NOAA WenMeng-NOAA added Baseline Change The baselines of the UPP regression tests are changed. 3DRTMA labels Apr 19, 2023
@WenMeng-NOAA
Copy link
Collaborator

@EdwardColon-NOAA This PR would have impact on 3DRTMA since RRFS and 3DRTMA share the same UPP control file. Please let me if you have any suggestions/concerns.

@EdwardColon-NOAA
Copy link
Contributor

Hi Wen,

The changes listed do not impact the 3D-RTMA development effort at the moment. The PR should be fine from the 3D-RTMA perspective.

-Edward

@WenMeng-NOAA
Copy link
Collaborator

Hi Wen,

The changes listed do not impact the 3D-RTMA development effort at the moment. The PR should be fine from the 3D-RTMA perspective.

-Edward

Thanks for confirming. @EdwardColon-NOAA

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA Please approve this PR.

@WenMeng-NOAA WenMeng-NOAA merged commit a94c164 into NOAA-EMC:develop Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3DRTMA Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable output of 160m and 320m wind from RRFS for renewable energy
4 participants