Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thompson subcycling for develop, remove legacy print statements from io/FV3GFS_io.F90 #328

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jun 9, 2021

Note

This PR replaces #316. It contains exactly the same changes, but as new commits due to the "UFS code commit process" tutorial held June 9/10, 2021. For discussion and approval of the original code changes, see #316.

Description

This PR does the following:

  • Set number of subcycles for Thompson MP to 4/2 in suites FV3_GSD_noah and FV3_GFS_v16_thompson

This PR also contains the changes in #324 (remove legacy print statements from io/FV3GFS_io.F90).

Issue(s) addressed

Fixes #226

Testing

See ufs-community/ufs-weather-model#632

Dependencies

NCAR/ccpp-framework#379
NCAR/ccpp-physics#676
#328
ufs-community/ufs-weather-model#632

@climbfuji climbfuji changed the title Thompson subcycling for develop Thompson subcycling for develop, remove legacy print statements from io/FV3GFS_io.F90 Jun 9, 2021
@climbfuji climbfuji requested a review from ShanSunNOAA June 9, 2021 20:45
Copy link
Collaborator

@ShanSunNOAA ShanSunNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I approve. Thanks, -Shan

@junwang-noaa junwang-noaa merged commit 6a1e4f2 into NOAA-EMC:develop Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup of FV3GFS_io.F90
4 participants