-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thompson subcycling for develop, remove legacy print statements from io/FV3GFS_io.F90 #328
Merged
junwang-noaa
merged 8 commits into
NOAA-EMC:develop
from
climbfuji:thompson_subcycling_v2_tutorial
Jun 10, 2021
Merged
Thompson subcycling for develop, remove legacy print statements from io/FV3GFS_io.F90 #328
junwang-noaa
merged 8 commits into
NOAA-EMC:develop
from
climbfuji:thompson_subcycling_v2_tutorial
Jun 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-physics for code review and testing
… and FV3_GFS_v16_thompson
…fuji/fv3atm into thompson_subcycling_v2_tutorial
climbfuji
changed the title
Thompson subcycling for develop
Thompson subcycling for develop, remove legacy print statements from io/FV3GFS_io.F90
Jun 9, 2021
…mpson_subcycling_v2_tutorial
junwang-noaa
approved these changes
Jun 9, 2021
ShanSunNOAA
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I approve. Thanks, -Shan
This was referenced Jun 9, 2021
DusanJovic-NOAA
approved these changes
Jun 9, 2021
This was referenced Jun 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR replaces #316. It contains exactly the same changes, but as new commits due to the "UFS code commit process" tutorial held June 9/10, 2021. For discussion and approval of the original code changes, see #316.
Description
This PR does the following:
This PR also contains the changes in #324 (remove legacy print statements from io/FV3GFS_io.F90).
Issue(s) addressed
Fixes #226
Testing
See ufs-community/ufs-weather-model#632
Dependencies
NCAR/ccpp-framework#379
NCAR/ccpp-physics#676
#328
ufs-community/ufs-weather-model#632