Add support for scheme subcycling #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d buffer writing subcycle block to auto-generated caps
This was referenced Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR replaces #376. It contains exactly the same changes, but as new commits due to the "UFS code commit process" tutorial held June 9/10, 2021. For discussion and approval of the original code changes, see #376.
Description
Add necessary logic to pass number of subcycles to schemes in form of a variable with CCPP standard name. This is done in exactly the same way as for the existing current iteration.
The new logic requires to buffer the calls to the schemes in a subcycle body loop and prepend/append the loop control as needed before adding it to the cap.
Testing
See ufs-community/ufs-weather-model#632
Dependencies
#379
NCAR/ccpp-physics#676
NOAA-EMC/fv3atm#328
ufs-community/ufs-weather-model#632