Add support for scheme subcycling #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a variable with CCPP standard name
This was referenced May 24, 2021
…ompson_subcycling_for_main
This was referenced Jun 9, 2021
|
This PR was replaced with an identical PR #379 as part of the "UFS code commit process tutorial". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add necessary logic to pass number of subcycles to schemes in form of a variable with CCPP standard name. This is done in exactly the same way as for the existing current iteration.
The new logic requires to buffer the calls to the schemes in a subcycle body loop and prepend/append the loop control as needed before adding it to the cap.
Testing
See ufs-community/ufs-weather-model#595
Dependencies
NCAR/ccpp-physics#666
#376
NOAA-EMC/fv3atm#316
ufs-community/ufs-weather-model#595