Add support for external land component #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
grantfirl
reviewed
Oct 12, 2022
grantfirl
reviewed
Oct 12, 2022
DusanJovic-NOAA
approved these changes
Oct 28, 2022
|
CCPP-Physics is merged: ufs-community/ccpp-physics@8c88f68 Please revert .gitmodules and update hash. |
|
@BrianCurtis-NOAA It is done |
BrianCurtis-NOAA
approved these changes
Oct 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add support for external land component. The PR introduces new
input.nmloption ascpllndto make required data structures available (even if the case for settingcplflx = .false.) and coupling interface. There is no expected answer change.Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? The RTs provided by UFS Weather model were run.
What compilers / HPCs was it tested with? It is tested with both Intel and GNU compilers on NCAR's Cheyenne platform
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes. Three new regression tests are added.
datm_cdeps_lnd_gswp3: 1 day run with CDEPS GSWP3 datasetdatm_cdeps_lnd_gswp3_rst: restart run with CDEPS GSWP3 datasetcontrol_p8_atmlnd_sbs: side-by-side test with active atmosphere, uses same configuration withcontrol_p8and the interaction with FV3 is uni-directional to allow comparing the results coming from FV3/CCPP/NOAHMP with external NOAHMP component.Have the ufs-weather-model regression test been run? On what platform? Yes. Cheyyene
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
There is not answer change but there is an issue with the input files of
control_p8which is explained in here in a detailed way.Please commit the regression test log files in your ufs-weather-model branch
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs