Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring external land model support #10

Merged

Conversation

uturuncoglu
Copy link
Collaborator

This PR aims to bring support for external land component (i.e. Noah MP). At this point, the interaction between atmosphere and ccpp/physics is unidirectional and ccpp/physics does not receive any information from external land component and only allow sending required fields to land component. The two way interaction, will be implemented in the later stage of the JTTI project.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues from a CCPP point of view.

Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@jkbk2004
Copy link

Tests are done with ufs-wm PR 1443. @ChunxiZhang-NOAA can you merge in this PR?

@ChunxiZhang-NOAA ChunxiZhang-NOAA merged commit 8c88f68 into ufs-community:ufs/dev Oct 28, 2022
@ChunxiZhang-NOAA
Copy link

Tests are done with ufs-wm PR 1443. @ChunxiZhang-NOAA can you merge in this PR?

@jkbk2004 Done.

@uturuncoglu uturuncoglu deleted the feature/lnd_noahmp_new branch November 11, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants