Bug fixes for 32-bit physics & correct the lake scheme in FV3_HRRR_c3 & FV3_HRRR_gf #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in quilt server
SamuelTrahanNOAA
changed the title
34 tasks
|
@tanyasmirnova should review this |
|
@junwang-noaa Can you review this pr? GSL team has urgency for their real-time experiment. |
junwang-noaa
approved these changes
Aug 24, 2023
tanyasmirnova
approved these changes
Aug 25, 2023
|
@BrianCurtis-NOAA @DeniseWorthen we need one more approving review on this PR. |
BrianCurtis-NOAA
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects a few problems found in RRFS parallel development:
The first two fixes were from @SamuelTrahanNOAA and the last one is from @DusanJovic-NOAA
Issue(s) addressed
Testing
How were these changes tested?
This is from a larger effort to get the 32-bit physics working with quilting restart. Unfortunately, we're not 100% successful yet. However, these fixes are urgently needed by the RRFS parallels, so you'll get the rest later.
What compilers / HPCs was it tested with?
Hera intel & gnu
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes. All 28 of the 13km conus tests are replaced with 16 new ones. There are new FV3_HRRR_gf and _c3 C96 regression tests.
Have the ufs-weather-model regression test been run? On what platform?
Yes. Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
28 tests are removed, 20 tests added; see ufs-weather-model PR
Please commit the regression test log files in your ufs-weather-model branch
Will do.
Dependencies
None.