Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests #806

Merged
merged 11 commits into from
Apr 14, 2024
Merged

bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests #806

merged 11 commits into from
Apr 14, 2024

Conversation

SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Mar 21, 2024 •
edited
Loading

Description

Fixes these bugs:

  1. Fix from @DusanJovic-NOAA wherein the kchunk3d setting in model_configure was ignored. This caused an abort due to a negative index in an MPI call on some platforms. This my have been due to a 32-bit integer wraparound, but we cannot confirm that.
  2. A hailwat variable was uninitialized in the dynamical core. Now it is set to the hailwat tracer index.
  3. The tile_num sent to CCPP was wrong for the nest because it was the index of the tile in the mosaic (index 1) instead of the "global tile number" (index 7). This is corrected by having the dynamical core pass the "global tile number" up to the model.

No answers should change.

Issue(s) addressed

Testing

How were these changes tested?

  1. Running the test case that failed. It's a rotated cube sphere with a large static nest, using GFS physics
  2. Several other people ran failing C768 regression tests that were affected by the kchunk3d bug.
  3. Regression tests on Hera

What compilers / HPCs was it tested with?

  • Test cases on Hera Rocky
  • Regression tests on Hera Rocky

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)

The test cases are too large for a regression test.

Have the ufs-weather-model regression test been run? On what platform?

Hera CentOS.

Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.

No.

Please commit the regression test log files in your ufs-weather-model branch

Done.

Dependencies

@SamuelTrahanNOAA
nesting fixes
d87527e 
1. Initialize hailwat index in dynamical core.
2. Use the correct tile number for nests in atmos_model.F90.
@SamuelTrahanNOAA
update to head of develop
956b0a6
@SamuelTrahanNOAA SamuelTrahanNOAA mentioned this pull request Mar 21, 2024
Merged
14 tasks
@SamuelTrahanNOAA SamuelTrahanNOAA changed the title nesting bug fixes for uninitialized variable in fv3 and incorrect tile number in fv3atm bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests Apr 11, 2024
@SamuelTrahanNOAA
Copy link
Contributor Author

I've reverted .gitmodules changes and point to the head of atmos_cubed_sphere

This branch is ready for final review and merge.

@zach1221
Copy link
Collaborator

@jkbk2004 cubed-sphere PR is merged. Hash: NOAA-GFDL/GFDL_atmos_cubed_sphere@0301022

@SamuelTrahanNOAA
Copy link
Contributor Author

I already updated the atmos_cubed_sphere hash and reverted .gitmodules.

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit 37e7d48 into NOAA-EMC:develop Apr 14, 2024
0 of 2 checks passed
zhanglikate added a commit to zhanglikate/fv3atm that referenced this pull request May 3, 2024
@zhanglikate
Squashed commit of the following:
9e250eb 
commit da95cc4
Author: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>
Date:   Fri Apr 19 12:36:43 2024 -0400

    Update upp submodule (NOAA-EMC#811)

    * Update github workflow. Update gcc to 12 and mpi to openmpi

    * Add 'spack clean' to reduce the size of the cache files

    * Split GCC.yml workflow into two jobs, build_spack and build_fv3atm

    * Update github workflow. Add mpich

    * Update github actions to v4

    * Use action/cache/restore in build_fv3atm job

    * update upp revision to 5faac75

    * Update GCC.yml

    ---------

    Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>

commit 979bcab
Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Date:   Wed Apr 17 13:42:06 2024 -0400

    Update dycore to remove compiler warnings (NOAA-EMC#813)

    * Update atmos_cubed_sphere and add compile definition BYPASS_BREED_SLP_INLINE to dycore

    * Pass correct mpi communicator type to post_alctvars routine in inline post

commit 37e7d48
Author: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
Date:   Sun Apr 14 13:00:07 2024 -0400

    bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests (NOAA-EMC#806)

    * nesting fixes
    1. Initialize hailwat index in dynamical core.
    2. Use the correct tile number for nests in atmos_model.F90.

    * remove unneeded write statements

    * Fix kchunk3d in io/module_write_netcdf.F90

    ---------

    Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>

commit 383687e
Author: JONG KIM <jong.kim@noaa.gov>
Date:   Thu Apr 4 16:34:52 2024 -0400

    cubed_sphere hash fix to f060e85 (NOAA-EMC#817)

    * Update cubed_sphere@f060e85 hash: a bug fix in the HAILCAST diagnostic code (units issue)

commit 1cac9d3
Author: Denise Worthen <denise.worthen@noaa.gov>
Date:   Wed Apr 3 16:48:31 2024 -0400

    Enable cpl_scalars (NOAA-EMC#794)

    * add cpl_scalars for atm

    * add field cpl_scalars to export state of fv3atm when coupled.
    cpl_scalars contain the dimensions of the fv3atm domain and are
    used by cmeps to write mediator history files as a single 2d
    grid for regional and 6 2d grids for CSG.

    * remove unused NUOPC use statement

commit 1b75fe2
Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Date:   Mon Apr 1 17:12:08 2024 -0400

    Update module_write_netcdf to avoid hangs in RRFS runs (NOAA-EMC#803)

    * Split add_dim into two routines

    * Add NF90_NODIMSCALE_ATTACH constant

    * Test classic netcdf file formats

commit 1ba8410
Author: lisa-bengtsson <54411948+lisa-bengtsson@users.noreply.github.com>
Date:   Wed Mar 27 12:12:00 2024 -0600

    Introduce namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite. (NOAA-EMC#799)

    * Update ccpp/physics for namelist flag xr_cnvcld
@grantfirl grantfirl mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model sends wrong tile_num to CCPP for nests
4 participants
@SamuelTrahanNOAA @zach1221 @DusanJovic-NOAA @BrianCurtis-NOAA