-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nesting bug fixes for uninitialized variable in fv3 and incorrect tile number in fv3atm #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensonr
approved these changes
Mar 21, 2024
DusanJovic-NOAA
approved these changes
Mar 21, 2024
junwang-noaa
approved these changes
Mar 21, 2024
14 tasks
XiaqiongZhou-NOAA
approved these changes
Mar 21, 2024
@bensonr testing is complete on UFS-WM PR #2201. Can you please merge this PR for us? |
Can you confirm this has the top of the dev/emc trunk merged in? Tagging @jkbk2004 @junwang-noaa @DusanJovic-NOAA to be sure. |
The "git merge" command thinks it is up to date:
|
@bensonr https://github.com/ufs-community/ufs-weather-model/actions/runs/8666708764/job/23768118824. All good to merge this pr. |
zhanglikate
added a commit
to zhanglikate/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 30, 2024
commit 9711488 Author: Rusty Benson <6594772+bensonr@users.noreply.github.com> Date: Wed Apr 17 08:41:41 2024 -0400 Address compiler warnings for FV3 raised in an issue (NOAA-GFDL#324) * give istatus a value on exit from hailcast_init * fix issues with declared out variables in test_cases.F90 * fix out of range default integers, eol spaces, and remove delz argument from set_regional_BCs in fv_regional_bc.F90 * removed -nowarn from Intel compiler flags * added suggested ifdef to remove goto warning as per operations commit 0301022 Author: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com> Date: Fri Apr 12 20:02:26 2024 -0400 nesting bug fixes for uninitialized variable in fv3 and incorrect tile number in fv3atm (NOAA-GFDL#331) * pass global tile up to model * bug fix: initialize hailwat variable commit f060e85 Author: Jaymes Kenyon <jaymes.kenyon@noaa.gov> Date: Fri Mar 1 22:23:31 2024 -0500 Correct a bug in the HAILCAST diagnostic code (units issue) (NOAA-GFDL#320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #328 by initializing the hailwat variable to the hailwat tracer index.
It fixes #329 by allowing the caller to request either the global_tile or tile_in_mosaic.
How Has This Been Tested?
The Hera Rocky tests await bug fixes to the regression tests which should be available this week.
Checklist:
Please check all whether they apply or not