Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nesting bug fixes for uninitialized variable in fv3 and incorrect tile number in fv3atm #331

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

SamuelTrahanNOAA
Copy link

Description

This fixes #328 by initializing the hailwat variable to the hailwat tracer index.
It fixes #329 by allowing the caller to request either the global_tile or tile_in_mosaic.

How Has This Been Tested?

  1. Running the test case that failed. It's a rotated cube sphere with a large static nest, using GFS physics
  2. Running regression tests on Hera CentOS

The Hera Rocky tests await bug fixes to the regression tests which should be available this week.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@zach1221
Copy link

@bensonr testing is complete on UFS-WM PR #2201. Can you please merge this PR for us?

@bensonr
Copy link
Contributor

bensonr commented Apr 12, 2024

Can you confirm this has the top of the dev/emc trunk merged in? Tagging @jkbk2004 @junwang-noaa @DusanJovic-NOAA to be sure.

@SamuelTrahanNOAA
Copy link
Author

The "git merge" command thinks it is up to date:

[ =129 19:15:22 100671 Samuel.Trahan@hfe10 ]
.../Samuel.Trahan/westwater/nesting-fixes/FV3/atmos_cubed_sphere> git fetch --all
Fetching sam
Fetching upstream
remote: Enumerating objects: 498, done.
remote: Counting objects: 100% (379/379), done.
remote: Compressing objects: 100% (170/170), done.
remote: Total 498 (delta 257), reused 258 (delta 203), pack-reused 119
Receiving objects: 100% (498/498), 4.11 MiB | 22.77 MiB/s, done.
Resolving deltas: 100% (292/292), completed with 53 local objects.
From https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere
 * [new branch]      autotools.build       -> upstream/autotools.build
 * [new branch]      dev/emc               -> upstream/dev/emc
 * [new branch]      dev/gfdl              -> upstream/dev/gfdl
 * [new branch]      dev/gfdl_am5          -> upstream/dev/gfdl_am5
 * [new branch]      dev/gfdl_am5_test     -> upstream/dev/gfdl_am5_test
 * [new branch]      main                  -> upstream/main
 * [new branch]      ufs-release/public-v1 -> upstream/ufs-release/public-v1
 * [new branch]      ufs-release/public-v2 -> upstream/ufs-release/public-v2
 * [new tag]         2023.03_am5           -> 2023.03_am5
 * [new tag]         ufs-srw-v2.0.0        -> ufs-srw-v2.0.0
 * [new tag]         2022.03               -> 2022.03
 * [new tag]         2022.04               -> 2022.04
 * [new tag]         2023.01               -> 2023.01
 * [new tag]         2023.01_am5           -> 2023.01_am5
 * [new tag]         2023.02               -> 2023.02
 * [new tag]         2023.02-alpha1        -> 2023.02-alpha1
 * [new tag]         2023.02_am5           -> 2023.02_am5
 * [new tag]         2023.03               -> 2023.03
 * [new tag]         2023.03-beta1         -> 2023.03-beta1
 * [new tag]         2023.03-beta1_am5     -> 2023.03-beta1_am5
 * [new tag]         FV3-202210-public     -> FV3-202210-public
 * [new tag]         FV3-202305-public     -> FV3-202305-public
[ =0 19:15:29 100672 Samuel.Trahan@hfe10 ]
.../Samuel.Trahan/westwater/nesting-fixes/FV3/atmos_cubed_sphere> git merge upstream/dev/emc
Already up to date.
[ =0 19:15:46 100673 Samuel.Trahan@hfe10 ]
.../Samuel.Trahan/westwater/nesting-fixes/FV3/atmos_cubed_sphere> git remote get-url upstream
https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere

@jkbk2004
Copy link

@bensonr bensonr merged commit 0301022 into NOAA-GFDL:dev/emc Apr 13, 2024
zhanglikate added a commit to zhanglikate/GFDL_atmos_cubed_sphere that referenced this pull request Apr 30, 2024
commit 9711488
Author: Rusty Benson <6594772+bensonr@users.noreply.github.com>
Date:   Wed Apr 17 08:41:41 2024 -0400

    Address compiler warnings for FV3 raised in an issue (NOAA-GFDL#324)

    * give istatus a value on exit from hailcast_init

    * fix issues with declared out variables in test_cases.F90

    * fix out of range default integers, eol spaces, and remove delz argument from set_regional_BCs in fv_regional_bc.F90

    * removed -nowarn from Intel compiler flags

    * added suggested ifdef to remove goto warning as per operations

commit 0301022
Author: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
Date:   Fri Apr 12 20:02:26 2024 -0400

    nesting bug fixes for uninitialized variable in fv3 and incorrect tile number in fv3atm (NOAA-GFDL#331)

    * pass global tile up to model

    * bug fix: initialize hailwat variable

commit f060e85
Author: Jaymes Kenyon <jaymes.kenyon@noaa.gov>
Date:   Fri Mar 1 22:23:31 2024 -0500

    Correct a bug in the HAILCAST diagnostic code (units issue) (NOAA-GFDL#320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants