Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new data sources used in GFS v16.3.12 #2283

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Add new data sources used in GFS v16.3.12 #2283

merged 7 commits into from
Apr 5, 2024

Conversation

ADCollard
Copy link
Contributor

Changes to scripts/exglobal_atmos_analysis.sh to include new data that are being operationally assimilated in GFS v16.3.12.

**Note that this requires CRTM v2.4.0.1 **

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@ADCollard ADCollard self-assigned this Feb 1, 2024
RussTreadon-NOAA
RussTreadon-NOAA reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since hirs dump files are not included in the list of bufr dump files to link, we don't need to comment out B1HRS2, B1HRS3, and B1HRS4. Even if the dump files exist, they are not copied or linked to the run directory. The same comment applies to ESHRS3 and HRS3DB.

Given this, should we simply remove the variables pointing at hirs dump files instead of commenting out the line? Either approach is OK. Just asking.

The other change in exglobal_atmos_analysis.sh is to add abi_g18, atms_n21, and cris-fsr_n21 are added OBS_INPUT. This is correct.

@ADCollard
Copy link
Contributor Author

@RussTreadon-NOAA I am hoping that the removal of HIRS is a temporary measure (as I think there is still a need in reanalysis) and it can be re-instated once a revised version of CRTM is installed. So I was leaving it here as a reminder.

But I'd also be happy to remove it completely.

@RussTreadon-NOAA RussTreadon-NOAA self-requested a review February 1, 2024 23:19
RussTreadon-NOAA
RussTreadon-NOAA approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with what you have.

Approve.

HaixiaLiu-NOAA
HaixiaLiu-NOAA approved these changes Feb 2, 2024
View reviewed changes
Copy link

@HaixiaLiu-NOAA HaixiaLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me. Approving now.

@ADCollard ADCollard mentioned this pull request Feb 5, 2024
Closed
9 tasks
@ADCollard ADCollard marked this pull request as draft February 5, 2024 20:25
KateFriedman-NOAA
KateFriedman-NOAA reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks to cover half of the checklist items in issue #1918. Will the following remaining checklist items be added to this PR when it comes out of draft mode?

  • Update GSI hash to one that uses new CRTM version
  • Update ufs-weather-model hash to one that uses new CRTM version
  • Update UPP hash to one that uses new CRTM version
  • Uncomment GMI line scripts/exglobal_atmos_analysis.sh (commented out in GFSv16.3.5[6] GSI updates #1404).

@ADCollard
Copy link
Contributor Author

@KateFriedman-NOAA

I am working on the first three. The GMI change will not go in until the obsproc v1.2 upgrade that will fix erroneous GMI dumps.

@KateFriedman-NOAA
Copy link
Member

@ADCollard Great! I will open a separate g-w issue to update to obsproc.v1.2 and make the GMI change in the future.

@ADCollard
Copy link
Contributor Author

After merging develop into this fork, I ran a c96 test case on Hera for a full cycle without incident.

ufs appears to compile with /scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.5.1/envs/unified-env-rocky8/install/intel/2021.5.0/crtm-2.4.0-alizlgl but runs with crtm-fix/2.4.0.1_emc loaded. Apparently without incident.

@ADCollard ADCollard marked this pull request as ready for review April 4, 2024 12:10
@KateFriedman-NOAA KateFriedman-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Apr 5, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Apr 5, 2024
@emcbot emcbot added CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Apr 5, 2024
@emcbot
Copy link

emcbot commented Apr 5, 2024

CI SUCCESS Orion at 04 05 15:37:44

Built and ran in directory /work2/noaa/stmp/CI/ORION/2283

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Apr 5, 2024
@emcbot
Copy link

emcbot commented Apr 5, 2024

CI SUCCESS Hera at 04 05 17:24:12

Built and ran in directory /scratch1/NCEPDEV/global/CI/2283

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 4f0f773 into NOAA-EMC:develop Apr 5, 2024
9 checks passed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 8, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
c3d43b9 
* upstream/develop:
  Flip the build for GFS and GEFS with waves (NOAA-EMC#2462)
  Add new data sources used in GFS v16.3.12 (NOAA-EMC#2283)
  The soca fix path is needed in config.prepoceanobs (NOAA-EMC#2460)
  Turn off reducedgrid in the EnKF (NOAA-EMC#2456)
  Rename generate_com to declare_from_tmpl (NOAA-EMC#2453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA left review comments

@HaixiaLiu-NOAA HaixiaLiu-NOAA HaixiaLiu-NOAA approved these changes

@emilyhcliu emilyhcliu emilyhcliu approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

Assignees

@ADCollard ADCollard

Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ADCollard @KateFriedman-NOAA @emcbot @RussTreadon-NOAA @WalterKolczynski-NOAA @emilyhcliu @HaixiaLiu-NOAA