Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off reducedgrid in the EnKF #2456

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Turn off reducedgrid in the EnKF #2456

merged 1 commit into from
Apr 4, 2024

Conversation

CatherineThomas-NOAA
Copy link
Contributor

Description

The reducedgrid feature no longer results in reduced runtime for the current EnKF configuration. This feature also cannot be used in soil DA due to masked fields. It will be set to .false. by default.

Resolves #2455

Type of change

  • Removing feature

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Run on WCOSS2

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@CatherineThomas-NOAA
Turn off reducedgrid in the EnKF
3972a4a 
The reducedgrid feature no longer results in
reduced runtime for the current EnKF configuration.
This feature also cannot be used in soil DA due to
masked fields. It will be set to .false. by
default.

Resolves NOAA-EMC#2455
aerorahul
aerorahul approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@aerorahul aerorahul added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Apr 4, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Apr 4, 2024
@emcbot
Copy link

emcbot commented Apr 4, 2024

CI FAILED Hera at 04 04 13:34:05
Built and ran in directory /scratch1/NCEPDEV/global/CI/2456

@emcbot emcbot added the CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed label Apr 4, 2024
@TerrenceMcGuinness-NOAA
Copy link
Collaborator

TerrenceMcGuinness-NOAA commented Apr 4, 2024 •
edited
Loading

This was a false negative because the Jenkins Runtime Environment established by gwsetup.sh by the Java Agent for CI scripts and tools was out-of-date. Build step has been configured to skip on a second pass because it previously passed. Restarting CI run of the PR with the update Run-Time Environment.

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Apr 4, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Apr 4, 2024
@emcbot
Copy link

emcbot commented Apr 4, 2024

CI SUCCESS Hera at 04 04 19:12:51

Built and ran in directory /scratch1/NCEPDEV/global/CI/2456

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 90502b3 into NOAA-EMC:develop Apr 4, 2024
9 checks passed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 8, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
c3d43b9 
* upstream/develop:
  Flip the build for GFS and GEFS with waves (NOAA-EMC#2462)
  Add new data sources used in GFS v16.3.12 (NOAA-EMC#2283)
  The soca fix path is needed in config.prepoceanobs (NOAA-EMC#2460)
  Turn off reducedgrid in the EnKF (NOAA-EMC#2456)
  Rename generate_com to declare_from_tmpl (NOAA-EMC#2453)
@CatherineThomas-NOAA CatherineThomas-NOAA deleted the feature/reduced branch April 18, 2024 16:37
@weihuang-jedi weihuang-jedi mentioned this pull request Oct 10, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn off reducedgrid in the EnKF
5 participants
@CatherineThomas-NOAA @emcbot @TerrenceMcGuinness-NOAA @aerorahul @WalterKolczynski-NOAA