Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support global-workflow using Rocky 8 on CSPs #2998

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Support global-workflow using Rocky 8 on CSPs #2998

wants to merge 3 commits into from
+37 −24

Conversation

weihuang-jedi
Copy link
Contributor

Description

With ParallelWorks now default Rocky 8 on CSPs, and move to Rocky 8 only after 1/1/2025,
we need to modify global-workflow module files to use Rocky 8 supported spack-stack,
and test compile and run to make sure all works under Rocky 8.

Resolves #2997

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

How has this been tested?

  • Clone and build on CSPs
  • Forecast-only on AWS
  • GEFS test on AWS

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 10, 2024
View reviewed changes
env/AZUREPW.env
@@ -50,6 +50,10 @@
export wavempexec=${launcher}
export wave_mpmd=${mpmd_opt}

elif [[ "${step}" = "prep_emissions" ]]; then

export APRUN = ${APRUN_default}

Check failure

Code scanning / shellcheck

Remove spaces around = to assign. Error

Remove spaces around = to assign.
env/AZUREPW.env
@@ -50,6 +50,10 @@
export wavempexec=${launcher}
export wave_mpmd=${mpmd_opt}

elif [[ "${step}" = "prep_emissions" ]]; then

export APRUN = ${APRUN_default}

Check warning

Code scanning / shellcheck

This does not export 'APRUN_default'. Remove $/${} for that, or use ${var?} to quiet. Warning

This does not export 'APRUN_default'. Remove $/${} for that, or use ${var?} to quiet.
env/AZUREPW.env
@@ -50,6 +50,10 @@
export wavempexec=${launcher}
export wave_mpmd=${mpmd_opt}

elif [[ "${step}" = "prep_emissions" ]]; then

export APRUN = ${APRUN_default}

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
env/GOOGLEPW.env
@@ -45,7 +45,7 @@

elif [[ "${step}" = "prep_emissions" ]]; then

export APRUN
export APRUN = ${APRUN_default}

Check failure

Code scanning / shellcheck

Remove spaces around = to assign. Error

Remove spaces around = to assign.
env/GOOGLEPW.env
@@ -45,7 +45,7 @@

elif [[ "${step}" = "prep_emissions" ]]; then

export APRUN
export APRUN = ${APRUN_default}

Check warning

Code scanning / shellcheck

This does not export 'APRUN_default'. Remove $/${} for that, or use ${var?} to quiet. Warning

This does not export 'APRUN_default'. Remove $/${} for that, or use ${var?} to quiet.
env/GOOGLEPW.env
@@ -45,7 +45,7 @@

elif [[ "${step}" = "prep_emissions" ]]; then

export APRUN
export APRUN = ${APRUN_default}

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support global-workflow on CSPs with Rocky 8
1 participant
@weihuang-jedi