metatasks enkfgdas_fcst and enkfgdas_epmn no longer created for C96C48_ufs_hybatmDA

[RussTreadon-NOAA]

What is wrong?

Attempts to run g-w CI for case C96C48_ufs_hybatmDA fail following the merger of g-w PR #3185 into develop.

rocotorun -d C96C48_ufs_hybatmDA.db -w C96C48_ufs_hybatmDA.xml fails with

12/26/24 15:25:54 UTC :: C96C48_ufs_hybatmDA_test.xml :: Error: Extra element dependency in interleave.
12/26/24 15:25:54 UTC :: C96C48_ufs_hybatmDA_test.xml :: Error: Element task failed to validate content at C96C48_ufs_hybatmDA_test.xml:93.
12/26/24 15:25:54 UTC :: C96C48_ufs_hybatmDA_test.xml :: Error: Extra element task in interleave.
12/26/24 15:25:54 UTC :: C96C48_ufs_hybatmDA_test.xml :: Error: Element workflow failed to validate content at C96C48_ufs_hybatmDA_test.xml:17.
12/26/24 15:25:54 UTC :: C96C48_ufs_hybatmDA_test.xml :: Error: Element workflow failed to validate content at C96C48_ufs_hybatmDA_test.xml:17.

Line 93 is the block defining task gdas_atmanlinit. This task depends on metatask enkfgdas_epmn.

Metatask enkfgdas_epmn is not defined in the xml. Upon closer inspection, metatask enkfgdas_fcst is also not defined in the xml ... even though it is listed as a dependency for enkfgdas_echgres

What should have happened?

We should be able to run g-w CI case C96C48_ufs_hybatmDA

What machines are impacted?

All or N/A

What global-workflow hash are you using?

g-w develop at 1c37f90

Steps to reproduce

1. clone and install g-w develop
2. set up g-w CI for C96C48_ufs_hybatmDA
3. cd to C96C48_ufs_hybatmDA EXPDIR
4. rocotorun -d C96C48_ufs_hybatmDA.db -w C96C48_ufs_hybatmDA.xml

The rocotorun command will fail. This is wrong. The rocotorun command should not fail.

Additional information

As a test install g-w develop at bdc0e29. This is the commit prior to PR #3185.

Set up g-w CI for C96C48_ufs_hybatmDA using the $HOMEgfs for the bdc0e29 install. The resulting C96C48_ufs_hybatmDA.xml defines metatasks enkfgdas_fcst and enkfgdas_epmn. rocotorun -d C96C48_ufs_hybatmDA.db -w C96C48_ufs_hybatmDA.xml runs without error. This is correct.

Do you have a proposed solution?

Please carefully check bdc0e29 for an error when UFS DA is active. This is a blocker issue. We can not cycle UFS ATM DA using g-w develop at 1c37f90.

A check of g-w PR #3185 does not show C96C48_ufs_hybatmDA as being run. This case is skipped on gaea, orion, hercules, and wcoss2. PR #3185 ran g-w CI on hercules. Thus, this error slipped through the cracks.

[RussTreadon-NOAA]

FYI: @DavidNew-NOAA

As of g-w develop at 1c37f90, g-w CI for C96C48_ufs_hybatmDA does not work. The xml file created by g-w does not define metatasks enkgdas_fcst and enkfgdas_epmn. Both tasks are listed at dependencies for other jobs in the xml.

[RussTreadon-NOAA]

@TravisElless-NOAA - g-w PR #3185 generates an incomplete xml for C96C48_ufs_hybatmDA. I haven't looked into the details of #3185. Do you recall anything in #3185 which might be a problem when building xml for JEDI-based atmospheric DA?

[DavidNew-NOAA]

@RussTreadon-NOAA thanks for the heads up. #3185 only had Hercules CI run to test it, and it appears from the emcbot output that C96C48_ufs_hybatmDA is not run on that machine, so that's how this bug fell through the cracks.

[RussTreadon-NOAA]

Make the following change in a working copy of workflow/applications/gfs_cycled.py

@@ -311,6 +311,8 @@ class GFSCycledAppConfig(AppConfig):
                         task_names[run] += ['atmensanlobs', 'atmensanlsol']
                     else:
                         task_names[run] += ['atmensanlletkf']
+                    task_names[run].append('efcs') if 'gdas' in run else 0
+                    task_names[run].append('epos') if 'gdas' in run else 0
 
                 else:
                     task_names[run] += ['eobs', 'eupd']

With this change metatasks enkfgdas_fcst and enkfgdas_epmn are added to the xml file for C96C48_ufs_hybatmDA.

[RussTreadon-NOAA]

Work for this bugfix will be done in RussTreadon-NOAA:bugfix/ufs_hybatmDA