Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow APP to differ between RUNs #2943

Merged
merged 58 commits into from
Nov 26, 2024
Merged

Allow APP to differ between RUNs #2943

merged 58 commits into from
Nov 26, 2024

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Sep 19, 2024 •
edited
Loading

Description

This enables APP to be specified for each RUN. This also removes the need for a _no_run configuration dictionary and somewhat simplifies the _init_finalize method.

Resolves #2908
Resolves #2956

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any submodules? NO

How has this been tested?

  • Generated .xml files on Hera for all available CI tests and verified they were identical to develop.
  • Created an arbitrary APP configuration ({"gdas": "S2S", "gfs": "ATM"})

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@DavidHuber-NOAA

This comment was marked as resolved.

Sign in to view
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review October 1, 2024 19:24
@DavidHuber-NOAA
Copy link
Contributor Author

This PR now correctly generates identical CI XMLs as compared to develop (with the exception of the stage_ic and cleanup jobs which are now run on service partitions). An additional case was tested based on the C96C48_hybatmaerosnowDA case, but the APP was set to ATMA for RUN==gdas and ATM for RUN==gfs. In this case, the gfs tasks in the resultant XML did not include any aero-component jobs.

Marking ready for review.

DavidHuber-NOAA
DavidHuber-NOAA commented Oct 2, 2024
View reviewed changes
workflow/applications/applications.py Outdated Show resolved Hide resolved
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
workflow/applications/applications.py Outdated Show resolved Hide resolved
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
workflow/applications/gfs_forecast_only.py Outdated Show resolved Hide resolved
workflow/rocoto/gfs_tasks.py Outdated Show resolved Hide resolved
workflow/rocoto/gfs_tasks.py Outdated Show resolved Hide resolved
@emcbot emcbot added the CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed label Nov 25, 2024
@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_74c08046

@DavidHuber-NOAA
Copy link
Contributor Author

The aerosol forecast failed to be included due to a typo in config.base. Killing the tests and relaunching on Hera.

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C48mx500_3DVarAOWCDA FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C48mx500_3DVarAOWCDA_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C48_S2SW FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C48_S2SW_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C96_atm3DVar FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C96_atm3DVar_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C96C48_ufs_hybatmDA_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C96C48_hybatmDA FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C96C48_hybatmDA_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C48_ATM FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C48_ATM_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C48_S2SWA_gefs_74c08046

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 25, 2024
@emcbot
Copy link

emcbot commented Nov 25, 2024

CI Failed on Hera in Build# 8
Built and ran in directory /scratch1/NCEPDEV/global/CI_dh/2943


Experiment C96C48_hybatmaerosnowDA_74c08046 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Mon Nov 25 15:23:28 UTC 2024
Experiment C96C48_hybatmaerosnowDA_74c08046 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_74c08046/logs/2021122012/gdas_aeroanlgenb.log
Experiment C96_S2SWA_gefs_replay_ics_74c08046 Completed 1 Cycles: *SUCCESS* at Mon Nov 25 16:18:11 UTC 2024

@DavidHuber-NOAA DavidHuber-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 25, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 25, 2024
@emcbot
Copy link

emcbot commented Nov 25, 2024

CI Passed on Hera in Build# 9
Built and ran in directory /scratch1/NCEPDEV/global/CI_dh/2943


Experiment C96_S2SWA_gefs_replay_ics_e5becab5 Completed 1 Cycles: *SUCCESS* at Mon Nov 25 19:06:30 UTC 2024
Experiment C48mx500_3DVarAOWCDA_e5becab5 Completed 2 Cycles: *SUCCESS* at Mon Nov 25 19:18:37 UTC 2024
Experiment C48_ATM_e5becab5 Completed 2 Cycles: *SUCCESS* at Mon Nov 25 19:30:46 UTC 2024
Experiment C96C48_hybatmaerosnowDA_e5becab5 Completed 3 Cycles: *SUCCESS* at Mon Nov 25 20:31:54 UTC 2024
Experiment C48_S2SWA_gefs_e5becab5 Completed 1 Cycles: *SUCCESS* at Mon Nov 25 20:32:59 UTC 2024
Experiment C96_atm3DVar_e5becab5 Completed 3 Cycles: *SUCCESS* at Mon Nov 25 20:37:58 UTC 2024
Experiment C96C48_hybatmDA_e5becab5 Completed 3 Cycles: *SUCCESS* at Mon Nov 25 20:38:00 UTC 2024
Experiment C48_S2SW_e5becab5 Completed 2 Cycles: *SUCCESS* at Mon Nov 25 21:08:27 UTC 2024
Experiment C96C48_ufs_hybatmDA_e5becab5 Completed 3 Cycles: *SUCCESS* at Mon Nov 25 21:38:55 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit e41eff2 into NOAA-EMC:develop Nov 26, 2024
10 of 11 checks passed
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Nov 26, 2024
Merged
5 tasks
@DavidHuber-NOAA DavidHuber-NOAA deleted the feature/multi-app branch November 26, 2024 19:02
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Dec 2, 2024
Closed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Jan 27, 2025
@danholdaway
Merge branch 'develop' into feature/jedi_vs_gsi
fd62a43 
* develop:
  Remove WAFS files and references from `develop` (NOAA-EMC#3263)
  fix intel stack version number on c5 (NOAA-EMC#3258)
  Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252)
  Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255)
  Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)
  Only run METplus in the 3Dvar tests (NOAA-EMC#3245)
  Clone, build, and run C48_ATM and C48_S2SW on Gaea C5 and C6 (NOAA-EMC#3106)
  Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246)
  Add domain level to wave gridded COM path (NOAA-EMC#3137)
  CI JJOB Tests using CMake (NOAA-EMC#3214)
  Make assorted updates to waves (NOAA-EMC#3190)
  Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236)
  Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211)
  Add additional GEFS variables needed for AI/ML applications  (NOAA-EMC#3221)
  Add bmat task dependency to marine LETKF task (NOAA-EMC#3224)
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
  Separate use of initial increment/perturbation file from REPLAY/+03 ICs  (NOAA-EMC#3119)
  Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207)
  Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212)
  Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146)
  Remove multi-grid wave support (NOAA-EMC#3188)
  Add echgres as a dependency for earc (NOAA-EMC#3202)
  Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199)
  Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171)
  Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193)
  Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197)
  Remove early-cycle EnKF forecast (NOAA-EMC#3185)
  Fix mod_icec bug in atmos_prod (NOAA-EMC#3167)
  Create compute build option (NOAA-EMC#3186)
  Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998)
  Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175)
  Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163)
  Update compression options for GEFS history files (NOAA-EMC#3184)
  Update compression options for high res history files (NOAA-EMC#3178)
  Turn DO_TEST_MODE off (NOAA-EMC#3177)
  Hotfix for gdas_arch div/0 (NOAA-EMC#3169)
  Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow (NOAA-EMC#3098)
  Switch Aerosol DA to use JCB and Jedi class (NOAA-EMC#3125)
  Update ufs-weather-model to 2024-12-06 commit  (NOAA-EMC#3145)
  Enable traditional threading as an option (NOAA-EMC#3149)
  Update HPC_ACCOUNT on Hercules to fv3-cpu (NOAA-EMC#3164)
  Turn C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA into a regression test (NOAA-EMC#3120)
  Update GSI analysis jobs to use COMIN/COMOUT (NOAA-EMC#3092)
  Update HPC Tier Definitions (NOAA-EMC#3138)
  Add marine hybrid envar (NOAA-EMC#3041)
  Archive the experiment directory along with git status/diff output (NOAA-EMC#3105)
  Use stochastic restart patterns on rerun (NOAA-EMC#3077)
  Point Jenkinsfile back to CI/ (NOAA-EMC#3139)
  Fix wave restart for cold start and add ic version file (NOAA-EMC#3112)
  Allow users to override the default account at setup time (NOAA-EMC#3127)
  Refactor gridded wave post (NOAA-EMC#3014)
  Update docs related to NOAA CSPs (NOAA-EMC#3043)
  Allow APP to differ between RUNs (NOAA-EMC#2943)
  Run one executable for soca2cice (instead of two) (NOAA-EMC#3118)
  Speed up GSI analysis jobs in CI testing (NOAA-EMC#3115)
  Make aerosol output frequency variable (NOAA-EMC#2982)
  Add new stations to GFS BUFR sounding products (NOAA-EMC#3107)
  JCB-based obs+bias staging, Jedi class updates, and marine B-matrix refactoring (NOAA-EMC#2992)
  Enable tapering of atm ens perts at the model top (NOAA-EMC#3097)
  Update JGDAS ENKF POST  job  (NOAA-EMC#3090)
  SFS Runs at C96mx100  (NOAA-EMC#2960)
  Move machine-based options from config.base to host files (NOAA-EMC#3053)
  Remove RUNDIRS before running CI cases to cover re-run events (NOAA-EMC#3076)
  CI GitHub pipeline (hotfix) update for fetching repo name (NOAA-EMC#3084)
  Update JGDAS ENKF ECEN job  (NOAA-EMC#3050)
  Update snow obs processing job (NOAA-EMC#3055)
  Update to action workflow pipeline in default repo for development  (NOAA-EMC#3062)
  Update to action workflow pipeline in default repo for development (NOAA-EMC#3061)
  Update workflow pipeline (NOAA-EMC#3060)
  PW CI pipeline update5 ready for review so it can be merged and tested (NOAA-EMC#3059)
  Revert "GitHub CI Pipeline update for debugging forked PR support" (NOAA-EMC#3057)
  GitHub CI Pipeline update for debugging forked PR support (NOAA-EMC#3056)
  Add more ocean variables for post-processing in GEFS (NOAA-EMC#2995)
  Auto provisioning of PW clusters from GitHub CI added (NOAA-EMC#3051)
  Fix the name of the TC tracker filenames in archive.py (NOAA-EMC#3030)
  Make wxflow links static instead of from link_workflow (NOAA-EMC#3008)
  Update global jdas enkf diag job with COMIN/COMOUT for COM prefix (NOAA-EMC#2959)
  Add run and finalize methods to marine LETKF task (NOAA-EMC#2944)
  Fix wave restarts and GEFS FHOUT/FHMAX (NOAA-EMC#3009)
  Disabling hyper-threading (NOAA-EMC#2965)
  GitHub Actions Pipeline Updates for Self-Hosted Runners on PW (NOAA-EMC#3018)
  CI jekninsfile update hotfix (NOAA-EMC#3038)
  Update gdas.cd (NOAA-EMC#2978)
  Add ability to add tag to pslots with generate_workflows (NOAA-EMC#3036)
  CI update to shell environment with HOMEgfs to HOME_GFS for systems that need the path (NOAA-EMC#3013)
  Quick updated to Jenkins (health check) launch script (NOAA-EMC#3033)
  Document the generate_workflows.sh script (NOAA-EMC#3028)
  Replace gfs_cyc with an interval (NOAA-EMC#2928)
  Hotfix: Fix generate_workflows.sh optional build flags (NOAA-EMC#3024)
  Add a tool to run multiple YAML cases locally (NOAA-EMC#3004)
  Hotfix: Correctly set overwrite option when specified (NOAA-EMC#3021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul aerorahul is a code owner

@EricSinsky-NOAA EricSinsky-NOAA Awaiting requested review from EricSinsky-NOAA

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check reservable memory on Hercules and Orion Enable RUN-specific APP configurations
4 participants
@DavidHuber-NOAA @emcbot @TerrenceMcGuinness-NOAA @WalterKolczynski-NOAA