Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh

[RussTreadon-NOAA]

Description

This PR moves the LD_LIBRARY_PATH patches currently needed to run GDASApp on WCOSS2 from WCOSS2.env to load_ufsda_modules.sh. With this change, the LD_LIBRARY_PATH patch is only applied to WCOSS2 GDASApp jobs.

This change was suggested by @aerorahul

Resolves #3232

Type of change

• Maintenance (clean up)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO
• Does this change require an update to any of the following submodules? NO

How has this been tested?

• Clone and build on WCOSS2 (Cactus), Hera, and Orion
• run g-w CI on WCOSS2 (Cactus), Hera, and Orion

All jobs in all CI streams successfully run to completion on Cactus, Hera, and Orion

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing tests pass with my changes
• This change is covered by an existing CI test

[RussTreadon-NOAA]

@aerorahul and @WalterKolczynski-NOAA :

I manually ran g-w CI on WCOSS2 (Catcus), Hera, and Orion. Do I need to run Jenkins based CI? If yes, on which machine(s) do you want CI run? I'll apply the labels ASAP.

[aerorahul]

Looks fine to me if this works.
When this was in the WCOSS.env file, the LD_LIBRARY_PATH must have been appended. This will prepend these variables as the module loads are after.
I am just noting this difference if it has any bearing.

[aerorahul]

Since this change only involves WCOSS, I don't see a need to run on other platforms.

[RussTreadon-NOAA]

Items to Note

1. WCOSS2 Ticket#2025011610000019 opened noting a change in default options for the cc, CC, and ftn wrappers following the November/December 2024 WCOSS2 system upgrade

Before the upgrade these wrappers had the following default flags

-- C -- Intel 19.1.3.20200925
--     compiler   : /opt/cray/pe/craype/2.7.17/bin/cc
--     flags      :  -O2 -g -DNDEBUG
-- CXX -- Intel 19.1.3.20200925
--     compiler   : /opt/cray/pe/craype/2.7.17/bin/CC
--     flags      :  -O2 -g -DNDEBUG
-- Fortran -- Intel 19.1.3.20200925
--     compiler   : /opt/cray/pe/craype/2.7.17/bin/ftn
--     flags      :  -O2 -g -DNDEBUG -heap-arrays 32

After the upgrade the default flags are

- C -- Intel 19.1.3.20200925
--     compiler   : /opt/cray/pe/craype/2.7.17/bin/cc
--     flags      : -static-libgcc -static-libstdc++ -Bstatic -lstdc++ -Bdynamic -lm -lpthread -O2 -g -DNDEBUG
-- CXX -- Intel 19.1.3.20200925
--     compiler   : /opt/cray/pe/craype/2.7.17/bin/CC
--     flags      : -static-libgcc -static-libstdc++ -Bstatic -lstdc++ -Bdynamic -lm -lpthread -O2 -g -DNDEBUG
-- Fortran -- Intel 19.1.3.20200925
--     compiler   : /opt/cray/pe/craype/2.7.17/bin/ftn
--     flags      : -static-libgcc -static-libstdc++ -Bstatic -lstdc++ -Bdynamic -lm -lpthread -O2 -g -DNDEBUG -heap-arrays 32

The -Bdynamic flag enables dynamic linking of libraries at runtime.

Before the system upgrade GDASApp executables ran without the need to specify LD_LIBRARY_PATH. Following the system upgrade, it was found necessary to add LD_LIBRARY_PATH=$HOMEgfs/sorc/gdas.cd/build/lib.

2. The addition of

LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/opt/cray/pe/mpich/8.1.19/ofi/intel/19.0/lib"

is in response to path errors in system libraries following the system upgrade. GDIT is aware of this problem. No ETA as to when it will be fixed.

[emcbot]

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3236/RUNTESTS on WCOSS