Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gdas.cd #2978

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Update gdas.cd #2978

wants to merge 8 commits into from
+35 −1

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Oct 3, 2024 •
edited
Loading

Description

Updates to the gdas.cd #.
@RussTreadon-NOAA will submit a PR in the GDASApp, we'll update the gdas.cd # in this branch after the GDASApp PR is merged.
In the mean time, could somebody review the few simple code changes that are needed to run with the new #?

Depends on GDASApp PR #1310

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

Subset of the CI on Hercules and Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Oct 3, 2024
View reviewed changes
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Oct 4, 2024
Merged
aerorahul
aerorahul previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@RussTreadon-NOAA
Copy link
Contributor

@guillaumevernieres , the hash for sorc/gdas.cd can be updated. GDASApp PR #1310 was merged into develop at 9d95c9d.

@guillaumevernieres guillaumevernieres changed the title Feature/update hashes Update gdas.cd Oct 7, 2024
@guillaumevernieres @aerorahul
Update ush/python/pygfs/utils/marine_da_utils.py
9538ba5 
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
@guillaumevernieres
Copy link
Contributor Author

@guillaumevernieres , the hash for sorc/gdas.cd can be updated. GDASApp PR #1310 was merged into develop at 9d95c9d.

Thanks @RussTreadon-NOAA , working on it this morning.

@guillaumevernieres guillaumevernieres marked this pull request as ready for review October 7, 2024 13:21
CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Oct 7, 2024
View reviewed changes
aerorahul
aerorahul previously approved these changes Oct 7, 2024
View reviewed changes
@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Oct 7, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Oct 7, 2024
@aerorahul aerorahul added CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully labels Oct 11, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Oct 11, 2024
@aerorahul aerorahul self-requested a review October 11, 2024 18:35
aerorahul
aerorahul approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@TerrenceMcGuinness-NOAA
Copy link
Collaborator

Connection to Jenkins from Hera was interrupted and Finalize did not run on this CI Job. Removing label by hand.

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera label Oct 11, 2024
@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Oct 11, 2024
@emcbot
Copy link

emcbot commented Oct 11, 2024 

CI Update on Wcoss2 at 10/11/24 08:25:25 PM
============================================
Cloning and Building global-workflow PR: 2978
with PID: 153596 on host: clogin01

@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Oct 11, 2024
@emcbot
Copy link

emcbot commented Oct 11, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Fri Oct 11 20:31:36 UTC 2024 on clogin01
---------------------------------------------------
Build: Completed at 10/11/24 09:10:31 PM
Case setup: Completed for experiment C48_ATM_9536c8b4
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_9536c8b4
Case setup: Skipped for experiment C48_S2SWA_gefs_9536c8b4
Case setup: Completed for experiment C48_S2SW_9536c8b4
Case setup: Completed for experiment C96_atm3DVar_extended_9536c8b4
Case setup: Skipped for experiment C96_atm3DVar_9536c8b4
Case setup: Completed for experiment C96C48_hybatmaerosnowDA_9536c8b4
Case setup: Completed for experiment C96C48_hybatmDA_9536c8b4
Case setup: Completed for experiment C96C48_ufs_hybatmDA_9536c8b4
Case setup: Completed for experiment C96_S2SWA_gefs_replay_ics_9536c8b4

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 11, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Oct 11, 2024
@emcbot
Copy link

emcbot commented Oct 11, 2024

Experiment C96C48_hybatmaerosnowDA_9536c8b4 FAIL on Wcoss2 at 10/11/24 09:49:34 PM

Error logs:

/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2978/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_9536c8b4/logs/2021122018/gdas_snowanl.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Oct 11, 2024

Experiment C48mx500_3DVarAOWCDA FAILED on Hera in Build# 2 with error logs:

/scratch1/NCEPDEV/global/CI/2978/RUNTESTS/COMROOT/C48mx500_3DVarAOWCDA_9536c8b4/logs/2021032418/gdas_marinebmat.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Oct 11, 2024
@emcbot
Copy link

emcbot commented Oct 11, 2024

Experiment C48mx500_3DVarAOWCDA FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2978/RUNTESTS/EXPDIR/C48mx500_3DVarAOWCDA_9536c8b4

@emcbot
Copy link

emcbot commented Oct 11, 2024

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 2 with error logs:

/scratch1/NCEPDEV/global/CI/2978/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_9536c8b4/logs/2021122012/gdas_aeroanlgenb.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Oct 11, 2024

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2978/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_9536c8b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

Assignees
No one assigned
Labels
CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@guillaumevernieres @RussTreadon-NOAA @emcbot @CoryMartin-NOAA @TerrenceMcGuinness-NOAA @WalterKolczynski-NOAA @aerorahul