wave configuration update #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making readme consistant with user.yaml.default
…i cplwav model_config block. Reinstating config.wave block in JGLOBAL_FORECAST. Pointing EXECwave to HOMEgfs/exec directory for WW3 util executables (changed link_fv3gfs.sh accordingly). Removing debug options from compile.sh line in build_fv3.sh.
…coupled-crow-addWW3jobs
move default value into defaults/
It's better if we have one place to manage default values for configurable variables other than two Default values only for reference. Please throughly test to make sure it could reproduce.
scripts update: CCPP and IPD works
add hard-coded variables into config.fcst (fcst.yaml)
ice variable istep0 bug fix
add FNMSKH conditional clause, coupled vs non-coupled
…ripts Conflicts: workflow/platforms/_sandbox.yaml
…coupled-crow-addWW3jobs
Conflicts: jobs/JWAVE_INIT
first set of updates for waves and ice/ocean post updates
|
@JessicaMeixner-NOAA I've put the variables requested into the configuration system. Please take a look. |
updated environment files env/ORION.env updated configuration system
Conflicts: modulefiles/module_base.orion scripts/exwave_init.sh workflow/defaults/wave.yaml
* add waves to jglobal forecast config * updates - everything but wave post seems to run now, part of wave post does updating model to latest tag * change for lmod -> lmod/lmod on orion updated README * fixing syntax error in JWAVE_PREP job for variables that are not actively being used * adding cycle definition to wave post job * cleanup from duplications
JessicaMeixner-NOAA
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
The "base" no waves case should still work. The waves work except for post which will there will be an update later for. I approve this, but it should be tested by @jiandewang or @JianKuang-NOAA or others before merged.
|
tried twice on Orion, fcst and post finished properly, ocnpost failed due to library reason but it's not within the scope of this PR. So I am approving this PR. |
jiandewang
approved these changes
Jul 20, 2020
binli2337
approved these changes
Jul 20, 2020
TerrenceMcGuinness-NOAA
added a commit
that referenced
this pull request
Jun 8, 2023
Update hello.yaml
kayeekayee
pushed a commit
to kayeekayee/global-workflow
that referenced
this pull request
May 30, 2024
fv3atm:
fractional landmask changes (from @shansun6)
ccpp-framework:
bugfixes for handling optional arguments (no impact on current setup)
bugfix for debug messages (no impact on current setup)
ccpp-physics:
GFSv16 physics updates
add moninedmf_hafs
scientific documentation for NoahMP and satmedmfvdifq
bugfix for threading (avoid dead lock) when calculating Thompson MP lookup tables
addition of radar reflectivity reset switch for Thompson MP, bugfix for non-aerosol Thompson runs (from @ericaligo-NOAA)
fractional landmask changes (from @shansun6)
CCPP version of RAS, updates to shoc and MG (from @SMoorthi-emc)
bugfixes when levr < levs (from @SMoorthi-emc)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the following issues:
1, Fixed a bug in modulefile/module-setup.sh.inc causing user-defined modules not purged, on Orion.
2, Built out the configuration system for waves
3, Upgraded modularized forecast script for the handling of additional parameters (ie, PETS parameters) and the generation of nems.configure
4, Moved some of the variables in JWAVE_* scripts into the configuration system