Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct ocean MOM.res_# stage copy #2868

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Correct ocean MOM.res_# stage copy #2868

merged 3 commits into from
Aug 29, 2024

Conversation

KateFriedman-NOAA
Copy link
Member

Description

This PR corrects a bug in the staging job for ocean MOM.res_# IC files. The OCNRES value was coming in as an integer (e.g. 25) but the ocean.yaml.j2 file was checking for "025". Correct to now set OCNRES to be three digits in staging script and also correct the for loop range to include third file.

Resolves #2864

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Repeated the tests that the users who reported this ran.

@KateFriedman-NOAA
Correct ocean MOM.res_# stage copy
7d818dc 
- Set OCNRES to be three digits
- Correct for loop range to include third file

Refs NOAA-EMC#2864
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Aug 27, 2024
WalterKolczynski-NOAA
WalterKolczynski-NOAA requested changes Aug 28, 2024
View reviewed changes
parm/stage/ocean.yaml.j2 Outdated Show resolved Hide resolved
scripts/exglobal_stage_ic.py Show resolved Hide resolved
@KateFriedman-NOAA @WalterKolczynski-NOAA
Update range in stage/ocean.yaml.j2
f7649e9 
Refs NOAA-EMC#2864

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Aug 29, 2024
@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Aug 29, 2024
@emcbot
Copy link

emcbot commented Aug 29, 2024 

CI Update on Wcoss2 at 08/29/24 02:20:18 AM
============================================
Cloning and Building global-workflow PR: 2868
with PID: 51484 on host: clogin03

@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Aug 29, 2024
@emcbot
Copy link

emcbot commented Aug 29, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Thu Aug 29 02:26:40 UTC 2024 on clogin03
---------------------------------------------------
Build: Completed at 08/29/24 03:03:59 AM
Case setup: Completed for experiment C48_ATM_f7649e90
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_f7649e90
Case setup: Skipped for experiment C48_S2SWA_gefs_f7649e90
Case setup: Completed for experiment C48_S2SW_f7649e90
Case setup: Completed for experiment C96_atm3DVar_extended_f7649e90
Case setup: Skipped for experiment C96_atm3DVar_f7649e90
Case setup: Completed for experiment C96C48_hybatmaerosnowDA_f7649e90
Case setup: Completed for experiment C96C48_hybatmDA_f7649e90
Case setup: Skipped for experiment C96C48_ufs_hybatmDA_f7649e90

@emcbot emcbot added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Aug 29, 2024
@emcbot
Copy link

emcbot commented Aug 29, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_f7649e90 *** SUCCESS *** at 08/29/24 04:21:10 AM
Experiment C48_S2SW_f7649e90 *** SUCCESS *** at 08/29/24 04:35:09 AM
Experiment C96C48_hybatmDA_f7649e90 *** SUCCESS *** at 08/29/24 05:21:24 AM
Experiment C96C48_hybatmaerosnowDA_f7649e90 *** SUCCESS *** at 08/29/24 06:28:19 AM
Experiment C96_atm3DVar_extended_f7649e90 *** SUCCESS *** at 08/29/24 02:35:38 PM

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 5ccdd8b into NOAA-EMC:develop Aug 29, 2024
5 checks passed
@KateFriedman-NOAA KateFriedman-NOAA deleted the bugfix/ocnres_staging branch August 29, 2024 20:09
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 30, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into fix/early_run_configs
c4bba29 
* origin/develop:
  Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876)
  Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738)
  Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868)
  Support coupling on AWS (NOAA-EMC#2859)
  Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833)
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
386a940 
* origin/develop:
  Create JEDI class (NOAA-EMC#2805)
  Restructure the bufr sounding job    (NOAA-EMC#2853)
  Add an archive task to GEFS system to archive files locally (NOAA-EMC#2816)
  Reenable Orion Cycling Support (NOAA-EMC#2877)
  Eliminate race conditions and remove DATAROOT last in cleanup (NOAA-EMC#2893)
  Update aerosol climatology to 2013-2024 mean (NOAA-EMC#2888)
  Add ability to run CI test C96_atm3DVar.yaml to Gaea-C5 (NOAA-EMC#2885)
  Support global-workflow GEFS C48 on Google Cloud (NOAA-EMC#2861)
  Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876)
  Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738)
  Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868)
  Support coupling on AWS (NOAA-EMC#2859)
  Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833)
  Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857)
  Support ATM forecast only on Google (NOAA-EMC#2832)
  Add GEFS C48 support on AWS (NOAA-EMC#2818)
  Update omega calculation (NOAA-EMC#2751)
  Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690)
  support ATM forecast only on Azure (NOAA-EMC#2827)
  Convert staging job to python and yaml (NOAA-EMC#2651)
  Fixed test on UNAVAILBLE in python Rocoto check (NOAA-EMC#2842)
RussTreadon-NOAA added a commit to RussTreadon-NOAA/global-workflow that referenced this pull request Sep 10, 2024
@RussTreadon-NOAA
move radiance bias correction staging to jedi class (NOAA-EMC#2868)
73e56a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@RuiyuSun RuiyuSun RuiyuSun approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@jswhit2 jswhit2 jswhit2 approved these changes

Assignees

@KateFriedman-NOAA KateFriedman-NOAA

Labels
CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

recent updates break ocean cycling at 0.25 degree resolution
6 participants
@KateFriedman-NOAA @emcbot @jswhit2 @WalterKolczynski-NOAA @RuiyuSun @DavidHuber-NOAA