Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3 and 9 hr increment files to IC staging #2876

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Add 3 and 9 hr increment files to IC staging #2876

merged 3 commits into from
Aug 30, 2024

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

Description

Adds files atmi009.nc, atmi003.nc, ratmi009.nc, and ratmi003.nc to list of files to be staged for ICs, if available. These are necessary for starting an IAU run, and are currently missing.

Resolves #2874

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

GDASApp WCDA ctests and cycled experiment on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

KateFriedman-NOAA
KateFriedman-NOAA approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for adding those files @AndrewEichmann-NOAA !

@AndrewEichmann-NOAA
Copy link
Contributor Author

FYI @guillaumevernieres

guillaumevernieres
guillaumevernieres approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @AndrewEichmann-NOAA

@WalterKolczynski-NOAA
Copy link
Contributor

WalterKolczynski-NOAA commented Aug 29, 2024 •
edited
Loading

Is this going to cause issues for 3D-var when these may not be available?

@KateFriedman-NOAA
Copy link
Member

Is this going to cause issues for 3D-var when these may not be available?

Every file in the analysis yaml only gets added to the filehandler list if it exists. See the path_exists check in the yaml. I added that since there are varied combinations of which of these files are needed. The only issue may be if the user needs/expects one of those files but since it doesn't exist it's not picked up and an error isn't thrown.

@WalterKolczynski-NOAA
Copy link
Contributor

Is this going to cause issues for 3D-var when these may not be available?

Every file in the analysis yaml only gets added to the filehandler list if it exists. See the path_exists check in the yaml. I added that since there are varied combinations of which of these files are needed. The only issue may be if the user needs/expects one of those files but since it doesn't exist it's not picked up and an error isn't thrown.

Okay, Good for the PR, not so good overall.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Aug 29, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Aug 29, 2024
@emcbot
Copy link

emcbot commented Aug 29, 2024

Checkout Failed on Hera in Build# 1: Could not perform submodule update

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Aug 29, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Aug 30, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Aug 30, 2024
@emcbot
Copy link

emcbot commented Aug 30, 2024

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/2876


Experiment C48_ATM_a6c3987e Completed 1 Cycles: *SUCCESS* at Fri Aug 30 02:54:50 UTC 2024
Experiment C48mx500_3DVarAOWCDA_a6c3987e Completed 2 Cycles: *SUCCESS* at Fri Aug 30 02:54:50 UTC 2024
Experiment C96C48_hybatmDA_a6c3987e Completed 3 Cycles: *SUCCESS* at Fri Aug 30 04:02:41 UTC 2024
Experiment C96_atm3DVar_a6c3987e Completed 3 Cycles: *SUCCESS* at Fri Aug 30 04:08:23 UTC 2024
Experiment C48_S2SWA_gefs_a6c3987e Completed 1 Cycles: *SUCCESS* at Fri Aug 30 04:21:37 UTC 2024
Experiment C96C48_ufs_hybatmDA_a6c3987e Completed 2 Cycles: *SUCCESS* at Fri Aug 30 04:33:24 UTC 2024
Experiment C48_S2SW_a6c3987e Completed 1 Cycles: *SUCCESS* at Fri Aug 30 04:39:20 UTC 2024
Experiment C96C48_hybatmaerosnowDA_a6c3987e Completed 3 Cycles: *SUCCESS* at Fri Aug 30 04:57:43 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 66fc89c into NOAA-EMC:develop Aug 30, 2024
3 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 30, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into fix/early_run_configs
c4bba29 
* origin/develop:
  Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876)
  Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738)
  Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868)
  Support coupling on AWS (NOAA-EMC#2859)
  Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833)
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
386a940 
* origin/develop:
  Create JEDI class (NOAA-EMC#2805)
  Restructure the bufr sounding job    (NOAA-EMC#2853)
  Add an archive task to GEFS system to archive files locally (NOAA-EMC#2816)
  Reenable Orion Cycling Support (NOAA-EMC#2877)
  Eliminate race conditions and remove DATAROOT last in cleanup (NOAA-EMC#2893)
  Update aerosol climatology to 2013-2024 mean (NOAA-EMC#2888)
  Add ability to run CI test C96_atm3DVar.yaml to Gaea-C5 (NOAA-EMC#2885)
  Support global-workflow GEFS C48 on Google Cloud (NOAA-EMC#2861)
  Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876)
  Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738)
  Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868)
  Support coupling on AWS (NOAA-EMC#2859)
  Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833)
  Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857)
  Support ATM forecast only on Google (NOAA-EMC#2832)
  Add GEFS C48 support on AWS (NOAA-EMC#2818)
  Update omega calculation (NOAA-EMC#2751)
  Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690)
  support ATM forecast only on Azure (NOAA-EMC#2827)
  Convert staging job to python and yaml (NOAA-EMC#2651)
  Fixed test on UNAVAILBLE in python Rocoto check (NOAA-EMC#2842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The new IC staging task appears to neglect atmi003 and atmi009 files
5 participants
@AndrewEichmann-NOAA @WalterKolczynski-NOAA @KateFriedman-NOAA @emcbot @guillaumevernieres