-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation to test-fims-estimation #515
add documentation to test-fims-estimation #515
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
224f916
to
49040ff
Compare
Co-authored-by: KyleShertzer-NOAA <KyleShertzer-NOAA@users.noreply.github.com> Co-authored-by: Ian Taylor <iantaylor-NOAA@users.noreply.github.com>
49040ff
to
cad92a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 74.58% 76.10% +1.52%
==========================================
Files 38 37 -1
Lines 2034 1791 -243
Branches 136 0 -136
==========================================
- Hits 1517 1363 -154
+ Misses 476 428 -48
+ Partials 41 0 -41 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ian Taylor <iantaylor-NOAA@users.noreply.github.com> Co-authored-by: KyleShertzer-NOAA <KyleShertzer-NOAA@users.noreply.github.com>
Co-authored-by: Ian Taylor <iantaylor-NOAA@users.noreply.github.com> Co-authored-by: KyleShertzer-NOAA <KyleShertzer-NOAA@users.noreply.github.com>
We have added documentation through the deterministic test and filed issue #524 to cover the remainder of work |
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project?
How to test this change
Developer pre-PR checklist