-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: add a workflow to build the pkgdown site on PR #626
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 36 36
Lines 1945 1945
Branches 141 141
=======================================
Hits 1528 1528
Misses 374 374
Partials 43 43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bai-Li-NOAA , sorry for the delay on this! I had one question, but otherwise I think it looks good.
a72592a
to
4ef80fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for dropping the ball on this one - looks ready to merge in to me!
@kellijohnson-NOAA I'll leave this for you to decide how you would like to merge in (I assume rebasing to catch up, then rebase in, but I wasn't sure)
4ef80fc
to
6f86bcc
Compare
Thank you, @k-doering-NOAA. I have rebased the branch. |
What is the feature?
This PR addresses issue #595. It enables FIMS to render the pkgdown site on pull requests.
How have you implemented the solution?
Thanks, @k-doering-NOAA, for adding a reusable workflow to {ghactions4r}. The workflow call-build-pkgdown.yml has been added to FIMS to use this reusable workflow.
Does the PR impact any other area of the project?
No
How to test this change
It has been tested on the feature branch, and the pkgdown site materials have been successfully uploaded on Actions page here
Developer pre-PR checklist