Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOM6: +Obsoleted USE_LEGACY_SPLIT #150

Merged
merged 1 commit into from
Sep 14, 2017
Merged

MOM6: +Obsoleted USE_LEGACY_SPLIT #150

merged 1 commit into from
Sep 14, 2017

Conversation

Hallberg-NOAA
Copy link
Member

Removed the option to use the very old GOLD algorithm for the barotropic
solver. Also removed the modules MOM_dynamics_legacy_split and
MOM_legacy_barotropic This change was required to simplify the introduction of
new interfaces that clearly separate the dynamics, tracer advection and
thermodynamics update phases of the algorithm. Because there are no longer any
test cases that have USE_LEGACY_SPLIT=True, all answers are bitwise identical,
but the MOM_parameter_doc.all files for all test cases with dynamics change.
Also updated the versions of FMS and SIS2, but these are minor changes.
MOM6 commit NOAA-GFDL/MOM6@baed1fa

@Hallberg-NOAA
MOM6: +Obsoleted USE_LEGACY_SPLIT
3d01bfb 
  Removed the option to use the very old GOLD algorithm for the barotropic
solver.  Also removed the modules MOM_dynamics_legacy_split and
MOM_legacy_barotropic This change was required to simplify the introduction of
new interfaces that clearly separate the dynamics, tracer advection and
thermodynamics update phases of the algorithm.  Because there are no longer any
test cases that have USE_LEGACY_SPLIT=True, all answers are bitwise identical,
but the MOM_parameter_doc.all files for all test cases with dynamics change.
Also updated the versions of FMS and SIS2, but these are minor changes.
MOM6 commit NOAA-GFDL/MOM6@baed1fa
@adcroft adcroft merged commit 3d01bfb into dev/gfdl Sep 14, 2017
@adcroft adcroft deleted the obsolete_legacy_split branch February 10, 2018 17:19
adcroft added a commit to adcroft/MOM6-examples that referenced this pull request Sep 9, 2020
@adcroft
MOM6: Merge pull request #1176 from gustavo-marques/dev-master-candid…
63b44b1 
…ate-ncar-2020-08-11

- dev/NCAR to dev/master

- NOAA-GFDL/MOM6@eb57e51f5 Merge pull request #1176 from gustavo-marques/dev-master-candidate-ncar-2020-08-11
- NOAA-GFDL/MOM6@2946903bc Fix one more letter case to follow MOM6 convention
- NOAA-GFDL/MOM6@e3bc47a8d Fix letter case to follow MOM6 convention
- NOAA-GFDL/MOM6@17936f3fd Add modifications suggested by Bob Hallberg
- NOAA-GFDL/MOM6@ab9386c66 In do-loops, use uppercase K index for variables discretized on interfaces
- NOAA-GFDL/MOM6@287281cf6 Remove unnecessary present(num_rest_files) condition
- NOAA-GFDL/MOM6@6331da102 Remove (:,:) after 2-d variable declariation
- NOAA-GFDL/MOM6@608f4bfb8 Merge branch 'dev/master' into dev-master-candidate-ncar-2020-08-11
- NOAA-GFDL/MOM6@aa8ce213f Merge pull request NOAA-GFDL#156 from NCAR/fix_multi_restart
- NOAA-GFDL/MOM6@648bb1ce8 make mct cap be able to read multiple restart files from rpointer
- NOAA-GFDL/MOM6@829aadea9 make mct cap be able to write multiple restart files to rpointer
- NOAA-GFDL/MOM6@bba3e91b5 increase nuopc cap restart filename length
- NOAA-GFDL/MOM6@0a5515b3d increase restart filename lengths
- NOAA-GFDL/MOM6@4c91ae3ac add filename length check
- NOAA-GFDL/MOM6@7a2256c50 correct restart file suffix index
- NOAA-GFDL/MOM6@4c6090010 read/write multiple restart filenames from/to rpointer files
- NOAA-GFDL/MOM6@ff27ad560 add num_rest_files to ocean_model_restart
- NOAA-GFDL/MOM6@2fe90f2fe retrieve num_rest_files from save_restart
- NOAA-GFDL/MOM6@330d7c45a Merge pull request NOAA-GFDL#155 from gustavo-marques/LBD_improvements_jun2020
- NOAA-GFDL/MOM6@388b100c8 Fix default zeta_bot values
- NOAA-GFDL/MOM6@3698c4055 Merge pull request NOAA-GFDL#154 from gustavo-marques/restart_nuopc
- NOAA-GFDL/MOM6@0c98fa994 Merge pull request NOAA-GFDL#153 from gustavo-marques/add_calls_time_interp_external_init
- NOAA-GFDL/MOM6@bb222c875 Merge pull request NOAA-GFDL#152 from gustavo-marques/add_diagnostics
- NOAA-GFDL/MOM6@ca86bad51 Remove trailing space
- NOAA-GFDL/MOM6@8fdcd9048 Improve documentation and changed default method
- NOAA-GFDL/MOM6@7f478aa3e Add option to apply linear decay at the base of hbl
- NOAA-GFDL/MOM6@aed316cd7 Merge branch 'dev/ncar' into restart_nuopc
- NOAA-GFDL/MOM6@abb10ed4c Add calls to time_interp_external_init
- NOAA-GFDL/MOM6@473c3f47b Remove unused module
- NOAA-GFDL/MOM6@a69aea961 Add new diagnostics
- NOAA-GFDL/MOM6@4041cc90b Fix bug when applying ND only in the interior
- NOAA-GFDL/MOM6@fd68ffa0b Merge pull request NOAA-GFDL#151 from gustavo-marques/merge-dev-master-candidate-2020-05-15
- NOAA-GFDL/MOM6@97547426a Fix OMP directives broken by merge
- NOAA-GFDL/MOM6@532e65ad5 undo OMP changes in MOM_EOS
- NOAA-GFDL/MOM6@b34478800 undo indent change from conflict resolve
- NOAA-GFDL/MOM6@2f44ca7ce correct conflict resolve in KPP
- NOAA-GFDL/MOM6@81805cc99 Merge branch 'dev/ncar' into merge-dev-master-candidate-2020-05-15
- NOAA-GFDL/MOM6@85f4dc09b Merge pull request NOAA-GFDL#150 from NCAR/omp_performance
- NOAA-GFDL/MOM6@4755458e3 Merge branch 'dev-master-candidate-2020-05-15-patch1' into merge-dev-master-candidate-2020-05-15
- NOAA-GFDL/MOM6@fab21a749 Fixes an integer-kind mismatch in MOM_random, seed_from_time()
- NOAA-GFDL/MOM6@6d5a5f90b Merge branch 'dev-master-candidate-2020-05-15' into merge-dev-master-candidate-2020-05-15
- NOAA-GFDL/MOM6@02f5a8cf3 Merge pull request NOAA-GFDL#149 from gustavo-marques/fix_tidal_mixing
- NOAA-GFDL/MOM6@c42d104c5 Merge pull request NOAA-GFDL#148 from gustavo-marques/leith_improvements
- NOAA-GFDL/MOM6@809593cb4 Merge branch 'dev/ncar' into leith_improvements
- NOAA-GFDL/MOM6@4e54ad531 Merge pull request NOAA-GFDL#147 from gustavo-marques/biharmonic_grid_Re
- NOAA-GFDL/MOM6@c06515f19 Add tidal diffusivities (Kd_tidal) into Kd_int
- NOAA-GFDL/MOM6@933b09abe Remove OMP directive that came with cherry-picking
- NOAA-GFDL/MOM6@7d228f73a Add missing OMP directives
- NOAA-GFDL/MOM6@b412fde96 Fix Leith_Ah
- NOAA-GFDL/MOM6@c53525eae Clean QG_Leith
- NOAA-GFDL/MOM6@48310e3d6 eliminate omp parallel open/close in to int_density_dz_generic_plm
- NOAA-GFDL/MOM6@98f5a8d97 add omp directives to int_density_dz_generic_plm
- NOAA-GFDL/MOM6@1165a61ba further refactor smoothing subroutine
- NOAA-GFDL/MOM6@e47e8b712 uncomment KPP clocks
- NOAA-GFDL/MOM6@e5fcc694d remove OMP enclosing get_BLD call
- NOAA-GFDL/MOM6@1e7fa519b add KPP timing clocks and omp directives
- NOAA-GFDL/MOM6@cd00022b5 Fix OMP calls
- NOAA-GFDL/MOM6@e3cbcbbd0 Fix openmp directives
- NOAA-GFDL/MOM6@e955c6d9a Fix openmp directives
- NOAA-GFDL/MOM6@3fb86e3ed Avoid division by zero
- NOAA-GFDL/MOM6@b609dead2 Fix indices in KE calculation
- NOAA-GFDL/MOM6@49ab54ab5 move pass_var in KPP smoothing outside the do-loop
- NOAA-GFDL/MOM6@65f36d768 Add diags for Lapl. and Bihar grid Reynolds #s
- NOAA-GFDL/MOM6@6cf28bf15 Add option to scale AH via a biharmonic Reynolds #
- NOAA-GFDL/MOM6@3dd70fe71 remove unnecessary kOBL computation
- NOAA-GFDL/MOM6@2aa10917d optimize barotropic timestepping openmp
- NOAA-GFDL/MOM6@01f7c452e uncomment omp in barotropic solver
- NOAA-GFDL/MOM6@0a2bb505f uncomment omp directive for KPP_compute_BLD
- NOAA-GFDL/MOM6@e089a159f bug fix for cesm when restart_option is none
- NOAA-GFDL/MOM6@1a6411f0c added changes to unify cap with EMC changes
- NOAA-GFDL/MOM6@2fe522454 updates to clean up differences between nems and cmeps for restarts
adcroft added a commit that referenced this pull request Sep 9, 2020
@adcroft
Merge branch 'dev/master' into dev/gfdl
6840cd2 
- dev/master -> dev/gfdl

- NOAA-GFDL/MOM6@fae989582 Merge branch 'Hallberg-NOAA-merge_ncar_gfdl' into dev/gfdl
- NOAA-GFDL/MOM6@97793be50 Merge branch 'dev/master' into merge_ncar_gfdl
- NOAA-GFDL/MOM6@eb57e51f5 Merge pull request #1176 from gustavo-marques/dev-master-candidate-ncar-2020-08-11
- NOAA-GFDL/MOM6@c32db2594 Merge pull request #1193 from adcroft/brankart
- NOAA-GFDL/MOM6@365dd7c32 Merge branch 'dev/gfdl' into brankart
- NOAA-GFDL/MOM6@413427889 Merge branch 'Hallberg-NOAA-fix_memory_macros' into dev/gfdl
- NOAA-GFDL/MOM6@71f6921a1 Merge branch 'fix_memory_macros' of https://github.com/Hallberg-NOAA/MOM6 into Hallberg-NOAA-fix_memory_macros
- NOAA-GFDL/MOM6@edff25e02 Rename intermediate variable in Stanley PGF parameterization
- NOAA-GFDL/MOM6@b155bf36b (*)Correct the use of memory macros for arguments
- NOAA-GFDL/MOM6@4dbc12697 Adds land masking of thicknesses in SGS estimate
- NOAA-GFDL/MOM6@63a2e2ae8 Merge branch 'dev/gfdl' into brankart
- NOAA-GFDL/MOM6@54cf60d99 Merge branch 'dev/gfdl' into brankart
- NOAA-GFDL/MOM6@995e42232 Fix spelling in comments and line length
- NOAA-GFDL/MOM6@2946903bc Fix one more letter case to follow MOM6 convention
- NOAA-GFDL/MOM6@e3bc47a8d Fix letter case to follow MOM6 convention
- NOAA-GFDL/MOM6@17936f3fd Add modifications suggested by Bob Hallberg
- NOAA-GFDL/MOM6@ab9386c66 In do-loops, use uppercase K index for variables discretized on interfaces
- NOAA-GFDL/MOM6@287281cf6 Remove unnecessary present(num_rest_files) condition
- NOAA-GFDL/MOM6@6331da102 Remove (:,:) after 2-d variable declariation
- NOAA-GFDL/MOM6@608f4bfb8 Merge branch 'dev/master' into dev-master-candidate-ncar-2020-08-11
- NOAA-GFDL/MOM6@aa8ce213f Merge pull request #156 from NCAR/fix_multi_restart
- NOAA-GFDL/MOM6@648bb1ce8 make mct cap be able to read multiple restart files from rpointer
- NOAA-GFDL/MOM6@829aadea9 make mct cap be able to write multiple restart files to rpointer
- NOAA-GFDL/MOM6@bba3e91b5 increase nuopc cap restart filename length
- NOAA-GFDL/MOM6@0a5515b3d increase restart filename lengths
- NOAA-GFDL/MOM6@4c91ae3ac add filename length check
- NOAA-GFDL/MOM6@7a2256c50 correct restart file suffix index
- NOAA-GFDL/MOM6@4c6090010 read/write multiple restart filenames from/to rpointer files
- NOAA-GFDL/MOM6@ff27ad560 add num_rest_files to ocean_model_restart
- NOAA-GFDL/MOM6@2fe90f2fe retrieve num_rest_files from save_restart
- NOAA-GFDL/MOM6@f549dd011 Use thickness weighted variance estimate in PGF
- NOAA-GFDL/MOM6@859abbd36 Add diagnostic of SGS T variance in Stanley PGF
- NOAA-GFDL/MOM6@330d7c45a Merge pull request #155 from gustavo-marques/LBD_improvements_jun2020
- NOAA-GFDL/MOM6@388b100c8 Fix default zeta_bot values
- NOAA-GFDL/MOM6@3698c4055 Merge pull request #154 from gustavo-marques/restart_nuopc
- NOAA-GFDL/MOM6@0c98fa994 Merge pull request #153 from gustavo-marques/add_calls_time_interp_external_init
- NOAA-GFDL/MOM6@bb222c875 Merge pull request #152 from gustavo-marques/add_diagnostics
- NOAA-GFDL/MOM6@ca86bad51 Remove trailing space
- NOAA-GFDL/MOM6@8fdcd9048 Improve documentation and changed default method
- NOAA-GFDL/MOM6@7f478aa3e Add option to apply linear decay at the base of hbl
- NOAA-GFDL/MOM6@aed316cd7 Merge branch 'dev/ncar' into restart_nuopc
- NOAA-GFDL/MOM6@abb10ed4c Add calls to time_interp_external_init
- NOAA-GFDL/MOM6@473c3f47b Remove unused module
- NOAA-GFDL/MOM6@a69aea961 Add new diagnostics
- NOAA-GFDL/MOM6@4041cc90b Fix bug when applying ND only in the interior
- NOAA-GFDL/MOM6@fd68ffa0b Merge pull request #151 from gustavo-marques/merge-dev-master-candidate-2020-05-15
- NOAA-GFDL/MOM6@97547426a Fix OMP directives broken by merge
- NOAA-GFDL/MOM6@532e65ad5 undo OMP changes in MOM_EOS
- NOAA-GFDL/MOM6@b34478800 undo indent change from conflict resolve
- NOAA-GFDL/MOM6@2f44ca7ce correct conflict resolve in KPP
- NOAA-GFDL/MOM6@81805cc99 Merge branch 'dev/ncar' into merge-dev-master-candidate-2020-05-15
- NOAA-GFDL/MOM6@85f4dc09b Merge pull request #150 from NCAR/omp_performance
- NOAA-GFDL/MOM6@4755458e3 Merge branch 'dev-master-candidate-2020-05-15-patch1' into merge-dev-master-candidate-2020-05-15
- NOAA-GFDL/MOM6@fab21a749 Fixes an integer-kind mismatch in MOM_random, seed_from_time()
- NOAA-GFDL/MOM6@6d5a5f90b Merge branch 'dev-master-candidate-2020-05-15' into merge-dev-master-candidate-2020-05-15
- NOAA-GFDL/MOM6@02f5a8cf3 Merge pull request #149 from gustavo-marques/fix_tidal_mixing
- NOAA-GFDL/MOM6@c42d104c5 Merge pull request #148 from gustavo-marques/leith_improvements
- NOAA-GFDL/MOM6@809593cb4 Merge branch 'dev/ncar' into leith_improvements
- NOAA-GFDL/MOM6@4e54ad531 Merge pull request #147 from gustavo-marques/biharmonic_grid_Re
- NOAA-GFDL/MOM6@c06515f19 Add tidal diffusivities (Kd_tidal) into Kd_int
- NOAA-GFDL/MOM6@933b09abe Remove OMP directive that came with cherry-picking
- NOAA-GFDL/MOM6@7d228f73a Add missing OMP directives
- NOAA-GFDL/MOM6@b412fde96 Fix Leith_Ah
- NOAA-GFDL/MOM6@c53525eae Clean QG_Leith
- NOAA-GFDL/MOM6@48310e3d6 eliminate omp parallel open/close in to int_density_dz_generic_plm
- NOAA-GFDL/MOM6@98f5a8d97 add omp directives to int_density_dz_generic_plm
- NOAA-GFDL/MOM6@1165a61ba further refactor smoothing subroutine
- NOAA-GFDL/MOM6@e47e8b712 uncomment KPP clocks
- NOAA-GFDL/MOM6@e5fcc694d remove OMP enclosing get_BLD call
- NOAA-GFDL/MOM6@1e7fa519b add KPP timing clocks and omp directives
- NOAA-GFDL/MOM6@cd00022b5 Fix OMP calls
- NOAA-GFDL/MOM6@e3cbcbbd0 Fix openmp directives
- NOAA-GFDL/MOM6@e955c6d9a Fix openmp directives
- NOAA-GFDL/MOM6@3fb86e3ed Avoid division by zero
- NOAA-GFDL/MOM6@b609dead2 Fix indices in KE calculation
- NOAA-GFDL/MOM6@49ab54ab5 move pass_var in KPP smoothing outside the do-loop
- NOAA-GFDL/MOM6@65f36d768 Add diags for Lapl. and Bihar grid Reynolds #s
- NOAA-GFDL/MOM6@6cf28bf15 Add option to scale AH via a biharmonic Reynolds #
- NOAA-GFDL/MOM6@3dd70fe71 remove unnecessary kOBL computation
- NOAA-GFDL/MOM6@2aa10917d optimize barotropic timestepping openmp
- NOAA-GFDL/MOM6@01f7c452e uncomment omp in barotropic solver
- NOAA-GFDL/MOM6@0a2bb505f uncomment omp directive for KPP_compute_BLD
- NOAA-GFDL/MOM6@e089a159f bug fix for cesm when restart_option is none
- NOAA-GFDL/MOM6@1a6411f0c added changes to unify cap with EMC changes
- NOAA-GFDL/MOM6@2fe522454 updates to clean up differences between nems and cmeps for restarts
adcroft added a commit that referenced this pull request Jun 30, 2021
@adcroft
SIS2: Merge pull request #151 from MJHarrison-GFDL/Icepack_doc
7743fcc 
- Rolling forward SIS2 in preparation for PR to main
- No doc string changes

- NOAA_GFDL/SIS2@a771f39 Merge pull request #151 from MJHarrison-GFDL/Icepack_doc
- NOAA_GFDL/SIS2@80c6299 Address comments from @Hallberg-NOAA
- NOAA_GFDL/SIS2@210bea1 Merge pull request #150 from Hallberg-NOAA/fix_restart_names
- NOAA_GFDL/SIS2@8030d73 Added some documentation for Icepack ridging interface
- NOAA_GFDL/SIS2@d1cea62 (*)Correct multi-name handling by save_restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hallberg-NOAA @adcroft