forked from mom-ocean/MOM6
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new loss term for internal waves: scattering to higher modes #33
Closed
Closed
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
36d4f7f
Bugfix: cpu clock sync error
marshallward e48f4a7
+Add the new routine unit_no_scaling_init
Hallberg-NOAA 59c5926
(*)Provide US arguments to 4 existing calls
Hallberg-NOAA 3162bd0
+Make US arguments non-optional for 28 routines
Hallberg-NOAA 763ddab
Docs: Add NASA-GMAO to consortium figure
marshallward 582de2e
add infrastructure for residual term
196586d
add residual term loss on flux
6807892
clean up/ move to implicit update
3ce6a31
Merge branch 'dev/gfdl' into cpu_clock_sync_bugfix
Hallberg-NOAA 833cd30
+Remove clocks inside of j-loops
Hallberg-NOAA 8b5c1c8
Deallocate eta_PF_start to avoid a memory leak
Hallberg-NOAA 3f46b6a
+Set find_salt_root if SHELF_THREE_EQN = .False.
Hallberg-NOAA ec553aa
+Obsolete ETA_TOLERANCE_AUX
Hallberg-NOAA d733714
(*)Fix extract_diabatic_member
Hallberg-NOAA 5172c49
Warn if opacity_from_chl is called without fluxes
Hallberg-NOAA 90739be
Correct comments describing advect_tracer args
Hallberg-NOAA 3364af1
Update indexing of array passed to data_override.
wfcooke 2319139
Correct out of bounds index (por_face_areaU) bug
Hallberg-NOAA 05edb63
(*)Offline tracer read bug fix
Hallberg-NOAA fcfd238
+Refactored and rescaled the offline tracer code
Hallberg-NOAA 09bcea2
Merge branch 'dev/gfdl' into cpu_clock_sync_bugfix
Hallberg-NOAA 112ac49
+(*)Revised offline tracer algorithms
Hallberg-NOAA 0895fe3
Merge branch 'dev/gfdl' into offline_tracer_fix
Hallberg-NOAA fbafcb1
Merge branch 'dev/gfdl' into mandatory_US_args
Hallberg-NOAA 86b91dc
Merge pull request #29 from Hallberg-NOAA/mandatory_US_args
marshallward e452a29
Merge branch 'dev/gfdl' into cpu_clock_sync_bugfix
Hallberg-NOAA 7ae28b8
Merge pull request #27 from marshallward/cpu_clock_sync_bugfix
Hallberg-NOAA 8824671
Merge branch 'dev/gfdl' into consortium_fig_update
Hallberg-NOAA 8f5dc28
Merge pull request #31 from marshallward/consortium_fig_update
Hallberg-NOAA cf931b1
Eliminate unneeded diagnostic arrays
Hallberg-NOAA 170fffd
MOM_sponge cleanup
Hallberg-NOAA 6feadd0
Use G%Rad_Earth_L in mct and NUOPC cap code
Hallberg-NOAA bbb9753
+Rescale some sea-surface height variables to [Z]
Hallberg-NOAA 86eb106
Correct the units in two comments
Hallberg-NOAA 049241c
+Rescaled optics%opacity_band
Hallberg-NOAA 08cd63b
Merge branch 'dev/gfdl' into opacity_rescale
Hallberg-NOAA 0544f9f
+(*)Avoid segmentation faults if PEN_SW_NBANDS = 0
Hallberg-NOAA 50df270
Ice dynamics (#35)
OlgaSergienko 12f29f6
Adding temperature restore capability for SPEAR. (#36)
wfcooke a902e75
+Add US args and rescale dt arg to generic tracers
Hallberg-NOAA 9cb9304
EMC stochastic candidate 20211028 (#1538)
jiandewang 986bc8c
Corrected the unit documentation for 31 variables
Hallberg-NOAA d244246
+Rescale tides and ramp-up times
Hallberg-NOAA 9a5e218
Merge branch 'main' into main_to_dev_gfdl
marshallward bf43fd8
Merge pull request #47 from marshallward/main_to_dev_gfdl
adcroft 5d4e8a1
(*)Removed problematic offline tracer lines
Hallberg-NOAA dad675a
Fix badge URL for codecov
adcroft 34554d0
Merge branch 'dev/gfdl' into offline_tracer_fix
Hallberg-NOAA e3c0b72
Merge branch 'dev/gfdl' into offline_tracer_fix
Hallberg-NOAA f35edbd
Bugfix - calculate density integrals in ALE mode w/ pressure_reconstr…
MJHarrison-GFDL f865b24
Update MOM_PressureForce_FV.F90
marshallward b628748
Correct comments describing generic_tracer args
Hallberg-NOAA 6bcea76
Fixes an uninitialized logical in FMS_cap
adcroft d9d82e3
Eliminate unneeded diagnostic arrays in CorAdCalc
Hallberg-NOAA a8a2039
Merge branch 'dev/gfdl' into opacity_rescale
Hallberg-NOAA 1028ee0
Merge pull request #43 from Hallberg-NOAA/opacity_rescale
marshallward c32ec97
Merge branch 'dev/gfdl' into offline_tracer_fix
Hallberg-NOAA 5ad8a2c
Deleted commented out offline tracer lines
Hallberg-NOAA 2b2214d
(*)Use por_face_area in zonal_face_thickness
Hallberg-NOAA e5a5407
Merge branch 'dev/gfdl' into offline_tracer_fix
marshallward 71cf831
Merge pull request #37 from Hallberg-NOAA/offline_tracer_fix
marshallward 2d32631
Option to homogenize forces and fluxes (#51)
breichl df46be4
Hydrostatic initialization in ice cavities (#41)
MJHarrison-GFDL f7a2254
Rewrite horizontal regridding to use netCDF wrapper functions (#48)
marshallward d838ccd
Clean up non-standard syntax and whitespace
Hallberg-NOAA 6da5c9b
Standardize code in calc_sfc_displacement
Hallberg-NOAA 9f0018f
+(*)Change the remapping dzInterface argument sign
Hallberg-NOAA 03a247e
Avoid divide by zero in horizontal_viscosity() with better_bound_kh
adcroft e63c405
Fix soft-conventional index capitalization in horizontal_viscosity()
adcroft 65998cd
Esmg docs (#57)
kshedstrom 3f58f8a
read_variable_2d modified to accept 3 or 4 dims
marshallward 56401b6
+Add MOM_check_scaling.F90 and MOM_scaling_check.F90
Hallberg-NOAA 75bf521
+Move MOM_scaling_check.F90 to MOM_unique_scales.F90
Hallberg-NOAA 64f432f
Diabatic driver: energetic_PBL -> ePBL, flag check
marshallward fc5253f
(*)Correct memory declarations in MOM_regridding
Hallberg-NOAA c166358
Add optional argument to FMS2 version of get_field_size
MJHarrison-GFDL e841609
remove unnecessary optional flag
MJHarrison-GFDL 6f6d4d6
Merge pull request #1556 from NOAA-GFDL/dev-gfdl-main-candidate-2022-…
marshallward 5f56798
Merge branch 'main' into main_to_dev
marshallward 32e1ecf
Fixes issues with the GME code and get_param calls for Leith options …
gustavo-marques 149073f
Remove hard-wired parameter in adjustEtaToFitBathymetry (#69)
gustavo-marques 712ff9e
Merge branch 'dev/gfdl' into main_to_dev
Hallberg-NOAA 2e72b88
Merge pull request #71 from NOAA-GFDL/main_to_dev
Hallberg-NOAA d46dbc7
Report mean temperature from MOM_state_stats()
Hallberg-NOAA 9c7bf29
+Add global_mass_int_EFP
Hallberg-NOAA 8197cea
Use global_mass_integral in lateral_bdry_diff
Hallberg-NOAA 1bf8220
(*)+Reproducing tracer stocks
Hallberg-NOAA a0d0238
(*)+Use reproducing stocks for all tracer packages
Hallberg-NOAA a468bee
Removed trailing white space
Hallberg-NOAA 9caa701
(+) Refactor of MOM_file_parser
marshallward cf193a8
Merge pull request #74 from marshallward/file_parser_refactor
Hallberg-NOAA 9a01cd5
+Add ALE options mimicking Hycom
Hallberg-NOAA 4640461
(*)Avoid negative thicknesses in mixed_layer_restrat
Hallberg-NOAA dadd182
add infrastructure for residual term
b671a87
add residual term loss on flux
46d292c
clean up/ move to implicit update
0120792
parenthesis
6a208f1
Merge branch 'residualIW' of github.com:raphaeldussin/MOM6 into resid…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add infrastructure for residual term
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be sure to add parentheses specifying the order of sums of 3 or more terms, here and elsewhere in this module.
The expressions
A+(B+C)
and(A+B)+C
are not the same at the level of roundoff, and the differences can be very significant if they are of opposite signs and diversion magnitudes. Consider the sum of 1, -1 and 1e-20, which for double precision floating point numbers could give 0 or 1e-20, depending on the order in which the sums are done.We have often found it very helpful for debugging enforce the order of these sums with parentheses. (In fact, we are thinking of using Marshall's Flint capabilities to detect and replace every instance where the code does not specify the order of 2 or more sums.)