Use fileset rather than threading for decompositon #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be required to get NOAA-GFDL/SIS2#196 working correctly. |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #378 +/- ##
=========================================
Coverage 38.38% 38.38%
=========================================
Files 268 268
Lines 76010 76010
Branches 13987 13987
=========================================
Hits 29174 29174
Misses 41597 41597
Partials 5239 5239
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MOM IO was using the `threading` flag rather than `fileset` to determine whether a file should be forced as single file rather than domain-decomposed. This patch applies the correct flag.
Hallberg-NOAA
force-pushed
the
domain_fileset_fix
branch
from
629c4ba to
8eccd14
Compare
adcroft
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOM IO was using the
threadingflag rather thanfilesetto determine whether a file should be forced as single file rather than domain-decomposed. This patch applies the correct flag.