Update SIS2 to use the new IO interface #196
Conversation
The legacy file_type and fieldtype handles for field IO are replaced with the newer MOM IO types (MOM_infra_file, MOM_field), which provide new FMS-agnostic interfaces to the framework IO. This also conforms to the new requirement of FMS IO requiring a domain. (Note that this may be relaxed in the future.) Thanks to Kate Hedstrom (@kshedstrom) for identifying the issue and providing the first draft to this fix.
|
@kshedstrom I seem unable to add you as a reviewer, but if you have a chance it would be good to get you feedback. |
|
There is still an error here: This is the same error as in #195, and which I had thought this patch would address, but I suppose not. I will continue to look into it. |
|
Apparently if the non-domain-decomposed file is seen, it ignores Either way this is consistent, but I find it weird that it uses the form of the existing file in place of the user-specified flag. And FWIW, this is nothing that #196 would have fixed; #195 would have been fine here. |
|
Yes, it's been working for me. Sorry, I thought I had posted, but I guess not. |
|
Sorry @kshedstrom, those comments weren't directed to you, I should have been more clear. We are still seeing errors with FMS1, so we can't merge this yet. |
|
I think the associated issues on MOM6 have been fixed, and this is now ready for review. |
|
@kshedstrom I've tested this in FMS1 with our CI and tried to test it with FMS2 to the best of my ability, but if you have a chance to test it in one of your FMS2 runs that would be a big help. |
|
Yes, it's been working fine for me. |
|
@Hallberg-NOAA @adcroft This is ready for review |
|
This passed: https://gitlab.gfdl.noaa.gov/ogrp/SIS2/-/pipelines/19535 ✅ |
The legacy
file_typeandfieldtypehandles for field IO are replaced with the newer MOM IO types (MOM_infra_file,MOM_field), which provide new FMS-agnostic interfaces to the framework IO.This also conforms to the new requirement of FMS IO requiring a domain. (Note that this may be relaxed in the future.)
Thanks to Kate Hedstrom (@kshedstrom) for identifying the issue and providing the first draft to this fix.