Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MOM6 issue #364 #195

Closed
wants to merge 1 commit into from
Closed

Conversation

kshedstrom
Copy link
Contributor

Corrects call to FMS2 interface requiring the domain argument.

Copy link
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and adding that, @kshedstrom

@marshallward
Copy link
Member

marshallward commented Jun 5, 2023

Now that our CI is finally working, I was able to test this. Although it works with FMS2 I/O, it is failing with the FMS1. I am fairly certain the problem is that the legacy open_file() wrapper function is not as robust as I had thought, and that is causing some issues with IO layouts.

I think that this will work if the instances of file_type and field are flipped over to MOM_infra_file and MOM_field, since the open() function does some extra work to spoof the IO_domain, but making those changes will be a bit more work.

I wither either submit those changes to this PR or put them in as a new one. Either way, I'll keep you updated @kshedstrom.

@marshallward
Copy link
Member

I've opened #196 which should address this issue.

@marshallward
Copy link
Member

Closing this issue since #196 handles the issue.

@kshedstrom kshedstrom deleted the restart_patch branch July 14, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants