Update gsl/develop from main 2021/05/31 #93

climbfuji · 2021-05-31T20:40:21Z

Update gsl/develop from main 2021/05/31 and bug fix for tendencies code in drag_suite.F90. Changes:

consistent calculation of surface roughness length with fractional landmask
update of surface emissivity/albedo calculation for Noah, NoahMP and RUC LSM
- new scheme GFS_radiation_surface, independent of RRTMG/RRTMGP choice
consistency checks between namelist options and suite definition file
RUC LSM update
bug fixes in several schemes (inconsistencies between CCPP metadata and Fortran code)
bug fix in drag_suite.F90: add missing initialization of udtend, vdtend, Tdtend if ldiag3d is false

Associated PRs:
NOAA-GSL/ccpp-framework#15
#93
NOAA-GSL/fv3atm#93
NOAA-GSL/ufs-weather-model#83

For regression testing, see NOAA-GSL/ufs-weather-model#83.

radiation.

GFS_phys_time_vary_init.

…into frac_emiss_albedo

frac_grid=.false.

…ccpp-physics into HEAD

…emes into GFS_radiation_surface, consolidate, fix bugs

lsm_ruc_init. This is needed for MYNN surface layer scheme at the first time step.

…composites_post, add necessary new interstitial variables, clean up old/unused interstitial variables

…ve_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

…om OpenMP

…fter call to stability

…composite_consistent_sfcqv_init' of https://github.com/tanyasmirnova/ccpp-physics into move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

…een original ialbflg==1/iemslw==1 code and new code

…n_to_its_own_scheme_and_z0_composite_consistent_tanya_21apr21 Small bug fixes and changes in comments in setalb for ialb=1 or 2.

Changes necessary to remove GSD_SURFACE_FLUXES_BUGFIX from ccpp-physics

…l dimension

…_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

…composite_consistent' into move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent_gjf

…o_its_own_scheme_and_z0_composite_consistent_gjf Copy FV3 changes in GFS_phys_time_vary.fv3.F90/meta to SCM versions

Ensure consistency between model namelist and CCPP suite definition file UPDATED with head of MAIN

albedo.

…on_to_its_own_scheme_and_z0_composite_consistent_tgs Removed SNET.

…d GFS_interstitialtoscreen

…_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

…t, _timestep_init, _timestep_final, _final routines; use horizontal_loop_extent in _run routines

…ion_to_its_own_scheme_and_z0_composite_consistent Move sfc emis alb calculation to its own scheme and z0 composite consistent

…ndencies code

… tendencies code

DomHeinzeller

All code changes (except bug fixes related to the new tendency code) are coming from the authoritative repository and have been reviewed by the appropriate code owners when they were merged into main. Regression testing completed.

tanyasmirnova and others added 30 commits March 26, 2021 19:45

Consistent use of emissivity and albedo between RUC LSM and the

756f2cf

radiation.

Merged Moorthi's changes for fractional grid in setemis.

67ddbbd

Step forward towards fractional albedo and emissivity in the LSM option.

25611d7

Added initialization of 4 albedo components over land and ice to

ed7db4d

GFS_phys_time_vary_init.

Change intent from out to inout for albedo.

ad1ad67

Fixed problems with the initialization of albedo and emissivity.

ea0c6f0

Merge branch 'gsl/develop' of https://github.com/NOAA-GSL/ccpp-physics …

b7cbcce

…into frac_emiss_albedo

Added the code to compute land, water and ice fractions when

d4531cd

frac_grid=.false.

Adding composite changes on top of Tanya's changes

e140651

Merge branch 'bwg_frac_emiss_albedo' of https://github.com/benwgreen/…

efcc07c

…ccpp-physics into HEAD

Move calculation of surface albedo/emissivity out of rrtmg(p) pre sch…

e871573

…emes into GFS_radiation_surface, consolidate, fix bugs

Add initialization of water vapor mixing ratio at the surface to

c4e0873

lsm_ruc_init. This is needed for MYNN surface layer scheme at the first time step.

Bug fix in the composite for ialb=2 option.

cbbafc5

Move call to 'stability' for composites from sfc_diff to GFS_surface_…

8367123

…composites_post, add necessary new interstitial variables, clean up old/unused interstitial variables

Merge branch 'master' of https://github.com/NCAR/ccpp-physics into mo…

823f6ed

…ve_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

Fix merge conflicts

ff766e5

Bugfix in physics/GFS_phys_time_vary.fv3.F90: remove old variables fr…

1a2d365

…om OpenMP

physics/GFS_surface_composites.F90: move computation of cmm and chh a…

a6ade33

…fter call to stability

Add fractional code to ialb=1 option used with the Noah LSM.

d83c1a1

Address reviewer comments

21c87c4

Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…

7525515

…composite_consistent_sfcqv_init' of https://github.com/tanyasmirnova/ccpp-physics into move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

Fix bugs in latest ialbflg==1 code, provide CPP option to switch betw…

4f4be0e

…een original ialbflg==1/iemslw==1 code and new code

Small bug fixes and changes in comments in setalb for ialb=1 or 2.

0119e95

Removed t1 from lsm_ruc_init. Some clean-up.

11daddb

Merge pull request #9 from tanyasmirnova/move_sfc_emis_alb_calculatio…

0fc7b40

…n_to_its_own_scheme_and_z0_composite_consistent_tanya_21apr21 Small bug fixes and changes in comments in setalb for ialb=1 or 2.

Add missing dependency to physics/GFS_surface_composites.meta

2ed6a7c

Removing GSD_SURFACE_FLUXES_BUGFIX and replacing with flag thsfc_loc

b51c5b3

Bugfix

b6d0ede

Merge pull request #10 from benwgreen/thsfc_loc2

986211f

Changes necessary to remove GSD_SURFACE_FLUXES_BUGFIX from ccpp-physics

Add missing variables to physics/GFS_surface_composites.*

d2100a4

climbfuji and others added 16 commits May 18, 2021 13:00

Bug fix in physics/GFS_phys_time_vary.fv3.meta: use correct horizonta…

c661a57

…l dimension

Merge branch 'main' of https://github.com/NCAR/ccpp-physics into move…

60b873f

…_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

copy GFS_phys_time_vary.fv3.F90/meta changes over to SCM versions

329364b

Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…

7468bf8

…composite_consistent' into move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent_gjf

Merge pull request #14 from grantfirl/move_sfc_emis_alb_calculation_t…

a20fc32

…o_its_own_scheme_and_z0_composite_consistent_gjf Copy FV3 changes in GFS_phys_time_vary.fv3.F90/meta to SCM versions

Update metadata for ztmax variables

38f28a2

Update cu_gf_driver.F90

b179486

Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD

37c6b2e

Merge pull request NCAR#661 from climbfuji/consistency_redo_dom_mods

1fd62ea

Ensure consistency between model namelist and CCPP suite definition file UPDATED with head of MAIN

Removed SNET. Net sloar radiation is computed from the incoming SW and

c3375bb

albedo.

Merge pull request #15 from tanyasmirnova/move_sfc_emis_alb_calculati…

01bb2d5

…on_to_its_own_scheme_and_z0_composite_consistent_tgs Removed SNET.

Add timestep_init andd timestep_final versions of GFS_diagtoscreen an…

0a8aa3a

…d GFS_interstitialtoscreen

Merge branch 'main' of https://github.com/NCAR/ccpp-physics into move…

a6df017

…_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

Bug fixes in several metadata files: use horizontal_dimension in _ini…

0350697

…t, _timestep_init, _timestep_final, _final routines; use horizontal_loop_extent in _run routines

Merge pull request NCAR#627 from climbfuji/move_sfc_emis_alb_calculat…

24cc09e

…ion_to_its_own_scheme_and_z0_composite_consistent Move sfc emis alb calculation to its own scheme and z0 composite consistent

Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD

462a870

This was referenced May 31, 2021

Update gsl/develop from develop 2021/05/31 NOAA-GSL/ufs-weather-model#83

Merged

Update gsl/develop from develop 2021/05/31 NOAA-GSL/fv3atm#93

Merged

Update gsl/develop from main 2021/05/31 NOAA-GSL/ccpp-framework#15

Merged

climbfuji added 4 commits June 1, 2021 08:24

Several bug fixes to UGWP v1 and GSL drag suite related to updated te…

09494e6

…ndencies code

Add missing variables to physics/GFS_debug.F90, comment out erroneous…

df632d8

… tendencies code

Fix b4b issue for restart runs with RUC LSM

10ab813

More bug fixes related to tendencies in physics/unified_ugwp.F90

ef5db31

climbfuji marked this pull request as ready for review June 7, 2021 13:50

climbfuji requested a review from DomHeinzeller as a code owner June 7, 2021 13:50

DomHeinzeller requested a review from SamuelTrahanNOAA June 7, 2021 13:52

DomHeinzeller approved these changes Jun 7, 2021

View reviewed changes

SamuelTrahanNOAA approved these changes Jun 7, 2021

View reviewed changes

SamuelTrahanNOAA merged commit 40ad71e into NOAA-GSL:gsl/develop Jun 7, 2021

climbfuji deleted the update_gsl_develop_from_main_20210531 branch June 27, 2022 03:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gsl/develop from main 2021/05/31 #93

Update gsl/develop from main 2021/05/31 #93

climbfuji commented May 31, 2021 •

edited

Loading

DomHeinzeller left a comment

Update gsl/develop from main 2021/05/31 #93

Update gsl/develop from main 2021/05/31 #93

Conversation

climbfuji commented May 31, 2021 • edited Loading

DomHeinzeller left a comment

Choose a reason for hiding this comment

climbfuji commented May 31, 2021 •

edited

Loading