forked from ufs-community/ufs-weather-model
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gsl/develop from develop 2021/05/31 #83
Merged
SamuelTrahanNOAA
merged 15 commits into
NOAA-GSL:gsl/develop
from
climbfuji:update_gsl_develop_from_develop
Jun 7, 2021
Merged
Update gsl/develop from develop 2021/05/31 #83
SamuelTrahanNOAA
merged 15 commits into
NOAA-GSL:gsl/develop
from
climbfuji:update_gsl_develop_from_develop
Jun 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add import and export fields to support fv3-jedi coupling * fd_nems.yaml file is updated to include fields used in fv3-jedi coupling. It is actual file now, not a symlink to a file in CMEPS repo.
…water normalization in CMEPS (ufs-community#549) (ufs-community#585) * add default variables for v16 non-tiled inputs * add script for tiled fix input * add new v16 noahmp test to rt.conf * remove satemdf suite from s2sw compile (unused) * add gaea.intel to rt_35d.conf * add landice variable * add landice setting to benchmark_v16 nml * set landice true for non-noahmp * set landice=false for v16 noahmp tests * add aofrac_normalization * commit removal of fd_nems from correct branch
* Point CDEPS to develop branch of NOAA-EMC/CDEPS * Change application name "DATM" to "NG-GODAS" * Change application name "DATM-NEMS" to "NG-GODAS-NEMSDATM" * Use a mesh file in MOM6 cap instead of a grid file
… consistent (ufs-community#529) Substantial changes to CCPP physics to move surface emissivity/albedo calculation to its own scheme and to make surface roughness length composite consistent when fractional landmask is used. Updates to FV3GFS_io.F90 to write additional fields to the restart files (this requires removing the UGWPv1 warmstart test). Additional changes: Bug fixes for coupled model for GNU from @DeniseWorthen Bug fixes for 35-day runs from @DeniseWorthen Update for CI tests from @MinsukJi-NOAA
This was referenced May 31, 2021
* Most GFSv14/GFSv15 based tests are updated to GFSv16 confiscation, the cold start ICs were created from GFSv16 anaylysis. A GDAS forecast case using IAU is also setup. * Debug tests are added for global regression tests * Regional tests was renamed, and regional threads was added * History file names are changed from "phyf/dynf" to operational file names "sfcf/atmf" * Restart files for baseline comparison are removed from the GFSv16 feature tests, only those tests with restart will still have restart files comparison * There is no change in non-GFS configuration tests using gsd, rrtf, hafs physics package * The first commit has no changes in cpld tests and datm tests. * The inline post issue in post interface post_*.F90 is fixed for gnu compiler. * amip_interp_nml namelist is removed from all the name list files * Unused configuration varaibles: cpl, memuse_verbose, atmos_nthreads, use_hyper_thread, ncores_per_node are removed from model_configure * The issue with inline post restart with gnu compiler is fixed * Input data directory input-data-20210528 has new 172 leves 2021032206 ICs for C96, C192 and C384 global input files. * utest related changes Co-authored-by: denise.worthen <Denise.Worthen@noaa.gov> Co-authored-by: MinsukJi-NOAA <Minsuk.Ji@noaa.gov> Co-authored-by: junwang-noaa <jun.wanag@noaa.gov>
…r-model into update_gsl_develop_from_develop
…_dev.conf after GFS v16 global regression test changes
* Update utest script: Handle global, regional, and coupled tests * Update CI workflow: Instead of saving the docker image (~730 MB) as an artifact, only save the executable (~77 MB) * Add regional thread and decomposition tests to CI * Add coupled restart test to CI * Fix to run threads on its own core in ec2 for thread tests * Use a slightly different ubuntu-hpc image to match the uid and gid within ec2 instances * Exclude L127 control test temporarily
…r-model into update_gsl_develop_from_develop
…/reproducibility issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note. All code changes are coming from the authoritative repository and have been reviewed by the appropriate code owners when they were merged into develop. Regression testing completed.
SamuelTrahanNOAA
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update gsl/develop from develop 2021/05/31. Changes:
Additional changes made in this PR:
fv3_gsd*
regression tests from 600s to 450s to address instability/reproducibility issuestests/default_vars.sh
tests/parm/gsd.nml.IN
Associated PRs:
NOAA-GSL/ccpp-framework#15
NOAA-GSL/ccpp-physics#93
NOAA-GSL/fv3atm#93
#83
Regression testing
Regression testing on
hera.{gnu,intel}
against existing baselines. All regression tests pass except the following, as expected due to missing baselines or changes to the answers (due to the shorter integration time step of 450s). All three tests run to completion.rt_hera_intel_verify_against_existing.log
rt_hera_intel_verify_against_existing_fail_test.log
rt_hera_gnu_verify_against_existing.log
rt_hera_gnu_verify_against_existing_fail_test.log
Regression testing on
hera.{intel,gnu}
usingrt_ccpp_dev.conf
: first create temporary baseline, then verify against it (tests for completion of runs, run-to-run reproducibility, restart reproducibility and GSL dragsuite vs UGWPv1 dragsuite reproducibility): all tests pass.rt_ccpp_dev_hera_gnu_create.log
rt_ccpp_dev_hera_gnu_verify.log
rt_ccpp_dev_hera_intel_create.log
rt_ccpp_dev_hera_intel_verify.log
These PRs are ready for merging.