Skip to content

Commit

Permalink
Remove AirTerminal:SingleDuct:Uncontrolled - revert CV min frac change
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwitte committed Oct 11, 2019
1 parent 40f3ae7 commit 2dca408
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/EnergyPlus/SingleDuct.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ namespace SingleDuct {
}
Sys(SysNum).ReheatAirOutletNode = Sys(SysNum).OutletNodeNum;
Sys(SysNum).MaxAirVolFlowRate = Numbers(1);
Sys(SysNum).ZoneMinAirFrac = 1.0;
Sys(SysNum).ZoneMinAirFrac = 0.0;
Sys(SysNum).ZoneMinAirFracMethod = MinFracNotUsed;
Sys(SysNum).DamperHeatingAction = HeatingActionNotUsed;
if (Sys(SysNum).ReheatComp_Num == HCoilType_SteamAirHeating) {
Expand Down Expand Up @@ -1197,7 +1197,7 @@ namespace SingleDuct {
cAlphaFields(4));

Sys(SysNum).MaxAirVolFlowRate = Numbers(1);
Sys(SysNum).ZoneMinAirFrac = 1.0;
Sys(SysNum).ZoneMinAirFrac = 0.0;
Sys(SysNum).ZoneMinAirFracMethod = MinFracNotUsed;
Sys(SysNum).DamperHeatingAction = HeatingActionNotUsed;

Expand Down

6 comments on commit 2dca408

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1239 of 1239 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2591 of 2619 tests passed, 144 test warnings)

Messages:\n

  • 172 tests had: AUD diffs.
  • 172 tests had: BND diffs.
  • 172 tests had: EIO diffs.
  • 158 tests had: RDD diffs.
  • 13 tests had: ESO small diffs.
  • 30 tests had: MTD diffs.
  • 17 tests had: MTR small diffs.
  • 16 tests had: Table small diffs.
  • 28 tests had: ESO big diffs.
  • 21 tests had: Table big diffs.
  • 17 tests had: MTR big diffs.
  • 4 tests had: ERR diffs.
  • 5 tests had: EDD diffs.
  • 1 test had: MDD diffs.

Failures:\n

regression Test Summary

  • Passed: 661
  • Failed: 28

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2551 of 2579 tests passed, 144 test warnings)

Messages:\n

  • 172 tests had: AUD diffs.
  • 172 tests had: BND diffs.
  • 172 tests had: EIO diffs.
  • 158 tests had: RDD diffs.
  • 13 tests had: ESO small diffs.
  • 30 tests had: MTD diffs.
  • 17 tests had: MTR small diffs.
  • 16 tests had: Table small diffs.
  • 28 tests had: ESO big diffs.
  • 21 tests had: Table big diffs.
  • 17 tests had: MTR big diffs.
  • 4 tests had: ERR diffs.
  • 5 tests had: EDD diffs.
  • 1 test had: MDD diffs.

Failures:\n

regression Test Summary

  • Passed: 641
  • Failed: 28

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (673 of 674 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 673
  • Timeout: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.