Skip to content

Commit

Permalink
Merge pull request #8982 from NREL/PLHP_IDD
Browse files Browse the repository at this point in the history 
Fix weirdness in IDD For HeatPump:PlantLoop:EIR:XXX
  • Loading branch information
@Myoldmopar
Myoldmopar authored Aug 18, 2021
2 parents b353942 + cec0b98 commit 9badf34
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions idd/Energy+.idd.in
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71731,7 +71731,8 @@ HeatPump:PlantLoop:EIR:Cooling,
\note object for this cooling object. The companion is used in
\note sizing the heat pump as well as to allow checks for unexpected
\note simultaneous operation of the two objects.
\reference PLHPHeatingNames
\type object-list
\object-list PLHPHeatingNames
N1, \field Load Side Reference Flow Rate
\note This component is currently a constant-flow device, meaning it will always
\note try to request the full design flow from the central plant manager.
Expand Down Expand Up @@ -71830,8 +71831,7 @@ HeatPump:PlantLoop:EIR:Heating,
\note sizing the heat pump as well as to allow checks for unexpected
\note simultaneous operation of the two objects.
\type object-list
\object-list WWHPCoolingNames
\reference PLHPCoolingNames
\object-list PLHPCoolingNames
N1, \field Load Side Reference Flow Rate
\note This component is currently a constant-flow device, meaning it will always
\note try to request the full design flow from the central plant manager.
Expand Down

6 comments on commit 9badf34

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-MacOS-10.15-clang-11.0.0: OK (2387 of 2387 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8968CoolingDesignSupplyTempIndexIssue (Myoldmopar) - x86_64-MacOS-10.15-clang-11.0.0: Tests Failed (2617 of 3111 tests passed, 179 test warnings)

Messages:\n

  • 493 tests had: Table big diffs.
  • 382 tests had: AUD diffs.
  • 374 tests had: RDD diffs.
  • 79 tests had: Table small diffs.
  • 10 tests had: ESO small diffs.
  • 1 test had: MTR small diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1167
  • Failed: 1

regression Test Summary

  • Passed: 231
  • Failed: 493

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8968CoolingDesignSupplyTempIndexIssue (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2366 of 2366 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8968CoolingDesignSupplyTempIndexIssue (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: Tests Failed (2656 of 3152 tests passed, 180 test warnings)

Messages:\n

  • 496 tests had: Table big diffs.
  • 384 tests had: AUD diffs.
  • 375 tests had: RDD diffs.
  • 79 tests had: Table small diffs.
  • 10 tests had: ESO small diffs.
  • 1 test had: EIO diffs.
  • 1 test had: ESO big diffs.
  • 1 test had: MTD diffs.
  • 1 test had: MTR big diffs.

Failures:\n

regression Test Summary

  • Passed: 248
  • Failed: 496

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8968CoolingDesignSupplyTempIndexIssue (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1662 of 1662 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8968CoolingDesignSupplyTempIndexIssue (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (728 of 728 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.