Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weirdness in IDD For HeatPump:PlantLoop:EIR:XXX #8982

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Fix weirdness in IDD For HeatPump:PlantLoop:EIR:XXX #8982

merged 1 commit into from
Aug 18, 2021

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Aug 18, 2021 •
edited
Loading

Pull request overview

Fix weirdness in IDD For HeatPump:PlantLoop:EIR:XXX (probably copy paste issue?)

Found by @joseph-robertson while wrapping the objects in the OS SDK: https://github.com/NREL/OpenStudio/pull/4368/files#r677422116

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec jmarrec added the IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) label Aug 18, 2021
@jmarrec jmarrec requested a review from Myoldmopar August 18, 2021 09:21
@jmarrec jmarrec self-assigned this Aug 18, 2021
jmarrec
jmarrec commented Aug 18, 2021
View reviewed changes
idd/Energy+.idd.in
Comment on lines +71734 to +71735
\type object-list
\object-list PLHPHeatingNames
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cooling references heating

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this was the wrong type. Good fix.

idd/Energy+.idd.in
@@ -71830,8 +71831,7 @@ HeatPump:PlantLoop:EIR:Heating,
\note sizing the heat pump as well as to allow checks for unexpected
\note simultaneous operation of the two objects.
\type object-list
\object-list WWHPCoolingNames
\reference PLHPCoolingNames
\object-list PLHPCoolingNames
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Heating references Cooling

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was an object-list type but didn't actually have an object-list defined. Nice fix.

@jmarrec jmarrec mentioned this pull request Aug 18, 2021
Merged
19 tasks
@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Aug 18, 2021
@mjwitte mjwitte added this to the EnergyPlus 9.6 IOFreeze milestone Aug 18, 2021
Myoldmopar
Myoldmopar approved these changes Aug 18, 2021
View reviewed changes
idd/Energy+.idd.in
@@ -71830,8 +71831,7 @@ HeatPump:PlantLoop:EIR:Heating,
\note sizing the heat pump as well as to allow checks for unexpected
\note simultaneous operation of the two objects.
\type object-list
\object-list WWHPCoolingNames
\reference PLHPCoolingNames
\object-list PLHPCoolingNames
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was an object-list type but didn't actually have an object-list defined. Nice fix.

idd/Energy+.idd.in
Comment on lines +71734 to +71735
\type object-list
\object-list PLHPHeatingNames
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this was the wrong type. Good fix.

@Myoldmopar
Copy link
Member

No problem with this tiny fix, and CI is happy with it of course. Merging.

@Myoldmopar Myoldmopar merged commit 9badf34 into develop Aug 18, 2021
@Myoldmopar Myoldmopar deleted the PLHP_IDD branch August 18, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

Assignees

@jmarrec jmarrec

Labels
Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)
Projects
None yet
Milestone
EnergyPlus 9.6 IOFreeze
Development

Successfully merging this pull request may close these issues.
7 participants
@jmarrec @Myoldmopar @nrel-bot @nrel-bot-2 @nrel-bot-3 @nrel-bot-2c @mjwitte