Fix Controller:MechanicalVentilation ProportionalControlBasedOnDesignOccupancy #10268

mjwitte · 2023-10-10T19:49:48Z

Pull request overview

Fixes Controller:MechanicalVentilation ProportionalControlBasedOnDesignOccupancy possible error for more than one zone #9969
Streamlines calculation of current CO2 by storing list of applicable people statements instead of looping through all people statements for every vent mech zone every timestep looking for matching zone numbers.
Revised single-zone unit test adds several cases for current zone CO2 above, below, and in between the zone max/min CO2 values. The revised test passes both here and in develop.
Second unit test has three identical zones, so 3x OA flow rate is expected. This test passes here, but fails in develop. See Fix Controller:MechanicalVentilation ProportionalControlBasedOnDesignOccupancy #10268 (comment)

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…2Control9969

mjwitte · 2023-10-19T18:52:42Z

Single-zone unit test passes in develop, but 3-zone unit test fails in develop.

[----------] 2 tests from EnergyPlusFixture
[ RUN      ] EnergyPlusFixture.CO2ControlDesignOccupancyTest
[       OK ] EnergyPlusFixture.CO2ControlDesignOccupancyTest (14693 ms)
[ RUN      ] EnergyPlusFixture.CO2ControlDesignOccupancyTest3Zone
C:\MJWGit\EnergyPlus\tst\EnergyPlus\unit\MixedAir.unit.cc(1263): error: The difference between 3 * expectedOAMassFlow and oaController.OAMassFlow is 0.0039677399219509683, which exceeds 0.00001, where
3 * expectedOAMassFlow evaluates to 0.024854760000000004,
oaController.OAMassFlow evaluates to 0.020887020078049035, and
0.00001 evaluates to 1.0000000000000001e-05.
C:\MJWGit\EnergyPlus\tst\EnergyPlus\unit\MixedAir.unit.cc(1264): error: The difference between 3 * expectedOAMassFlow / oaController.MixMassFlow and oaController.MinOAFracLimit is 0.0019449705499759648, which exceeds 0.00001, where
3 * expectedOAMassFlow / oaController.MixMassFlow evaluates to 0.012183705882352942,
oaController.MinOAFracLimit evaluates to 0.010238735332376977, and
0.00001 evaluates to 1.0000000000000001e-05.
[  FAILED  ] EnergyPlusFixture.CO2ControlDesignOccupancyTest3Zone (37483 ms)
[----------] 2 tests from EnergyPlusFixture (52178 ms total)

mjwitte

Code walkthru.

mjwitte · 2023-10-19T19:32:39Z

src/EnergyPlus/MixedAir.cc

+                for (int peopleNum = 1; peopleNum <= state.dataHeatBal->TotPeople; ++peopleNum) {
+                    for (auto &thisMechVentZone : vent_mech.VentMechZone) {
+                        if (state.dataHeatBal->People(peopleNum).ZonePtr == thisMechVentZone.zoneNum) {
+                            thisMechVentZone.peopleIndexes.push_back(peopleNum);


Save list of applicable people instances.

mjwitte · 2023-10-19T19:33:08Z

src/EnergyPlus/MixedAir.cc

@@ -3672,19 +3684,18 @@ Real64 VentilationMechanicalProps::CalcMechVentController(EnergyPlusData &state,
    // new local variables for DCV
    // Zone OA flow rate based on each calculation method [m3/s]
    std::array<Real64, static_cast<int>(DataSizing::OAFlowCalcMethod::Num)> ZoneOACalc{0.0};
-    Real64 CO2PeopleGeneration = 0; // CO2 generation from people at design level


Narrow scope for this.

That's a great thing.

mjwitte · 2023-10-19T19:34:21Z

src/EnergyPlus/MixedAir.cc

-                                            for (int PeopleNum = 1; PeopleNum <= state.dataHeatBal->TotPeople; ++PeopleNum) {
-                                                if (state.dataHeatBal->People(PeopleNum).ZonePtr != ZoneNum) continue;
+                                            Real64 CO2PeopleGeneration = 0.0;
+                                            for (int const PeopleNum : thisMechVentZone.peopleIndexes) {


Loop through only the applicable people instances, not all of them. Also reset sum to zero for each zone (previously this kept accumulating across zones).

mjwitte · 2023-10-19T19:34:40Z

testfiles/CMakeLists.txt

@@ -355,6 +355,7 @@ add_simulation_test(IDF_FILE HeatPumpIAQP_DCV.idf EPW_FILE USA_IL_Chicago-OHare.
 add_simulation_test(IDF_FILE HeatPumpIAQP_GenericContamControl.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCV.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCVDesignRate.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
+add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCVDesignOccAllZones.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)


Add a test file that uses this control type.

Sounds good to me.

mjwitte · 2023-10-19T19:36:52Z

tst/EnergyPlus/unit/MixedAir.unit.cc

+    Real64 zoneCO2Max = 431.08678;
+    Real64 zoneCO2Min = 400.0;
+
+    // Case 1 - Zone CO2 greater than CO2 Max, so OA flow is flow/area+flow/person


Single-zone test, three cases.

mjwitte · 2023-10-19T19:37:38Z

tst/EnergyPlus/unit/MixedAir.unit.cc

+    EXPECT_NEAR(expectedOAMassFlow / oaController.MixMassFlow, oaController.MinOAFracLimit, 0.00001);
+}
+
+TEST_F(EnergyPlusFixture, CO2ControlDesignOccupancyTest3Zone)


3-zone test, identical to single-zone test but with 3 zones, expect 3x OA flow rates.

…2Control9969

Myoldmopar · 2023-11-02T17:34:50Z

The Windows build failure is unrelated, as is the one small diff that pops up occasionally. I'll pull develop in and build while looking this over.

Myoldmopar

Looks like fine little fix and cleanup with sufficient tests to me.

Myoldmopar · 2023-11-02T19:08:31Z

src/EnergyPlus/MixedAir.cc

@@ -3672,19 +3684,18 @@ Real64 VentilationMechanicalProps::CalcMechVentController(EnergyPlusData &state,
    // new local variables for DCV
    // Zone OA flow rate based on each calculation method [m3/s]
    std::array<Real64, static_cast<int>(DataSizing::OAFlowCalcMethod::Num)> ZoneOACalc{0.0};
-    Real64 CO2PeopleGeneration = 0; // CO2 generation from people at design level


That's a great thing.

Myoldmopar · 2023-11-02T19:08:52Z

src/EnergyPlus/MixedAir.hh

@@ -286,6 +286,7 @@ namespace MixedAir {
        DataSizing::OAFlowCalcMethod ZoneOAFlowMethod = DataSizing::OAFlowCalcMethod::PerPerson; // OA flow method for each zone
        int ZoneOASchPtr = 0;              // Index to the outdoor air schedule for each zone (from DesignSpecification:OutdoorAir or default)
        Real64 OAPropCtlMinRateSchPtr = 0; // Outdoor design OA flow rate schedule from DesignSpecification:OutdoorAir
+        EPVector<int> peopleIndexes; // List of People objects in this zone (for SystemOAMethod == DataSizing::SysOAMethod::ProportionalControlDesOcc)


Yay, a nice little EPVector!

Myoldmopar · 2023-11-02T19:09:47Z

testfiles/CMakeLists.txt

@@ -355,6 +355,7 @@ add_simulation_test(IDF_FILE HeatPumpIAQP_DCV.idf EPW_FILE USA_IL_Chicago-OHare.
 add_simulation_test(IDF_FILE HeatPumpIAQP_GenericContamControl.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCV.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCVDesignRate.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
+add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCVDesignOccAllZones.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)


Sounds good to me.

Myoldmopar · 2023-11-02T19:10:41Z

Everything tests out perfectly fine, and the changes look good. Merging this. Thanks @mjwitte

mjwitte added 3 commits September 26, 2023 11:56

Mech vent people list for CO2 control

654c174

Merge remote-tracking branch 'remotes/origin/develop' into VentMechCO…

9d3b640

…2Control9969

Merge remote-tracking branch 'remotes/origin/develop' into VentMechCO…

99733f8

…2Control9969

mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Oct 10, 2023

mjwitte added 4 commits October 18, 2023 16:33

Testfile HeatPumpProportionalControl_DCVDesignOccAllZones.idf

43b5c30

Merge remote-tracking branch 'remotes/origin/develop' into VentMechCO…

d5bc44d

…2Control9969

Unit test

28e753a

More unit test

c47134d

mjwitte marked this pull request as ready for review October 19, 2023 18:52

mjwitte commented Oct 19, 2023

View reviewed changes

Merge remote-tracking branch 'remotes/origin/develop' into VentMechCO…

ad3f000

…2Control9969

Myoldmopar approved these changes Nov 2, 2023

View reviewed changes

Myoldmopar merged commit b99411d into develop Nov 2, 2023
10 checks passed

Myoldmopar deleted the VentMechCO2Control9969 branch November 2, 2023 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Controller:MechanicalVentilation ProportionalControlBasedOnDesignOccupancy #10268

Fix Controller:MechanicalVentilation ProportionalControlBasedOnDesignOccupancy #10268

mjwitte commented Oct 10, 2023 •

edited

Loading

mjwitte commented Oct 19, 2023

mjwitte left a comment

mjwitte Oct 19, 2023

mjwitte Oct 19, 2023

Myoldmopar Nov 2, 2023

mjwitte Oct 19, 2023

mjwitte Oct 19, 2023

Myoldmopar Nov 2, 2023

mjwitte Oct 19, 2023

mjwitte Oct 19, 2023

Myoldmopar commented Nov 2, 2023

Myoldmopar left a comment

Myoldmopar Nov 2, 2023

Myoldmopar Nov 2, 2023

Myoldmopar Nov 2, 2023

Myoldmopar commented Nov 2, 2023

Fix Controller:MechanicalVentilation ProportionalControlBasedOnDesignOccupancy #10268

Fix Controller:MechanicalVentilation ProportionalControlBasedOnDesignOccupancy #10268

Conversation

mjwitte commented Oct 10, 2023 • edited Loading

Pull request overview

Pull Request Author

Reviewer

mjwitte commented Oct 19, 2023

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar commented Nov 2, 2023

Myoldmopar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar commented Nov 2, 2023

mjwitte commented Oct 10, 2023 •

edited

Loading