Fix Controller:MechanicalVentilation ProportionalControlBasedOnDesignOccupancy

src/EnergyPlus/MixedAir.cc

@@ -2824,6 +2824,18 @@ void InitOAController(EnergyPlusData &state, int const OAControllerNum, bool con
                 }
             }
 
+            // Fill People index lists if needed
+            if (vent_mech.SystemOAMethod == DataSizing::SysOAMethod::ProportionalControlDesOcc) {
+                for (int peopleNum = 1; peopleNum <= state.dataHeatBal->TotPeople; ++peopleNum) {
+                    for (auto &thisMechVentZone : vent_mech.VentMechZone) {
+                        if (state.dataHeatBal->People(peopleNum).ZonePtr == thisMechVentZone.zoneNum) {
+                            thisMechVentZone.peopleIndexes.push_back(peopleNum);
+                            break;
+                        }
+                    }
+                }
+            }
+
             // Check to see if any zones on an air loop are not accounted for by a mechanical ventilation object
             for (int AirLoopZoneInfoZoneNum = 1; AirLoopZoneInfoZoneNum <= state.dataAirLoop->AirLoopZoneInfo(AirLoopNum).NumZones;
                  ++AirLoopZoneInfoZoneNum) {
@@ -3672,19 +3684,18 @@ Real64 VentilationMechanicalProps::CalcMechVentController(EnergyPlusData &state,
     // new local variables for DCV
     // Zone OA flow rate based on each calculation method [m3/s]
     std::array<Real64, static_cast<int>(DataSizing::OAFlowCalcMethod::Num)> ZoneOACalc{0.0};
-    Real64 CO2PeopleGeneration = 0; // CO2 generation from people at design level
-    Real64 ZoneOABZ;                // Zone breathing-zone OA flow rate [m3/s]
-    Real64 ZoneOA;                  // Zone OA flow rate [m3/s]
-    Real64 ZoneOAFrac;              // Zone OA fraction (as a fraction of actual supply air flow rate)
-    Real64 SysOAuc;                 // System uncorrected OA flow rate
-    Real64 SysOA;                   // System supply OA volume flow rate [m3/s]
-    Real64 SysEv;                   // System ventilation efficiency
-    Real64 NodeTemp;                // node temperature
-    Real64 NodeHumRat;              // node humidity ratio
-    Real64 ZoneMaxCO2 = 0.0;        // Breathing-zone CO2 concentartion
-    Real64 ZoneMinCO2 = 0.0;        // Minimum CO2 concentration in zone
-    Real64 ZoneOAMin = 0.0;         // Minimum Zone OA flow rate when the zone is unoccupied (i.e. ZoneOAPeople = 0)
-    Real64 ZoneOAMax = 0.0;         // Maximum Zone OA flow rate (ZoneOAPeople + ZoneOACalc[static_cast<int>(DataSizing::OAFlowCalcMethod::PerArea)])
+    Real64 ZoneOABZ;         // Zone breathing-zone OA flow rate [m3/s]
+    Real64 ZoneOA;           // Zone OA flow rate [m3/s]
+    Real64 ZoneOAFrac;       // Zone OA fraction (as a fraction of actual supply air flow rate)
+    Real64 SysOAuc;          // System uncorrected OA flow rate
+    Real64 SysOA;            // System supply OA volume flow rate [m3/s]
+    Real64 SysEv;            // System ventilation efficiency
+    Real64 NodeTemp;         // node temperature
+    Real64 NodeHumRat;       // node humidity ratio
+    Real64 ZoneMaxCO2 = 0.0; // Breathing-zone CO2 concentartion
+    Real64 ZoneMinCO2 = 0.0; // Minimum CO2 concentration in zone
+    Real64 ZoneOAMin = 0.0;  // Minimum Zone OA flow rate when the zone is unoccupied (i.e. ZoneOAPeople = 0)
+    Real64 ZoneOAMax = 0.0;  // Maximum Zone OA flow rate (ZoneOAPeople + ZoneOACalc[static_cast<int>(DataSizing::OAFlowCalcMethod::PerArea)])
     Real64 MechVentOAMassFlow = 0.0;
 
     // Apply mechanical ventilation only when it is available/allowed
@@ -3946,8 +3957,8 @@ Real64 VentilationMechanicalProps::CalcMechVentController(EnergyPlusData &state,
                                         // Calculate zone maximum target CO2 concentration in PPM
                                         if (this->SystemOAMethod == DataSizing::SysOAMethod::ProportionalControlDesOcc) {
                                             // Accumulate CO2 generation from people at design occupancy and current activity level
-                                            for (int PeopleNum = 1; PeopleNum <= state.dataHeatBal->TotPeople; ++PeopleNum) {
-                                                if (state.dataHeatBal->People(PeopleNum).ZonePtr != ZoneNum) continue;
+                                            Real64 CO2PeopleGeneration = 0.0;
+                                            for (int const PeopleNum : thisMechVentZone.peopleIndexes) {
                                                 CO2PeopleGeneration +=
                                                     state.dataHeatBal->People(PeopleNum).NumberOfPeople *
                                                     state.dataHeatBal->People(PeopleNum).CO2RateFactor *

src/EnergyPlus/MixedAir.hh

@@ -286,6 +286,7 @@ namespace MixedAir {
         DataSizing::OAFlowCalcMethod ZoneOAFlowMethod = DataSizing::OAFlowCalcMethod::PerPerson; // OA flow method for each zone
         int ZoneOASchPtr = 0;              // Index to the outdoor air schedule for each zone (from DesignSpecification:OutdoorAir or default)
         Real64 OAPropCtlMinRateSchPtr = 0; // Outdoor design OA flow rate schedule from DesignSpecification:OutdoorAir
+        EPVector<int> peopleIndexes; // List of People objects in this zone (for SystemOAMethod == DataSizing::SysOAMethod::ProportionalControlDesOcc)
     };
 
     struct VentilationMechanicalProps // Derived type for Ventilation:Mechanical data

testfiles/CMakeLists.txt

@@ -355,6 +355,7 @@ add_simulation_test(IDF_FILE HeatPumpIAQP_DCV.idf EPW_FILE USA_IL_Chicago-OHare.
 add_simulation_test(IDF_FILE HeatPumpIAQP_GenericContamControl.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCV.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCVDesignRate.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
+add_simulation_test(IDF_FILE HeatPumpProportionalControl_DCVDesignOccAllZones.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpSecondaryCoil.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpSimpleDCV.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE HeatPumpVRP_DCV.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)