Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10287 - ExpandObjects - Incorrect warning about Boiler:HotWater having too many fields #10288

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix #10287 - ExpandObjects - Incorrect warning about Boiler:HotWater having too many fields #10288

merged 1 commit into from
Nov 8, 2023

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Oct 30, 2023

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec
Naive try at fixing incorrect ExpandObjects warning
9dee65f 
An extra field was added for Boiler:HotWater in #9925

```shell
$ /Applications/EnergyPlus-23-2-0/energyplus -D -d out -x /Applications/EnergyPlus-23-2-0/ExampleFiles/VAVSingleDuctConstFlowBoiler.idf

$ cat out/eplusout.experr
ExpandObjects: SEVERE: Too many fields were found for the object: Boiler:HotWater, Number expected=[17], Number found=[18]
`
``
@jmarrec jmarrec added Defect Includes code to repair a defect in EnergyPlus AuxiliaryTool Related to an auxiliary tool, not EnergyPlus itself (readvars, preprocessor, ep-launch, etc.) labels Oct 30, 2023
jmarrec
jmarrec commented Oct 30, 2023
View reviewed changes
src/ExpandObjects/epfilter.f90
@@ -1507,7 +1507,7 @@ PROGRAM epfilter
INTEGER,PARAMETER :: blrhwNameOff = 1
INTEGER,PARAMETER :: blrhwInletNodeOff = 11
INTEGER,PARAMETER :: blrhwOutletNodeOff = 12
INTEGER,PARAMETER :: blrhwLastFieldOff = 17
INTEGER,PARAMETER :: blrhwLastFieldOff = 18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra field was added, total number is 18

src/ExpandObjects/epfilter.f90
@@ -2305,7 +2305,7 @@ SUBROUTINE SetUpObjectsToProcess(doGatherSurfaces)
CALL AddObjToProcess('HVACTemplate:Plant:MixedWaterLoop',.TRUE., mwpNameOff, mwpLdDistSchmOff, 17)
CALL AddObjToProcess('HVACTemplate:System:DedicatedOutdoorAir',.TRUE.,doasNameOff, doasHumidSetPtSchedNameOff, 46)
! Detailed Plant Objects
CALL AddObjToProcess('Boiler:HotWater',.FALSE., blrhwOutletNodeOff, blrhwLastFieldOff, 17)
CALL AddObjToProcess('Boiler:HotWater',.FALSE., blrhwOutletNodeOff, blrhwLastFieldOff, 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether I need to bump 17 to 18 here or not.

@jmarrec jmarrec self-assigned this Oct 30, 2023
@jmarrec jmarrec requested a review from Myoldmopar October 30, 2023 17:49
@jmarrec
Copy link
Contributor Author

jmarrec commented Oct 30, 2023

Also not sure if I need to do CALL AddToObjStr('Off Cycle Parasitic Fuel Load {W}','0') after https://github.com/NREL/EnergyPlus/blob/d07d7ad64207285b241ab79b67b66ed98e2db594/src/ExpandObjects/epfilter.f90#L26185

The End Use Subcategory isn't being explicitly written. But the Off Cycle does not have a default (though it defaults to 0.0 W in the C++ code... I wish the E+.idd did have an explicit \default 0.0

@jmarrec jmarrec marked this pull request as ready for review November 6, 2023 13:20
@jmarrec
Copy link
Contributor Author

jmarrec commented Nov 6, 2023

Before:

$ $ep_build/Products/energyplus -x -D -d out-ori VAVSingleDuctConstFlowBoiler.idf
ExpandObjects Started.
No expanded file generated.
ExpandObjects Finished with Error(s). Time:     0.023
EnergyPlus Starting

[...]

$ cat out-ori/eplusout.experr 
ExpandObjects: SEVERE: Too many fields were found for the object: Boiler:HotWater, Number expected=[17], Number found=[18]

After

$ $ep_build/Products/energyplus -x -D -d out-new VAVSingleDuctConstFlowBoiler.idf
ExpandObjects Started.
No expanded file generated.
ExpandObjects Finished. Time:     0.014
EnergyPlus Starting

[...]

$ cat out-new/eplusout.experr
cat: out-new/eplusout.experr: No such file or directory

mjwitte
mjwitte approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @jmarrec

@mjwitte mjwitte merged commit 16d5a46 into develop Nov 8, 2023
13 checks passed
@eringold eringold mentioned this pull request Apr 26, 2024
Closed
@jmarrec jmarrec deleted the ExpandObjects_BoilerHotWater branch April 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwitte mjwitte mjwitte approved these changes

@Myoldmopar Myoldmopar Awaiting requested review from Myoldmopar

Assignees

@mjwitte mjwitte

@jmarrec jmarrec

Labels
AuxiliaryTool Related to an auxiliary tool, not EnergyPlus itself (readvars, preprocessor, ep-launch, etc.) Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExpandObjects - Incorrect warning about Boiler:HotWater having too many fields
7 participants
@jmarrec @mjwitte @nrel-bot @nrel-bot-2 @nrel-bot-3 @nrel-bot-2b @nrel-bot-2c