-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align PlantLowFlowRateToler
with DataHVACGlobals::VerySmallMassFlow
#10457
Conversation
PlantLowFlowRateToler
with SmallWaterVolFlow
PlantLowFlowRateToler
with DataBranchAirLoopPlant::MassFlowTolerance
PlantLowFlowRateToler
with DataBranchAirLoopPlant::MassFlowTolerance
PlantLowFlowRateToler
src/EnergyPlus/DataConvergParams.hh
Outdated
constexpr Real64 PlantFlowFlowRateToler(0.01); // Tolerance for mass flow rate convergence (in kg/s) | ||
constexpr Real64 PlantLowFlowRateToler(0.000001); // Tolerance for low flow rate used for determining when plant pumps can be shut down | ||
constexpr Real64 PlantFlowFlowRateToler(0.01); // Tolerance for mass flow rate convergence (in kg/s) | ||
constexpr Real64 PlantLowFlowRateToler(1.0E-30); // Tolerance for low mass flow rate used for determining when plant pumps can be shut down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolute tolerances are defined below (perhaps these should be relative to the plant loop flows?):
EnergyPlus/src/EnergyPlus/DataHVACGlobals.hh
Lines 72 to 79 in 9d7789a
Real64 constexpr SmallHumRatDiff(1.0E-7); | |
Real64 constexpr SmallTempDiff(1.0E-5); | |
Real64 constexpr SmallMassFlow(0.001); | |
Real64 constexpr VerySmallMassFlow(1.0E-30); | |
Real64 constexpr SmallLoad(1.0); | |
Real64 constexpr TempControlTol(0.1); // temperature control tolerance for packaged equip. [deg C] | |
Real64 constexpr SmallAirVolFlow(0.001); | |
Real64 constexpr SmallWaterVolFlow(1.0E-9); |
To avoid further failures, probably the best (and the most consistent with what's already use) is
DataHVACGlobals::VerySmallMassFlow
. It is currently only used for airloops but its name doesn't exclude other fluids.
Once converted to 24.1 the defect files complete successfully without running into this issue. It is possible that other incremental changes on the component sides are preventing very low flow requests. |
PlantLowFlowRateToler
PlantLowFlowRateToler
with DataHVACGlobals::VerySmallMassFlow
I merged the develop and resolved conflicts. CI is all happy here. This PR looks fully clean and ready to go. @Myoldmopar |
Thanks @dareumnam ! Merging this in now. |
Pull request overview
Align
PlantLowFlowRateToler
withDataHVACGlobals::VerySmallMassFlow
so minimum pump flow rate can be correctly enforced during simulations.Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.