Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerance for high humidity OA control #7647

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Dec 6, 2019

Pull request overview

  • Fixes OA controller high humidity control needs a tolerance #7644
  • The high humidity control option in Controller:OutdoorAir would somewhat randomly bring in excess outdoor air when the indoor and outdoor humidity ratios were essentially equal. Adding a small tolerance makes the control more consistent.
  • Diffs expected for UnitarySystem_FurnaceWithDXSystemRHControl.idf and others with this control.

Explanation of Diffs

These test files have OA controller "High Humidity Control" = Yes.
FurnaceWithDXSystemRHControl, HeatPumpAirToAirWithRHControl, HPAirToAir_wSolarCollectorHWCoil, HP_wICSSolarCollector, HVACStandAloneERV_Economizer, UnitarySystem_FurnaceWithDXSystemRHControl, and UnitarySystem_WaterCoils_wMultiSpeedFan. Six of these are showing small or large eso diffs, as expected.

Looking at UnitarySystem_FurnaceWithDXSystemRHControl, for example. The following chart shows before and after, zone humidity ratio, OA humidity ratio, and "Air System Outdoor Air High Humidity Control Status". See how the high humidity control was kicking on randomly on the winter design day (left end of chart). After the fix, it stays off.

image
image

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Dec 6, 2019
@@ -75,6 +75,7 @@ namespace DataHVACGlobals {

// MODULE PARAMETER DEFINITIONS:

Real64 const SmallHumRatDiff(1.0E-7);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using new approach for global constants - just declare it right in the header. Better for compiler optimization instead of using extern. Tempted to change all of these here, but don't want to muddy the waters.

@@ -4593,7 +4593,8 @@ namespace MixedAir {
if (ZoneSysMoistureDemand(this->HumidistatZoneNum).TotalOutputRequired < 0.0) {
// IF OAController is not allowed to modify air flow during high outdoor humrat condition, then disable modified air flow
// if indoor humrat is less than or equal to outdoor humrat
if (!this->ModifyDuringHighOAMoisture && Node(this->NodeNumofHumidistatZone).HumRat <= this->OAHumRat) {
if (!this->ModifyDuringHighOAMoisture &&
(Node(this->NodeNumofHumidistatZone).HumRat - this->OAHumRat) <= DataHVACGlobals::SmallHumRatDiff) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require delta humrat to be > SmallHumRatDiff to activate high humidity flow rate.

OAController(ControllerNum).MixMassFlow = 2.5;
OAController(ControllerNum).MaxOAMassFlowRate = 2.5;

// Case 1 - OA humrat = zone humrat - no high humidity operation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New unit test with 4 cases.

@mitchute
Copy link
Collaborator

@mjwitte this looks good. It looks like CI is having issues again, so I'll merge this once that has a chance to get worked out.

@mitchute
Copy link
Collaborator

Merging. Some of the expected-diff files have tanks, so make sure to pull develop into #7541 before reviewing.

@mitchute mitchute merged commit 6300210 into develop Dec 10, 2019
@mjwitte mjwitte deleted the HighHumEcono7644 branch December 10, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OA controller high humidity control needs a tolerance
4 participants