-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tolerance for high humidity OA control #7647
Conversation
@@ -75,6 +75,7 @@ namespace DataHVACGlobals { | |||
|
|||
// MODULE PARAMETER DEFINITIONS: | |||
|
|||
Real64 const SmallHumRatDiff(1.0E-7); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using new approach for global constants - just declare it right in the header. Better for compiler optimization instead of using extern
. Tempted to change all of these here, but don't want to muddy the waters.
@@ -4593,7 +4593,8 @@ namespace MixedAir { | |||
if (ZoneSysMoistureDemand(this->HumidistatZoneNum).TotalOutputRequired < 0.0) { | |||
// IF OAController is not allowed to modify air flow during high outdoor humrat condition, then disable modified air flow | |||
// if indoor humrat is less than or equal to outdoor humrat | |||
if (!this->ModifyDuringHighOAMoisture && Node(this->NodeNumofHumidistatZone).HumRat <= this->OAHumRat) { | |||
if (!this->ModifyDuringHighOAMoisture && | |||
(Node(this->NodeNumofHumidistatZone).HumRat - this->OAHumRat) <= DataHVACGlobals::SmallHumRatDiff) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require delta humrat to be > SmallHumRatDiff
to activate high humidity flow rate.
OAController(ControllerNum).MixMassFlow = 2.5; | ||
OAController(ControllerNum).MaxOAMassFlowRate = 2.5; | ||
|
||
// Case 1 - OA humrat = zone humrat - no high humidity operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New unit test with 4 cases.
@mjwitte this looks good. It looks like CI is having issues again, so I'll merge this once that has a chance to get worked out. |
Merging. Some of the expected-diff files have tanks, so make sure to pull develop into #7541 before reviewing. |
Pull request overview
Explanation of Diffs
These test files have OA controller "High Humidity Control" = Yes.
FurnaceWithDXSystemRHControl, HeatPumpAirToAirWithRHControl, HPAirToAir_wSolarCollectorHWCoil, HP_wICSSolarCollector, HVACStandAloneERV_Economizer, UnitarySystem_FurnaceWithDXSystemRHControl, and UnitarySystem_WaterCoils_wMultiSpeedFan. Six of these are showing small or large eso diffs, as expected.
Looking at UnitarySystem_FurnaceWithDXSystemRHControl, for example. The following chart shows before and after, zone humidity ratio, OA humidity ratio, and "Air System Outdoor Air High Humidity Control Status". See how the high humidity control was kicking on randomly on the winter design day (left end of chart). After the fix, it stays off.
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.