Add missing references for support of FanSystemModel in various HVAC/ZoneHVAC components

[jmarrec]

Pull request overview

• Fixes Fan:SystemModel inconsistencies in IDD #7697
• Add missing references for support of FanSystemModel in various components
• Also propagated upstream some differences we had had to make in OpenStudio/resources/energyplus/ProposedEnergy+.idd to avoid failures in our forward translator (which is more strictly enforcing IDD references than E+)
• For context, the needs for these changes have been discovered while writting up the third (and hopefully) PR to support FanSystemModel in OpenStudio: Fan System Model: adjust OpenStudio & EnergyPlus IDDs to support all types OpenStudio#3864. I also wrote a regression test in parallel in Add test for newly added Fan:SystemModel OpenStudio-resources#92 that should test all (I think) 17 HVAC/ZoneHVACComponent that support it with a FanSystemModel

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[mjwitte]

@jmarrec Not sure if this was ready for review yet, but made some comments anyway.

[mjwitte]

I don't think this is correct. Generators with waste heat recovery can sit on a branch, but they are not dispatchable by the load management. So, I don't think they belong in plant or condenser equipment lists. @Myoldmopar ?

[jmarrec]

If you use an ElectricLoadCenter:Distribution object with a scheme like FollowThermalLimitElectric, then you do have to put in a PlantEquipmentOperation:HeatingLoad don't you?

That's what I'm doing in the OpenStudio-resources regression test for Generator:MicroTurbine at least... https://github.com/NREL/OpenStudio-resources/blob/9d16ac6aba234794c84438a679ce4ff54710dcc5/model/simulationtests/generator_microturbine.rb#L385

[mjwitte]

I'm not really sure if that does anything. You may be correct. @Myoldmopar @EnergyArchmage ?

[MatthewSteen]

I happen to be working with the Generator:MicroTurbine by adding it to the MediumOffice reference building (using Julien's generator_microturbine.rb code, thanks btw!), and can confirm that the PlantEquipmentOperation:HeatingLoad is needed for the ElectricLoadCenter:Distribution > FollowThermalLimitElectrical case to have any effect on a model.

[mjwitte]

Not sure solar collectors belong on PlantEquipmentLists? @mitchute @Myoldmopar ?

[mitchute]

Looks to me like it should be there:

EnergyPlus/src/EnergyPlus/SolarCollectors.hh

Line 128 in bcfdd25

struct CollectorData : PlantComponent

[jmarrec]

Lots of confusion on what the placement of solar collectors should be, especially since OpenStudio forces you to put the Flat Plate ones on the supply side (for some reason... and it appears to work fine too...)
I agree that generally speaking the documentation and example files in E+ seem to imply demand side placement (with control of the loop via availability managers).

References:

• https://unmethours.com/question/27837/which-side-of-the-plant-loop-for-solar-collector-in-eopenstudio/
• solar collectors are not allowed on the demand side of plant loops OpenStudio#2880
• IntegratedCollectorStorage object being incorrectly added to the PlantEquipmentList OpenStudio#3761 (comment)

[jmarrec]

Opening a dedicated issue for this instead: #7735

[EnergyArchmage]

It is possible for a chp generator to be operated in a thermal load following scheme. I think @jmarrec is correct. Just glanced at comments.

[jmarrec]

in Microgeneration.idf, the Generator:MicroCHP for eg is on a PlantEquipmentList used in a PlantEquipmentOperation:HeatingLoad.

(Note that I added the reference for Generator:MicroTurbine but not for Generator:MicroCHP simply because I modified that stuff while testing things that are implemented in OS, and MicroTurbine is but MicroCHP isn't. Edit: actually MicroCHP already has the same references)

[mjwitte]

@jmarrec I'm ok with the responses to prior comments. I've tested this with IDF Editor validity check for about 2 dozen idf files that contain Fan:SystemModel. All passed without errors. I've updated to current develop and will wait for one more round of CI results, then merge this.