Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for Outdoor Air Details report #8685

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Unit test for Outdoor Air Details report #8685

merged 5 commits into from
Apr 29, 2021

Conversation

mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Mar 31, 2021

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Mar 31, 2021
@mjwitte mjwitte mentioned this pull request Mar 31, 2021
10 tasks
@mjwitte mjwitte requested a review from Myoldmopar April 16, 2021 16:35
@mitchute
Copy link
Collaborator

I just ran the unit tests locally and everything passed just fine. I'll review the code while CI takes one more pass.

@mitchute
Copy link
Collaborator

Clever mass balance check. This looks good to me. Merging.

@mitchute mitchute merged commit 2381b24 into develop Apr 29, 2021
@mitchute mitchute deleted the OADetailsPart3 branch April 29, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants