New Outdoor Air Details report #8529

mjwitte · 2021-02-11T22:20:44Z

Pull request overview

This PR supersedes #7629.

This version keeps the existing Outdoor Air Summary report and adds the new report as Outdoor Air Details.

Currently, users seeking to use EnergyPlus for LEED work need to document the use of Outdoor Air (OA) in their models. While the current Outdoor Air Summary in EnergyPlus provides some information to help these users, it does not provide enough information. Users often find it difficult to compare the OA delivered for proposed vs. baseline simulations, especially with economizers and zone equipment. This new feature adds a new Outdoor Air Details tabular report to include zone HVAC equipment, add tracking and table outputs for minimum requested outdoor air flow, track times when the delivered outdoor air is less than the minimum required and provide outputs in standard air density.

The needs of this enhancement were discussed in issue #5298

The new feature proposal provides further detail.

Resolves #5298.
Resolves #5846 (final piece)

ToDo List

Unfinished business from this PR is documented in #8550

Documentation - Input Output Reference
Documentation - Output Details and Examples
Populate Times for Outdoor Air Limiting Factors During Occupancy subtable
Populate Average Outdoor Air For Each Outdoor Air Limiting Factors During Occupancy subtable
Code cleanup - remove commented sections - fix warning
Possibly reorganize new variables - seems like lots of different places, not sure all the new variables are in appropriate places
Look for efficiency improvements (currently at about -0.1% performance)
Unit tests
QA the numbers in the report

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…EnergyPlus into EnhanceOutdoorAirReporting

…Target Ventilation - Voz-dyn"

…doorAirReporting2

Myoldmopar · 2021-02-16T20:03:22Z

From a quick CI scan, looks like acceptable RDD and Audit diffs, though Mac is complaining about some build warnings that should be cleaned up. I see this is still marked as draft so I will not dive in any deeper than this right now.

mjwitte · 2021-02-16T20:36:27Z

@Myoldmopar Getting close, added a todo list at the top. Some things could wait until after I/O Freeze as a followup.

…doorAirReporting2

mjwitte

Code walkthrough.

mjwitte · 2021-02-18T03:04:39Z

idd/Energy+.idd.in

-       \memo There should be as many fields (A) in this object as there are keys in the following (minus
-       \memo AllSummary+AllMonthly+AllSummaryAndMonthly)


This object, Output:Table:SummaryReports has been incredibly long for a long time (https://github.com/NREL/EnergyPlusArchive/commit/7134906aa552086d7fc76fafde2158efe85fe2ac). Taking a bold step here and reducing it to 25 report names in the IDD instead of 82. It's extensible, so any long objects should run just fine. It might trip up someone using IDF Editor, but it seems time to shorten this.

I am fine with that bold step.

mjwitte · 2021-02-18T03:05:13Z

idd/Energy+.idd.in

@@ -98551,6 +98549,7 @@ Output:Table:SummaryReports,
       \key ComponentSizingSummary
       \key CoilSizingDetails
       \key OutdoorAirSummary
+       \key OutdoorAirDetails


New report key. This report is included automatically with AllSummary* options.

mjwitte · 2021-02-18T03:05:46Z

idd/Energy+.idd.in

@@ -101001,5981 +101023,7 @@ Output:Table:SummaryReports,
       \key ThermalResilienceSummary
       \key CO2ResilienceSummary
       \key VisualResilienceSummary
-   A25, \field Report 25 Name


The field-ectomy begins here.

mjwitte · 2021-02-18T03:08:21Z

src/EnergyPlus/AirflowNetworkBalanceManager.cc

+            Real64 StdDensInfilVolume = (state.dataAirflowNetworkBalanceManager->exchangeData(i).SumMCp / CpAir / state.dataEnvrn->StdRhoAir) *
+                                        ReportingConstant; // compute volume using standard density air
+            // MJWToDo - Separate AFN Vent and InfilVolFlow


Sum AFN infiltration and ventilation (well, once #8475 is addressed).

mjwitte · 2021-02-18T03:09:39Z

src/EnergyPlus/DataHeatBalance.hh

+
+        // OA Reports - accumulated values
+        // All Vol variables are in m3
+        Real64 MechVentVolTotalOcc;       // volume for mechanical ventilation of outside air for entire simulation during occupied at current


Rename some of the existing Outdoor Air Summary variables to help keep them separate from the new report. The old report is only for occupied hours, so add "Occ" to some names.

OK, I think that is reasonable.

mjwitte · 2021-02-18T03:29:56Z

src/EnergyPlus/SystemReports.cc

@@ -4452,6 +4664,24 @@ namespace EnergyPlus::SystemReports {
            state.dataSysRpts->ZoneOAVolFlowStdRho(CtrlZoneNum) = state.dataSysRpts->ZoneOAMassFlow(CtrlZoneNum) / state.dataEnvrn->StdRhoAir;
            state.dataSysRpts->ZoneOAVolStdRho(CtrlZoneNum) = state.dataSysRpts->ZoneOAVolFlowStdRho(CtrlZoneNum) * TimeStepSys * DataGlobalConstants::SecInHour;

+            // set time mechanical+natural ventilation is below, at, or above target Voz-dyn


Gather zone table values.

mjwitte · 2021-02-18T03:30:09Z

src/EnergyPlus/SystemReports.cc

@@ -4524,7 +4780,55 @@ namespace EnergyPlus::SystemReports {
            } else {
            }
        } // loop over controlled zones
-    }
+
+        // loop over air loops


Gather air loop table values.

mjwitte · 2021-02-18T03:30:56Z

src/EnergyPlus/SystemReports.hh

+    struct SysPreDefRepType
+    {
+        Real64 SysMechVentTotal;           // air loop mechanical vent total volume OA at standard density {m3}


New struct for airloop tables.

mjwitte · 2021-02-18T03:33:09Z

src/EnergyPlus/SystemReports.hh

+    Array1D<Real64> ZoneOAVolFlowCrntRho;         // zone mech vent volume flow rate at current density {m3/s}
+    Array1D<Real64> ZoneOAVolCrntRho;             // zone mech vent total volume OA at current density {m3}
+    Array1D<Real64> ZoneMechACH;                  // zone mech vent air changes per hour {ACH}
+    Array1D<Real64> ZoneTargetVentilationFlowVoz; // zone target ventilation ventilation flow based on 62.1 Voz-dyn {m3/s}


New zone and system variables for tracking various timestep values to accumulate. Many of these are new output variables.

mjwitte · 2021-02-18T03:34:02Z

src/EnergyPlus/ZoneEquipmentManager.cc

@@ -1001,6 +1001,7 @@ namespace EnergyPlus::ZoneEquipmentManager {
                FinalZoneSizing(CtrlZoneNum).HeatDesTempDiff = ZoneSizingInput(ZoneSizNum).HeatDesTempDiff;
                FinalZoneSizing(CtrlZoneNum).CoolDesHumRat = ZoneSizingInput(ZoneSizNum).CoolDesHumRat;
                FinalZoneSizing(CtrlZoneNum).HeatDesHumRat = ZoneSizingInput(ZoneSizNum).HeatDesHumRat;
+                FinalZoneSizing(CtrlZoneNum).ZoneAirDistributionIndex = ZoneSizingInput(ZoneSizNum).ZoneAirDistributionIndex;


This is needed in order to fetch the DesignSpecification:AirTerminal:Sizing data.

mjwitte · 2021-02-18T03:38:17Z

@Myoldmopar This is ready for review. There are some pieces missing that will need to get fleshed out after I/O freeze if this passes muster enough to make it in.

Myoldmopar

This is quite a lot, but I am so thankful for the IDD cleanup. I don't imagine anyone will have needed all 82 extensible fields in that input object. I am building and running locally, but this looks good to go in.

Myoldmopar · 2021-02-19T14:24:41Z

doc/input-output-reference/src/overview/group-air-distribution.tex

@@ -160,6 +160,56 @@ \subsubsection{Outputs}\label{outputs-1-001}

 Reports the air changes per hour in the zone due to the outside fresh air supplied by mechanical ventilation system.

+\paragraph{Zone Target Voz Ventilation Flow Rate {[}m3/s{]}}\label{zone-target-voz-ventilation-flow-rate}


Lots of new ventilation outputs, OK.

Myoldmopar · 2021-02-19T14:26:38Z

doc/input-output-reference/src/standard-output-reports/output-table-summaryreports.tex

@@ -172,6 +172,27 @@ \subsubsection{Predefined Annual Summary Reports}\label{predefined-annual-summar
  Minimum Outside Air During Occupied Hours table shows for each zone the average and nominal number of occupants, the zone volume, the minimum air change rate based on mechanical ventilation, infiltration and simple ventilation during occupied hours.
 \end{itemize}

+\paragraph{Outdoor Air Details}\label{outdoor-air-details}
+
+The Outdoor Air Details report (key: OutdoorAirDetails) produces a report that includes the following tables:


OK, so this is the section that describes the new tabular report, if the user enters the OutdoorAirDetails key. I was expecting to find a list of all the possible keys in this section which would need this key added, but I guess that's not here. Just in the IDD itself.

Myoldmopar · 2021-02-19T14:27:05Z

idd/Energy+.idd.in

-       \memo There should be as many fields (A) in this object as there are keys in the following (minus
-       \memo AllSummary+AllMonthly+AllSummaryAndMonthly)


I am fine with that bold step.

Myoldmopar · 2021-02-19T14:28:19Z

src/EnergyPlus/DataHeatBalance.hh

+
+        // OA Reports - accumulated values
+        // All Vol variables are in m3
+        Real64 MechVentVolTotalOcc;       // volume for mechanical ventilation of outside air for entire simulation during occupied at current


OK, I think that is reasonable.

Myoldmopar · 2021-02-19T14:28:28Z

src/EnergyPlus/DataHeatBalance.hh

+        Real64 AFNInfilVolMin;            // a large number since finding minimum volume at current zone air density
+        Real64 SimpVentVolTotalOcc;       // volume for simple 'ZoneVentilation' of outside air for entire simulation during occupied current
+        Real64 SimpVentVolMin;            // a large number since finding minimum volumeat current zone air density
+        Real64 MechVentVolTotalStdDen;    // volume for mechanical ventilation of outside air for entire simulation at standard density


Also reasonable.

Myoldmopar · 2021-02-19T14:29:01Z

src/EnergyPlus/DataSizing.cc

@@ -965,6 +945,31 @@ namespace DataSizing {
        }
    }

+    Real64 ZoneAirDistributionData::calculateEz(EnergyPlusData &state, int const ZoneNum) // Zone index


Looks good to me.

Myoldmopar · 2021-02-19T14:29:18Z

src/EnergyPlus/DataZoneEquipment.cc

-                ZoneOAMin = ZoneOAArea / ZoneEz;
-                ZoneOAMax = (ZoneOAArea + ZoneOAPeople) / ZoneEz;
+                ZoneOAMin = ZoneOAArea;
+                ZoneOAMax = (ZoneOAArea + ZoneOAPeople);


Good catch!

Myoldmopar · 2021-02-19T14:31:02Z

src/EnergyPlus/OutputReportTabular.cc

-                                                                                  Zone(iZone).Multiplier * Zone(iZone).ListMultiplier),
-                                         3);
+                            Zone(iZone).Name,
+                            ZonePreDefRep(iZone).MechVentVolTotalOcc / (ZonePreDefRep(iZone).TotTimeOcc * Zone(iZone).Volume *


OK, so a bunch of changes for the Occ suffix on those existing variables.

Myoldmopar · 2021-02-19T15:00:26Z

CI results are in order. The 500 server errors are not on us.

Locally testing is all good, this is ready to merge. Thanks @mjwitte and @JasonGlazer

JasonGlazer added 30 commits November 13, 2019 08:33

Initial NFP file

59114ba

Initial proposed content

4c63912

Updated NFP

8b26888

Merge branch 'develop' into EnhanceOutdoorAirReporting

5a97b6c

NFP including changes in response to comments received

b632fb8

Merge branch 'develop' into EnhanceOutdoorAirReporting

70e13b2

Another update to NFP

243e627

Merge branch 'develop' into EnhanceOutdoorAirReporting

520ce8a

Merge branch 'EnhanceOutdoorAirReporting' of https://github.com/NREL/…

f6e1312

…EnergyPlus into EnhanceOutdoorAirReporting

Changed heading "Dynamic Zone Outdoor Airflow - Voz-dyn" to "Dynamic …

da53323

…Target Ventilation - Voz-dyn"

Merge branch 'develop' into EnhanceOutdoorAirReporting

0ae002b

Initial predefined report variables and column headings

11c3aaa

Implement occupant reporting

fc7d24f

Merge branch 'develop' into EnhanceOutdoorAirReporting

52763c5

Mark columns that need to be completed.

6f24b04

Merge branch 'develop' into EnhanceOutdoorAirReporting

c8c66a9

Add airloop name(s) to each zone row.

6e65e11

Reorg new code.

2dd9928

Updated NFP to include design documentation.

fd1a677

Fix typo

584c793

Merge branch 'develop' into EnhanceOutdoorAirReporting

c069a9b

Add Voz for mech vent param table

2561548

Adding some total rows.

5187094

Restructure to not show plenum

448a365

Merge branch 'develop' into EnhanceOutdoorAirReporting

bad63ef

Implement Minimum Dynamic Target Ventilation - Voz-dyn-min column

bca6f44

Continued work on Total Outdoor Air by Zone subtable

0b75938

Rename variables for clarity and add total rows for some new columns

91b152d

Switch to using standard air density instead of current air density

55ce999

Merge branch 'develop' into EnhanceOutdoorAirReporting

134b8f6

mjwitte added this to the EnergyPlus 9.5.0 IOFreeze milestone Feb 11, 2021

mjwitte added 3 commits February 12, 2021 11:50

OA Report - fix failures and other cleanup

1ba4beb

OA Report - fix row order diffs in LEED summary

d7529f9

Merge remote-tracking branch 'remotes/origin/develop' into EnhanceOut…

ce50351

…doorAirReporting2

mjwitte mentioned this pull request Feb 15, 2021

Enhance outdoor air tabular reporting-superseded by 8529 #7629

Closed

20 tasks

mjwitte changed the title ~~Enhance outdoor air tabular reporting B~~ Enhance outdoor air tabular reporting Feb 15, 2021

mjwitte changed the title ~~Enhance outdoor air tabular reporting~~ Enhance outdoor air tabular reporting - new Outdoor Air Details report Feb 15, 2021

mjwitte added 3 commits February 15, 2021 15:23

Merge remote-tracking branch 'remotes/origin/develop' into EnhanceOut…

f774401

…doorAirReporting2

OA Report - really fix row order diffs in LEED summary

415f7bd

OA Report - populate airloop subtables

584533e

mjwitte changed the title ~~Enhance outdoor air tabular reporting - new Outdoor Air Details report~~ New Outdoor Air Details report Feb 16, 2021

mjwitte added 6 commits February 16, 2021 18:56

OA Report - IO reference

eb7f102

OA Report - delete totals for airloop subtables and other cleanup

13496df

Merge remote-tracking branch 'remotes/origin/develop' into EnhanceOut…

0cc3832

…doorAirReporting2

OA Report - IO reference new output variables and some other cleanup

2c2412b

OA Report - move implicit array inits to loops

2975ee1

OA Report - clean out unused variables

fc571df

mjwitte marked this pull request as ready for review February 18, 2021 03:00

mjwitte commented Feb 18, 2021

View reviewed changes

mjwitte added 2 commits February 17, 2021 21:39

OA Report - correction and cleanup

ddbcf51

OA Report - another correction

f14b842

Myoldmopar approved these changes Feb 19, 2021

View reviewed changes

Myoldmopar merged commit 35dbafc into develop Feb 19, 2021

Myoldmopar deleted the EnhanceOutdoorAirReporting2 branch February 19, 2021 15:00

mjwitte mentioned this pull request Feb 19, 2021

Outdoor Air Details Followup #8550

Closed

10 tasks

mjwitte mentioned this pull request Mar 31, 2021

Unit test for Outdoor Air Details report #8685

Merged

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Outdoor Air Details report #8529

New Outdoor Air Details report #8529

mjwitte commented Feb 11, 2021 •

edited

Loading

Myoldmopar commented Feb 16, 2021

mjwitte commented Feb 16, 2021

mjwitte left a comment

mjwitte Feb 18, 2021

Myoldmopar Feb 19, 2021

mjwitte Feb 18, 2021

mjwitte Feb 18, 2021

mjwitte Feb 18, 2021

mjwitte Feb 18, 2021

Myoldmopar Feb 19, 2021

mjwitte Feb 18, 2021

mjwitte Feb 18, 2021

mjwitte Feb 18, 2021

mjwitte Feb 18, 2021

mjwitte Feb 18, 2021

mjwitte commented Feb 18, 2021

Myoldmopar left a comment

Myoldmopar Feb 19, 2021

Myoldmopar Feb 19, 2021

Myoldmopar Feb 19, 2021

Myoldmopar Feb 19, 2021

Myoldmopar Feb 19, 2021

Myoldmopar Feb 19, 2021

Myoldmopar Feb 19, 2021

Myoldmopar Feb 19, 2021

Myoldmopar commented Feb 19, 2021

		\memo There should be as many fields (A) in this object as there are keys in the following (minus
		\memo AllSummary+AllMonthly+AllSummaryAndMonthly)

		@@ -160,6 +160,56 @@ \subsubsection{Outputs}\label{outputs-1-001}

		Reports the air changes per hour in the zone due to the outside fresh air supplied by mechanical ventilation system.

		\paragraph{Zone Target Voz Ventilation Flow Rate {[}m3/s{]}}\label{zone-target-voz-ventilation-flow-rate}

New Outdoor Air Details report #8529

New Outdoor Air Details report #8529

Conversation

mjwitte commented Feb 11, 2021 • edited Loading

Pull request overview

ToDo List

Pull Request Author

Reviewer

Myoldmopar commented Feb 16, 2021

mjwitte commented Feb 16, 2021

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Feb 18, 2021

Myoldmopar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar commented Feb 19, 2021

mjwitte commented Feb 11, 2021 •

edited

Loading